1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-19 18:25:38 +00:00
Commit graph

14277 commits

Author SHA1 Message Date
Charles Kerr
7905244320
fix: missing fmt::arg calls in GTK client () 2022-03-25 12:16:29 -05:00
Charles Kerr
b94c6796c8
fix: sonarcloud warnings ()
* fix: add default case to switch statement

* fix: remove redundant static specifier

* fix: use std::optional.value_or

* fix: make type of variable pointer-to-const

* refactor: move log state into a struct

* refactor: make tr_peerMgr constructor explicit

* fix: make type of variable pointer-to-const

* fix: replace insert with try_emplace

* fix: implicit conversion may lose precision

* fix: use init-statement to reduce variable scope

* chore: mark unused return value with (void)
2022-03-25 00:24:04 -05:00
Ali
0a8cfba3b3
Add ability to change piece size during torrent creation in MacOS GUI… ()
* Add ability to change piece size during torrent creation in MacOS GUI ()

* Shouldn't have committed the xcodeproj file
2022-03-24 22:26:21 -05:00
JP-Ellis
cf6f279830
Fix finding system PSL library ()
Whilst the library file my be called `libpsl`, CMake expects there to be a `lib` in front and thus the existing code was actually looking for `liblibpsl`.

Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-03-24 21:14:11 -05:00
Charles Kerr
bd895b5052
test: fix file-info test edge case () 2022-03-24 19:03:15 -05:00
Charles Kerr
6e8f9f3ff0
feat: add tr_strbuf ()
* feat: add tr_strbuf class for building tmp strings

Based on fmt::basic_memory_buf, this is a growable string buffer that
has an initial size that's large enough to build most filenames or URLs
without needing heap allocations.

Adds a couple of extra helpers such as a `c_str()` method to make dealing
with old zero-terminated string APIs easier.
2022-03-24 16:41:29 -05:00
Charles Kerr
783fa500e7
fix: set the utp state change log level to trace ()
Fixes .
2022-03-24 13:46:34 -05:00
Charles Kerr
f19c09ad9b
fix: bugprone-narrowing-conversions warnings in bitfield.cc () 2022-03-24 08:31:00 -05:00
Charles Kerr
b8c3778cf4
fix: sonarcloud warnings ()
* fix: break will never be executed

* refactor: compile the name fallback string

* fix: replace redundant type with auto

* fix: use init-statement to reduce variable scope

* fix: implicit conversion loses precision

* fix: use in-class initializer

* fix: make variable a pointer-to-const

* fix: local variable name shadows class variable

* fix: implicit conversion may lose precision
2022-03-24 00:18:41 -05:00
Charles Kerr
6db3fbfe64
perf: tell curl_share to share everything () 2022-03-23 22:02:18 -05:00
SweetPPro
791f59e8ba
fix for editing magnet link tracker list ()
Co-authored-by: SweetPPro <sweetppro@users.noreply.github.com>
2022-03-23 10:18:06 -05:00
David Beinder
53dc3a41b4
fix: return correct bitfield when fully downloaded ()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-03-22 14:01:07 -05:00
Charles Kerr
04a4f4a10c
refactor: a little more logging ()
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-03-22 11:45:56 -05:00
SweetPPro
6e1b89d9a7
fixes "no data found..." error on restart for paused torrents ()
Co-authored-by: SweetPPro <sweetppro@users.noreply.github.com>
2022-03-21 16:15:53 -05:00
Charles Kerr
03ee0028d4
refactor: tr_sys_path_dirname returns a std::string () 2022-03-21 15:22:50 -05:00
Charles Kerr
fcc1510ecb
refactor: use fmt to build the GTK client's user-visible strings ()
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-03-21 09:15:48 -05:00
Charles Kerr
44e30bf092
perf: avoid excess filesystem checks () 2022-03-18 16:31:25 -05:00
Charles Kerr
7b837bca1f
fixup! refactor: remove deep logging () ()
handle new log levels in daemon cli invocation
2022-03-18 14:15:43 -05:00
Charles Kerr
68646df4e3
docs: add pid-file to transmission-daemon manpage ()
Fixes .

Co-authored-by: Tim Tassonis <stuff@decentral.ch>
2022-03-18 12:59:45 -05:00
Charles Kerr
22499c677a
refactor: aggregate bandwidth objects () 2022-03-18 11:34:29 -05:00
Matan Ziv-Av
c07bac4e19
Limit bandwidth used by a group of torrents ()
* Add support for bandwidth groups. i.e. Bandwidth limit for a (user specified) group of torrents,
2022-03-18 08:11:59 -05:00
Charles Kerr
6cb0498486
fix: log unexpected announce/scrape keys ()
Fixes .
2022-03-17 19:31:24 -05:00
Charles Kerr
fa8aaf7631
refactor: remove remaining vararg log messages () 2022-03-17 17:39:06 -05:00
Charles Kerr
5df252d1e1
fix: calculate ratio as uploaded / sizeWhenDone () 2022-03-17 13:41:48 -05:00
Charles Kerr
ce10a5314a
fixup! fix: ensure all bytes read / written to file () ()
fix: infinite loop when pread returns 0
2022-03-17 10:41:02 -05:00
Charles Kerr
54ef7341a2
refactor: fmt pt 4 ()
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-03-16 19:23:44 -05:00
SweetPPro
4f2472cd93
Update Torrent.mm () 2022-03-16 15:16:23 -05:00
Charles Kerr
0be920156b
refactor: fmt part 3 () 2022-03-15 19:51:36 -05:00
Charles Kerr
72a67054ea
refactor: fmt part 2 () 2022-03-15 09:52:16 -05:00
Charles Kerr
a942c67199
refactor: use fmt ()
* deps: use fmt (8.1.1 tag) to build log strings

Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-03-13 23:43:35 -05:00
Charles Kerr
2bd42f8225
fixup: macos log error ()
* fix: assertion failure in MessageWindowController

* feat: update messagwindow xib to new log levels
2022-03-12 11:42:43 -06:00
Charles Kerr
91d5388954
fix: memory corruption in RPC when fetching torrent piece info ()
Thanks to MatanZ for finding and tracking down this problem

Fixes .
2022-03-12 10:39:34 -06:00
Mike Gelfand
065cf1146f
Switch to Strawberry Perl for AppVeyor Windows builds () 2022-03-12 18:49:39 +03:00
Charles Kerr
749bb591fb
feat: stop logging repetitive warnings ()
Fixes 
2022-03-11 16:06:58 -06:00
Charles Kerr
d2f8e1d4e0
refactor: set logging levels () 2022-03-11 15:09:22 -06:00
Charles Kerr
af339a15ed
refactor: remove deep logging ()
* refactor: remove "deep logging"
2022-03-09 23:51:14 -06:00
Charles Kerr
1bafbd18ac
chore: add more descriptive assertion in bitfield ()
Related to 
2022-03-09 17:43:42 -06:00
Charles Kerr
7a227917ff
fix: rpc-server shutdown assertion failure ()
Fixes .
2022-03-09 11:13:51 -06:00
Markus Amalthea Magnuson
143c5f5381
Added ability to filter on error status. () 2022-03-07 01:01:01 -05:00
Charles Kerr
0ac8c6079a
refactor: remove redundant MAX_BLOCK_SIZE constant () 2022-03-04 23:35:22 -08:00
Charles Kerr
cdd819772d
feat: tr_runInEventThread() now takes std::function, typesafe args () 2022-03-04 20:26:03 -08:00
Charles Kerr
8d8ea2f4df
perf: use condition variables during tr thread startup ()
* perf: use condition variables during tr thread startup
2022-03-04 14:43:56 -08:00
Charles Kerr
0cd3eb26ff
fix: webseed assertion failures () 2022-03-04 12:00:42 -08:00
LaserEyess
377c335d0f
fix broken ip address string size on windows ()
Make sure the buffer is at least as big as an ipv6 address

Co-authored-by: LaserEyess <LaserEyess@users.noreply.github.com>
2022-03-03 21:17:28 -08:00
SweetPPro
a009a7f930
migrate macOS client to using tr_sessionLoadTorrents ()
* migrate macOS client to using tr_sessionLoadTorrents

With this PR the macOS client now loads torrents at startup using `tr_sessionLoadTorrents`

The history file is used in tandem to provide macOS specific additions
2022-03-02 15:11:04 -08:00
Charles Kerr
60ef1abadf
refactor: tr_torrents ()
* refactor: add tr_torrents container
2022-03-01 15:06:29 -08:00
FallenWarrior2k
e7272fc340
fix(daemon): wait for network-online.target ()
network.target does not guarantee interfaces are fully configured, which
can result in bound addresses not being available when the daemon
starts. This leads to errors on start-up and potentially broken
connectivity.
network-online.target does provide these guarantees, but needs a
slightly different dependency configuration with Wants= on top of After=
(cf. systemd.special(7)).

Closes .
2022-02-28 19:25:07 -08:00
Charles Kerr
d115ee6dfb
refactor: remove utils dep from peer-io () 2022-02-28 14:26:26 -08:00
dependabot[bot]
e3d1a251d8
build(deps): bump url-parse from 1.5.4 to 1.5.10 in /web ()
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.4 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.4...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-28 06:15:32 -08:00
LaserEyess
3bc21fe8a6
fixup: unix socket implementation changes ()
* Use std::unique_ptr for bindAddress

* fixup: unix socket implementation changes

Assortment of changes and comments from 

- actually assign variables in the tr_rpc_address union for ipv4 and
  ipv6
- use std::size() instead of std::string.length()
- add [[maybe_unused]] to bindUnixSocket() args for Windows
- fix error log for windows to to actually print a string instead of
  an enum int
- use C++ style cast for ecvonnlistener_new_bind()
- refactor rpc URL log line to only substitute a single string
- remove redundant tr_rpc+address_is_valid() check

* change TrUnixSocketPrefix to std::string_view

This allows for removing runtime overhead of strlen() in a few places.

Co-authored-by: WeebDataHoarder <57538841+WeebDataHoarder@users.noreply.github.com>
Co-authored-by: LaserEyess <LaserEyess@users.noreply.github.com>
2022-02-27 14:05:08 -08:00