Commit Graph

74 Commits

Author SHA1 Message Date
Mike Gelfand 9f8402697b Use C++11 range-based `for` loops (Qt client) 2015-04-18 14:41:06 +00:00
Mike Gelfand d96ef13a89 Define QT_NO_CAST_FROM_ASCII (Qt client)
Use latin1 encoding most of the time where default encoding was used
before. Qt 4 assumes latin1 by default while Qt 5 uses utf-8 which is
not what we want.

Use utf-8 encoding in some places where default encoding was used before.
This includes strings coming from RPC.

Fix an issue with SortMode::names[] (filters.cc) where missing comma
between "sort-by-queue" and "sort-by-ratio" resulted in two array entries
being merged into solid "sort-by-queuesort-by-ratio" string and all the
following items being shifted compared to their enum counterparts.
2015-01-29 21:53:05 +00:00
Mike Gelfand e707e8d4c5 Treat command-line arguments as UTF-8-encoded; hide char* Prefs setter, require explicit conversion 2015-01-28 22:57:46 +00:00
Mike Gelfand b96cd0369e Change sharing consent dialog into a QMessageBox 2015-01-04 12:29:10 +00:00
Mike Gelfand 81c3eebbab Use Faenza (1.3.1) as fallback on systems which do not support icon themes 2015-01-04 02:14:58 +00:00
Mike Gelfand 440f482d01 Replace tabs with spaces; remove trailing spaces 2015-01-02 11:15:31 +00:00
Mike Gelfand c64ca900c2 Rework torrent options dialog in Qt client to load from .ui 2014-12-29 04:03:56 +00:00
Mike Gelfand 17d6666b4c A bit of harmless refactoring
Prefer C++-style over C-style type casting.
Use qApp instead of QApplication/QCoreApplication::instance().
Use explicit QString::fromLatin1()/fromUtf8() where applicable.
2014-12-27 14:07:14 +00:00
Mike Gelfand 1eec889832 #4050: Use TRANSLATIONS_DIR macro as a hint for Qt client translation files location 2014-12-22 01:08:19 +00:00
Mike Gelfand 629281a1e2 Fix license wording in Qt client .cc files to match the rest of the code. 2014-12-21 23:49:39 +00:00
Mike Gelfand 737fdab775 Do not use void to denote argumentless functions in C++ code 2014-12-14 11:57:23 +00:00
Mike Gelfand 2adbb42763 Fix various cppcheck comments for Qt client code 2014-12-12 23:52:17 +00:00
Mike Gelfand 67dc1c8485 Strip spaces around :: in C++ code (Qt client) 2014-12-12 23:05:10 +00:00
Mike Gelfand faf1b2fbdf #5848: Use theme-provided icons in Qt client (patch by equeim + small additions) 2014-12-12 21:47:22 +00:00
Mike Gelfand fed15dc29d Fix a couple of ordinary and pedantic warnings
Add previously missing -Wall to warning flags in CMake. Remove -Wformat
and -Wvariadic-macros (enabled by default; latter is not meaningful in
C99 mode we use), -Wdeclaration-after-statement (again, not needed as
we use C99). Move -Wmissing-declarations to C-only flags (GCC man says
so).

Add copyrights year to crypto-utils-fallback.c.
2014-12-11 05:11:02 +00:00
Mike Gelfand b4a662ba37 Create QDBusConnection after QApplication has been initialized
Doing otherwise causes Qt warning "QDBusConnection: session D-Bus
connection created before QCoreApplication. Application may misbehave."
Also, don't try to do anything D-Bus-related if connection fails.
2014-12-01 21:05:44 +00:00
Jordan Lee 870041d92d (trunk) #4160: mike.dld patch: 4160-08-args.patch 2014-09-21 18:06:28 +00:00
Jordan Lee cd7e5291db silence warnings found by clang++ 2014-05-09 02:32:28 +00:00
Jordan Lee 4b9626bb83 Licensing changes:
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed

2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)

3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
Jordan Lee 4904b923fb (trunk) restore copyright year as suggested in email by rms 2014-01-18 20:56:57 +00:00
Jordan Lee 3cf26eb273 revert quint64/quint32/qint64/qint32 use to inttypes to match libtransmission's API 2013-08-29 00:37:37 +00:00
Jordan Lee f3d35b0da3 instead of inttypes, use Qt integral types -- eg, s/uint64_t/quint64/ 2013-08-24 19:42:51 +00:00
Jordan Lee 1c79173459 support qt5 in transmission-qt 2013-07-27 21:58:14 +00:00
Jordan Lee dbb742f667 (qt) merge together the two 'add url/magnet link' dialogs. 2013-02-09 23:11:17 +00:00
Jordan Lee 6123bb5359 (qt) copyediting: modify more files to the new indentation/whitespace formatting 2013-01-26 01:19:54 +00:00
Jordan Lee b95040f0a2 (qt) #4917 'request for 256x256 icon for transmission-qt': patch by krab 2013-01-22 19:00:40 +00:00
Jordan Lee 2262c7c565 (qt) #5239 'client should have the option to play a sound when the download completes' -- use QApplication::beep() on OS X and Mac. Patch by rb07 2013-01-21 21:48:52 +00:00
Jordan Lee b42a7ebdc3 (qt) Qt client should have the option to play a sound when the download completes, as the Mac and GTK+ clients do -- implemented. 2013-01-20 23:57:09 +00:00
Jordan Lee c4276d832e Tweak the text of the First Time User legal dialog. 2013-01-16 20:55:08 +00:00
Jordan Lee 59d1d58d0f oops, I didn't mean to commit these debugging cerr's 2012-12-30 22:53:33 +00:00
Jordan Lee 84c5be5a77 (trunk, qt) #5060 'start minimized to tray option' -- added. 2012-12-30 22:51:55 +00:00
Jordan Lee 3c9640bb8f make tr_info.webseedCount and tr_info.trackerCount unsigned. 2012-12-30 22:06:45 +00:00
Jordan Lee e96ed247fe refactor libtransmission's tr_benc class as tr_variant. 2012-12-14 04:34:42 +00:00
Jordan Lee 0f8edabdf7 (trunk qt) #4820 -- add rb07's patch for better opening of magnet links 2012-07-13 00:29:40 +00:00
Jordan Lee 54bf01fe0d revert r12008 due to i18n problems reported by lin-unix in <https://trac.transmissionbt.com/ticket/4050#comment:5> 2012-07-09 23:22:36 +00:00
Jordan Lee 5b53b62773 (trunk qt) #4428 "Conversion to QString in "New torrent" dialog assumes the input string is ASCII" -- fix many ascii-to-QString assumptions in the code. 2011-08-20 05:19:27 +00:00
Jordan Lee 320bda5ca4 (trunk qt) remove an unnecessary debug message 2011-07-30 13:19:28 +00:00
Jordan Lee 0b2247cc7b (trunk qt) add popup notification for when torrents finish downloading. 2011-07-26 02:56:30 +00:00
Jordan Lee 6754258823 (trunk qt) #4050 "transmission-qt translations don't load under Linux" -- fixed via patch from taem 2011-02-23 02:16:16 +00:00
Jordan Lee 2e3ccd8532 (trunk qt) #3938 "the defualt config directory isn't created by the Qt client" -- minor revision to r11755 to handle the case of custom config directories passed in via the command line.
transmission-daemon and transmission-gtk will create these custom config directories if they don't exist. transmission-qt should, too.
2011-01-23 18:40:29 +00:00
Jordan Lee d38634a3f7 (trunk qt) #3938 "The default config directory isn't created by the Qt client" -- fixed.
Summary says it all. Patch by luksan with minor formatting changes (and, no doubt, a new bug) by me.
2011-01-23 16:55:15 +00:00
Charles Kerr b03984d039 (trunk qt) #3766 "Qt client i18n improvements" -- committed patch from rb07 2010-11-25 03:00:25 +00:00
Charles Kerr c01c18b46b (trunk) make --version/-V behave the same in the other apps too 2010-08-09 00:18:26 +00:00
Charles Kerr 711fb98126 (trunk qt) fix bug passing magnet links & urls via DBUS. reported by rb07 in the forums. 2010-08-06 14:50:57 +00:00
Charles Kerr fb03acbbc2 (trunk) consistency tweaks between the GTK+ and Qt client:
1. synchronize some of the keyboard shortcuts
2. synchronize some text in the preferences dialog
3. add a "Desktop" tab in the Qt client's preferences dialog
4. add a "Donate" button to the Qt client's help menu
2010-08-02 03:07:42 +00:00
Charles Kerr 1477c8909f (trunk qt) synchronize the copyright notices 2010-08-01 20:36:13 +00:00
Charles Kerr 3fa4865863 (trunk) #3450 "regression: Qt client dbus support broken" -- fixed 2010-08-01 18:55:04 +00:00
Charles Kerr c4cac7ae8c (trunk qt) #3469 "Qt client should have desktop notification for added torrents" -- done. 2010-08-01 15:47:42 +00:00
Charles Kerr 040bc734f8 (trunk) fix a documentation error in the RPC spec. lastAnnounceResult is a string, not an int 2010-08-01 14:51:28 +00:00
Charles Kerr ab7fafcf42 (trunk qt) silence a spurious cerr linefeed 2010-07-30 22:22:52 +00:00