948f597d15
refactor: buffer snake case ( #4682 )
2023-01-27 20:12:09 -06:00
7367d465b5
style: use the new paragraph comment style everywhere ( #4634 )
2023-01-22 13:21:30 -06:00
d290ece0c8
perf: recycle DH MSE keys iff peer was unreachable ( #4412 )
2022-12-19 16:49:26 -06:00
5743758edd
Revert "perf: recycle Diffie-Hellman keys iff peer was unreachable ( #4408 )"
...
This reverts commit 35a0211118
2022-12-19 15:12:33 -06:00
35a0211118
perf: recycle Diffie-Hellman keys iff peer was unreachable ( #4408 )
2022-12-19 14:45:01 -06:00
cc4141c619
fixup: 3899255 ( #4394 )
2022-12-18 11:18:25 -06:00
e6d75a4b77
refactor: tr_peerIo ( #4372 )
2022-12-16 01:23:12 -06:00
6f1153cae4
refactor: tr_handshake ( #4362 )
2022-12-13 19:58:39 -06:00
2f6315b649
refactor: tr_handshake lifecycle ( #4358 )
2022-12-13 11:59:21 -06:00
0061e4f9a9
refactor: tr_address::display_name() ( #4335 )
2022-12-08 16:44:19 -06:00
9a5d9a0ba2
refactor: tr_peer_socket ( #4325 )
...
* refactor: make tr_peer_socket.type private
* refactor: reimplement tr_peerIo::address() as a wrapper around tr_peer_socket::address()
* refactor: remove tr_address, tr_port from tr_peerIo
* refactor: replace tr_netClosePeerSocket() with tr_peer_socket::close()
2022-12-05 18:53:31 -06:00
468310300c
refactor: only need a single handshake mediator ( #4322 )
2022-12-05 11:47:11 -06:00
e038121857
refactor: second log of UTP errors as 'trace' messages ( #4283 )
2022-11-30 14:06:08 -06:00
59335eac03
fix: sonarcloud cpp:S6004 ( #4270 )
...
reduce scope of variables by using if-based initializer
2022-11-28 21:03:28 -06:00
554ba06ae2
fix: coverity warnings, sonarcloud code smells ( #4232 )
2022-11-24 10:17:02 -06:00
42f26aad0b
fix: ftbfs on Windows ( #4204 )
2022-11-16 18:03:48 -06:00
250e055c1d
fix: warnings from clang tidy sonarcloud coverity ( #4143 )
2022-11-12 09:53:09 -06:00
162035a653
fix: minor recent clang warnings ( #4111 )
...
* refactor: fix modernize-use-default-member-init warning in session-thread.cc
* refactor: fix readability-named-parameter warning in session-thread.cc
* refactor: fix clang-diagnostic-unused-function warning for isSupportedSocket()
* refactor: fix clang-analyzer-deadcode.DeadStores warning in buildHandshakeMessage()
* chore: fix readability-identifier-naming warning for tr_session::session_mutex_
* chore: fix readability-identifier-naming warning for Watchdir::generic_rescan_interval_
* chore: fix readability-identifier-naming warning for __tr_current_time
2022-11-07 11:48:26 -06:00
d5ef1ea80a
fix: test for tr_peerIo.gotError function pointer before use ( #4051 )
2022-10-29 16:59:24 -05:00
450f1dcadc
refactor: extract `tr_buffer` class from `tr_peerIo` ( #3986 )
2022-10-19 11:42:08 -05:00
79068c512a
refactor: decouple tr-dht from peerMsgs, peerMgr ( #3966 )
...
* refactor: decouple peer-mgr from tr-dht
* refactor: remove tr_dhtPort()
* refactor: decouple peer-msgs from tr-dht
* refactor: make tr_udp_core.udp_port_ const
* refactor: rename tr_udp_core::dhtUninit() as startShutdown()
2022-10-15 08:22:43 -05:00
4ea9c87fea
fix: some typos ( #3904 )
2022-10-13 09:35:10 -05:00
f1f55cc3df
Sync translations ( #3939 )
...
* Sync translations with code
* Sync translations with Transifex
* Remove Mac menu title that isn't displayed and shouldn't be translated
* Add context to logging level strings in GTK client
* Use "µTP" consistently in code
* Use ellipsis instead of three docs in Qt client strings
* Close HTML tags in blocklist-related strings
* Remove trailing space from a translatable string in Qt client
* Add missing plural forms for English strings in Qt client
* Fix spelling: metaInfo -> metainfo
2022-10-11 18:39:41 +03:00
257d98545b
refactor: add tr_port_forwarding::Mediator ( #3855 )
...
* refactor: add a Mediator class to decouple tr_session and tr_port_forwarding
* refactor: add tr_port_forwarding::Mediator::privatePeerPort()
* refactor: add tr_port_forwarding::Mediator::onPortForwarded()
* chore: avoid unnecessary include of timer.h in other headers
* refactor: use a uniform timerMaker() API in mediators
2022-10-01 09:12:49 -05:00
dd12fd010a
chore: iwyu headers ( #3833 )
2022-09-21 18:34:18 -05:00
80d9d5a63b
refactor: add tr_peerIo::peek() ( #3798 )
2022-09-09 13:12:47 -05:00
1782dc6d7a
refactor: use readability-identifier-naming in clang-tidy ( #3784 )
2022-09-07 11:04:28 -05:00
d17341d784
refactor: constify ( #3780 )
2022-09-06 12:52:58 -05:00
8eab7d3ae7
chore: remove dead "fast set" code ( #3764 )
...
* chore: remove old fast set code
* chore: remove TR_SHA1_DIGEST_LEN declaration
* chore: remove TR_SHA256_DIGEST_LEN declaration
2022-09-05 08:55:17 -05:00
6ca0ce683a
refactor: more constexpr ( #3744 )
...
Make more simple functions constexpr where possible.
2022-08-31 17:33:51 -05:00
d130f7d593
refactor: prefer std::unique_ptr over std::shared_ptr ( #3741 )
2022-08-30 19:30:47 -05:00
b7ea4d9f04
refactor: tr_peerIo ref, unref ( #3735 )
...
* refactor: replace manual peerIo refcounting with std::shared_ptr
2022-08-30 12:38:30 -05:00
7c014e3256
Refactor/tr peer io member funcs ( #3734 )
...
* refactor: make tr_peerIoSetEnabled() a member method
* refactor: make tr_peerIoFlushOutgoingProtocolMsgs() a member method
* refactor: make tr_peerIoFlush() a member method
* refactor: make tr_peerWriteBytes() a member method
* refactor: make tr_peerWriteBuf() a member method
* refactor: make tr_peerIoGetWriteBufferSpace() a member method
* chore: remove unused declaration
* refactor: make tr_peerIoUtpInit() a member method
* refactor: make tr_peerIoNew() a member method
* refactor: make tr_peerIoNewOutgoing() a member method
* refactor: make tr_peerIoNewIncoming() a member method
2022-08-29 15:58:18 -05:00
0ed595ca0e
refactor: tr_peerIo read buffer ( #3732 )
...
* refactor: make tr_peerIoReadBytes() a member method
* refactor: make tr_peerIoReadUint8() a member method
* refactor: make tr_peerIoReadUint16() a member method
* refactor: make tr_peerIoReadUint32() a member method
* refactor: make tr_peerIoSetIOFuncs() a member method
* refactor: make tr_peerIoReconnect() a member method
* refactor: make tr_peerIoClear() a member method
* refactor: make tr_peerIoDrain() a member method
* refactor: move evbuffer_add_hton_16() impl to cc
2022-08-29 13:33:08 -05:00
fa8b6a5e0a
option to disable TCP ( #3447 )
2022-08-25 21:27:11 -05:00
e191407dee
refactor: modernize-avoid-c-arrays pt. 1 ( #3702 )
2022-08-24 20:19:21 -05:00
29f57bc296
chore: iwyu headers ( #3661 )
2022-08-17 11:08:36 -05:00
c7466b3ff4
fix: coverity warnings ( #3632 )
...
* fix: uninitialized field natpmp
* fix: unchecked downcast result
* fix: potential tr_error leak
* fix: potential tr_error leak
* fix: potential tr_error leak
* fix: potential nullptr dereference in test fixtures
* fix: handshake fields not initialized in constructor
* chore: cast unchecked return value to void
* chore: cast unchecked return value to void
* chore: cast unchecked return value to void
* chore: make single-arg constructors explicit
* fix: code smell make variable a pointer-to-const
* fix: code smell make variable a pointer-to-const
* chore: make single-arg constructors explicit
* chore: silence sonarcloud false warning on commented-out-code
* chore: fix code smell use std::array
* chore: make EvTimer::handleTimer() const
* chore: mark tr_bandwidth remove_child as noexcept
2022-08-13 12:11:07 -05:00
b49cccbd3e
refactor: add timer class ( #3603 )
...
Wraps around evtimer so that some of the codebase can use libevent without coupling to it.
2022-08-08 17:53:20 -05:00
3428076ecd
fix: cppcoreguidelines-special-member-functions warnings in libtransmission ( #3575 )
2022-08-03 12:03:28 -05:00
dab81c1af6
fix: readability-inconsistent-declaration-parameter-name warnings in libtransmission ( #3572 )
2022-08-03 01:15:37 -05:00
18e2a04f88
refactor: make sha1, sha256 RAII safe ( #3556 )
2022-07-31 15:58:14 -05:00
d8d03b8e3b
refactor: avoid unnecessary heap alloc when reading PadC ( #3534 )
2022-07-27 22:17:05 -05:00
ec79a2a888
fix: clang-tidy misc-const-correctness warnings ( #3529 )
2022-07-27 09:03:13 -05:00
41c0f8885e
fix: limit pad search during encrypted handshake ( #3471 )
2022-07-18 13:00:26 -05:00
fe91f04351
test: add plaintext & encrypted handshake tests ( #3455 )
2022-07-16 15:25:44 -05:00
2bcab6be7e
refactor: remove tr_dh code ( #3443 )
...
Refactor the MSE handshake Diffie-Hellman key code.
2022-07-14 19:54:10 -05:00
ba26e79afe
refactor: decouple tr_handshake ( #3435 )
...
Add a shim between the handshake code and the rest of the codebase to
improve decoupling so that a followup PR can add handshake unit tests.
The handshake code no longer directly relies on tr_torrent, tr_session,
tr_dht, or tr_peerMgr.
2022-07-11 18:29:48 -05:00
0a39cb9302
refactor: migrate tr_crypto C functions to members ( #3430 )
2022-07-10 21:57:05 -05:00
256b436023
fix: clang 15 warnings ( #3172 )
...
* fix modernize-macro-to-enum libtransmission warnings
* fix readability-simplify-boolean-expr libtransmission warnings
* fix bugprone-unchecked-optional-access libtransmission warnings
2022-06-01 11:56:59 -05:00
Charles Kerr