046ba32d33
fixup: heap-use-after-free in announce, scrape response on shutdown ( #4228 )
...
fixes #4222 .
2022-11-23 01:38:31 -06:00
a8f2b840f7
perf: improve tr_peerMgrGetDesiredAvailable() ( #4226 )
2022-11-22 23:26:10 -06:00
40c7f5bceb
perf: constexpr and move work outside of loops ( #4224 )
2022-11-22 14:00:09 -06:00
43c57fb02a
perf: buffer iterators ( #4220 )
2022-11-21 23:54:28 -06:00
191c6d1402
fix: SecKeychain is deprecated ( #4190 )
2022-11-21 23:14:10 -06:00
a3772dc1fa
refactor: aggregate dh in peer io ( #4218 )
2022-11-21 18:08:06 -06:00
d26db72d7e
Fix "Implicit conversion loses integer precision" ( #4194 )
2022-11-21 10:19:45 -06:00
76bea25f6e
perf: minor perf wins ( #4216 )
...
* perf: faster tr_buffer::toString()
* perf: faster tr_buffer::Iterator
* perf: get mutex lock in reconnectPulse() instead of closeBadPeers()
2022-11-21 09:28:46 -06:00
ffd5e6bf50
refactor: remove unused vars, code simplify and minor optimize ( #4172 )
2022-11-19 09:46:03 -06:00
292b092f54
Fix hang in CSBackupSetItemExcluded ( #4208 )
2022-11-19 08:50:13 -06:00
d27c4c59ce
refactor: incremental announcer refactor pt. 2 ( #4214 )
2022-11-18 23:00:25 -06:00
62cad53df8
build(deps): bump loader-utils from 2.0.3 to 2.0.4 in /web ( #4212 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v2.0.3...v2.0.4 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-18 22:32:38 -06:00
a187529f93
typo ICP -> TCP ( #4213 )
2022-11-18 21:53:16 -06:00
a152d0f6d8
Appropriate and improve VDKQueue ( #4202 )
2022-11-18 13:53:36 -06:00
6fcdb526c7
Fix crash on torrent filenames in non-UTF-8 encoding ( #4144 )
2022-11-18 10:03:25 -06:00
4cc0b77eec
refactor: incremental announcer improvements ( #4211 )
2022-11-17 20:23:54 -06:00
f17cee97e5
fix: nullptr crash in peer-io ( #4210 )
2022-11-17 14:53:08 -06:00
9035f2297a
Fix incorrect build hash when building with Xcode ( #4195 )
2022-11-17 09:17:16 -06:00
42f26aad0b
fix: ftbfs on Windows ( #4204 )
2022-11-16 18:03:48 -06:00
a45cc2a79d
refactor: try again to use getaddrinfo in announcer_udp ( #4201 )
2022-11-16 15:13:31 -06:00
7a2d2ff0cf
Fix cmake CFBundleVersion and LSMinimumSystemVersion ( #4185 )
...
* Fix cmake CFBundleVersion and LSMinimumSystemVersion
* code review: use CMAKE_OSX_DEPLOYMENT_TARGET
2022-11-16 13:40:19 +00:00
812588100d
Calculate percent done in range 0..100 instead of 0..1 (GTK client) ( #4191 )
2022-11-16 10:14:09 +00:00
ac6010557e
Fix issues reported by clang-tidy `bugprone` checks (GTK client) ( #4183 )
...
* Fix `bugprone-unchecked-optional-access` clang-tidy issues
* Fix `bugprone-easily-swappable-parameters` clang-tidy issues
* Extend clang-tidy configuration
2022-11-15 19:30:32 +00:00
d2125ee965
perf: revert e065565cd to restore async dns lookups ( #4182 )
2022-11-15 11:16:49 -06:00
befeafbcfe
hook action in the xib ( #4135 )
2022-11-15 10:50:16 -06:00
22c14c9266
fix: sonarcloud warnings ( #4180 )
2022-11-15 10:25:12 -06:00
d0639b5f0c
perf: tr_sys_path_basename() returns a std::string_view ( #4176 )
2022-11-15 08:29:00 -06:00
134363d83d
fixup! refactor: decouple session settings from the session class ( #4053 ) ( #4175 )
...
fixes #4134
2022-11-14 19:10:19 -06:00
2bd6c8aff4
Fix issues reported by clang-tidy `cert` checks (GTK client) ( #4174 )
...
* Fix `cert-err33-c` clang-tidy issues
* Fix `cert-str34-c` clang-tidy issues
* Fold free-standing functions into `FilterBar::Impl`
This is in preparation to next commit fixing `cert-err58-cpp`.
* Fix `cert-err58-cpp` clang-tidy issues
* Extend clang-tidy configuration
2022-11-15 00:53:12 +00:00
5cb9e8c146
test: increase timer interval in TimerTest.repeatingThenSingleShot ( #4173 )
...
These 25ms timers are not repeatable enough on the CI boxes
2022-11-14 18:04:15 -06:00
6bec2f22c8
fix: 4.0.0-beta.1 wrong RPC response for group-get ( #4171 )
2022-11-14 16:31:41 -06:00
8df26dd2fc
refactor: re-enable some clang tidy warnings in tests ( #4170 )
2022-11-14 14:16:29 -06:00
bde1359d5d
Adopt localizedStringWithFormat for displayed quantities ( #4109 )
...
* Adopt localizedStringWithFormat for displayed quantities
* xib internationalization support is done
2022-11-14 18:30:03 +00:00
1d9159fffc
Fix incorrect selection behavior when building against GTK 4 ( #4168 )
...
View-relative coordinates were treated as bin window-relative, leading to
incorrect selected item calculation.
Broken since the introduction of GTK 4 support in #3916 .
2022-11-14 18:27:15 +00:00
f8d981349e
Fix issues reported by clang-tidy `misc` checks (GTK client) ( #4167 )
...
* Fix `misc-const-correctness` clang-tidy issues
* Fix `misc-no-recursion` clang-tidy issues
* Extend clang-tidy configuration
2022-11-14 16:22:38 +00:00
caefebd102
remove duplicate Portuguese ( #4141 )
2022-11-14 15:53:57 +00:00
c9debcfd48
Sync translations ( #4161 )
...
* Sync translations with code
* Sync translations with Transifex
2022-11-14 09:48:42 +00:00
f9a6df6f41
refactor: use a condition_variable when removing a torrent from the verifier thread ( #4166 )
2022-11-13 23:11:48 -06:00
855b782604
Accessibility description for images ( #4149 )
2022-11-13 21:39:34 -06:00
67e992ddf0
refactor: better TR_CURL_SSL_NO_VERIFY ( #4159 )
...
clear CURLOPT_CAINFO, CURLOPT_CAPATH iff verification is disabled
2022-11-13 17:17:16 -06:00
fd9c454c45
Fix issues reported by clang-tidy `performance` checks (GTK client) ( #4160 )
...
* Fix `performance-move-const-arg` clang-tidy issues
* Fix `performance-no-automatic-move` clang-tidy issues
* Extend clang-tidy configuration
2022-11-13 20:50:07 +00:00
b322971f6a
Fix create torrent out-of-range piece size ( #4145 )
2022-11-13 13:53:25 -06:00
ff2e544a6b
Fix "Block implicitly retains 'self'" ( #4132 )
2022-11-13 13:10:58 -06:00
d8e7664f2b
Fix "terminating with uncaught exception of type std::out_of_range: vector" ( #4138 )
2022-11-13 12:00:04 -06:00
49ce12ce38
Fix issues reported by clang-tidy `cppcoreguidelines` checks (GTK client) ( #4158 )
...
* Fix `cppcoreguidelines-pro-type-cstyle-cast` clang-tidy issues
* Fix `cppcoreguidelines-pro-type-member-init` clang-tidy issues
* Fix `cppcoreguidelines-prefer-member-initializer` clang-tidy issues
* Introduce `PageBase` for `PrefsDialog` pages
This is in preparation for next PR fixing `Glib::Timer` memory
management.
* Fix `cppcoreguidelines-owning-memory` clang-tidy issues
* Fix `cppcoreguidelines-pro-bounds-array-to-pointer-decay` clang-tidy issues
* Fix `cppcoreguidelines-special-member-functions` clang-tidy issues
* Fix `cppcoreguidelines-init-variables` clang-tidy issues
* Fix `cppcoreguidelines-macro-usage` clang-tidy issues
* Fix `cppcoreguidelines-pro-bounds-constant-array-index` clang-tidy issues
* Fix `cppcoreguidelines-non-private-member-variables-in-classes` clang-tidy issues
* Fix `cppcoreguidelines-pro-type-vararg` clang-tidy issues
* Fix `cppcoreguidelines-pro-bounds-pointer-arithmetic` clang-tidy issue
* Fix `cppcoreguidelines-pro-type-reinterpret-cast` clang-tidy issues
* Fix `cppcoreguidelines-pro-type-static-cast-downcast` clang-tidy issues
* Extend clang-tidy configuration
Enable all `cppcoreguidelines` checks except for three (`avoid-magic-
numbers`, `avoid-non-const-global-variables`, `narrowing-conversions`)
which require [more] extensive refactoring and were left for later.
2022-11-13 17:36:16 +00:00
0ecf084e0f
ignoring deprecation warning on NSUnarchiver ( #4113 )
2022-11-13 10:54:22 -06:00
9e185a17f2
Fix default/minimum `CMAKE_OSX_DEPLOYMENT_TARGET` handling ( #4156 )
...
* Fix default/minimum `CMAKE_OSX_DEPLOYMENT_TARGET` handling
* Drop explicit `CMAKE_OSX_DEPLOYMENT_TARGET` in GHA CI
Rely on minimum set in top-level CMakeLists.txt instead.
2022-11-13 12:02:07 +00:00
095f094dd5
Only run AppVeyor builds on `main` and versioned branches/tags ( #4150 )
2022-11-12 20:27:15 +00:00
43acd7e3e4
Remove Xcode project in favor of CMake ( #4147 )
...
* Compile images into an assets catalog
* Optionally sign resulting Mac bundle
* Move 3rd-party/utility/test targets to their own folders
* Enable ARC via compile options unconditionally
* Install base and localized resources into correct directory
This seems like a Xcode quirk: if subdirectory containing the resource file
matches the destination directory name (and probably if there's more than one
resource file being installed there), the resulting folder structure then
contains an extra subdirectory, i.e. Resources/dirname/dirname/resname.
* Group source files for better structure in IDEs (Xcode, VS)
* Remove Xcode project
Using Xcode is still possible via "Xcode" CMake generator.
* Use ad-hoc signature if one is not specified
* Always use ad-hoc signature on link, leave proper signing to CPack
* Install localized resources into correct directory (QL plugin)
* Don't include CTest (we don't use additional targets it provides)
* Revert "Remove Xcode project"
This reverts commit dc069f654f
2022-11-12 20:01:57 +00:00
55be67b2e6
Add CodeQL workflow ( #4125 )
...
* Add CodeQL workflow
* Improve CodeQL setup
Install proper packages to enable GTK and Qt client builds.
Exclude 3rd-party dependencies from analysis (they should be analyzed
separately in their own repositories).
Speed C++ analysis up by building with Ninja.
Speed JavaScript analysis up by skipping CMake configuration and build,
which is not required for interpreted languages.
* Revert unintentional branch specification change
* Exclude generated JavaScript files from CodeQL analysis
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
2022-11-12 19:26:06 +00:00
Charles Kerr