988d8ff9ac
test: possibly fix rename-test flakes ( #3653 )
...
* test: possibly fix rename-test flakes
* ci: add gettext-dev to alpine workflow
* ci: make utils if tests change, since transmission-show is needed
* ci: add linux-headers to alpine workflow
2022-08-16 17:47:02 -05:00
6278ea7017
refactor: reduce use of tr_malloc / tr_free ( #3652 )
...
* refactor: avoid tr_new in macos Torrent.trashDataFile
* refactor: avoid tr_new in maco PiecesView
* refactor: avoid tr_new in qt createVariant()
2022-08-16 12:03:09 -05:00
293f4f6759
refactor: fix sonarcloud warnings ( #3649 )
...
* refactor: help sonarcloud to see that tr_bandwidth dtor does not throw
* refactor: use std::map instead of QMap in qt FileTreeModel
2022-08-16 09:30:05 -05:00
99c21efecc
refactor: avoid tr_malloc / tr_free in subprocess-win32 ( #3648 )
2022-08-16 00:07:06 -05:00
c625ec7e0f
refactor: make tr_session.rpc_server_private_ ( #3646 )
...
* refactor: make tr_session.rpc_server_ private
* chore: sort some fields to reduce number of padding holes
* chore: remove unused forward declarations
* refactor: aggregate tr_bitfield in tr_turtle
* chore: remove unused forward declarations
* chore: remove unused forward declarations
2022-08-15 16:25:55 -05:00
0fbfed60b1
refactor: make tr_session.speed_limit_Bps_ private ( #3645 )
...
* refactor: make tr_session.speed_limit_Bps_ private
* refactor: make tr_session.is_utp_enabled_ private
* refactor: make tr_session.is_prefetch_enabled_ private
* refactor: make tr_session.is_ratio_limited_ private
* refactor: make tr_session.upload_slots_per_torrent_ private
* refactor: make tr_session.peer_id_ttl_hours_ private
* refactor: make tr_session.blocklists_ private
* refactor: make tr_session.umask_ private
* refactor: make tr_session.evdns_base_ private
* fixup! refactor: make tr_session.blocklists_ private
* refactor: make tr_session.default_trackers_ private
* refactor: make tr_session.idle_limit_minutes_ private
* refactor: make tr_session.WebMediator private
* refactor: make tr_session.session_id_ private
* refactor: make tr_session.peer_socket_tos_ private
2022-08-15 12:48:05 -05:00
a4c1a23fae
refactor: make tr_session.is_incomplete_file_naming_enabled_ private ( #3642 )
...
* refactor: make tr_session.is_incomplete_file_naming_enabled_ private
* refactor: make session callback setters constexpr
* refactor: make tr_session.is_port_random_ private
* refactor: make tr_session.desired_ratio_ private
* refactor: make tr_session.is_pex_enabled_ private
* refactor: make tr_session.is_idle_limited_ private
2022-08-14 19:33:28 -05:00
44a291ca39
refactor: remove tr_session nonmember functions ( #3641 )
2022-08-14 14:41:57 -05:00
6beca85ae2
refactor: make tr_session.rpc_func_ private ( #3640 )
2022-08-14 10:40:03 -05:00
08ec882055
refactor: remove tr_isSession() ( #3638 )
2022-08-14 09:16:08 -05:00
5c8695025a
refactor: make tr_session.is_closing_private_ ( #3637 )
2022-08-13 20:04:36 -05:00
f6bf652043
refactor: make tr_session.peer_count private ( #3635 )
2022-08-13 17:41:42 -05:00
ed6ee619a6
refactor: make tr_session.queue fields private ( #3634 )
2022-08-13 14:56:10 -05:00
403e81e163
refactor: make tr_session.web_mediator_ private ( #3633 )
2022-08-13 13:36:34 -05:00
c7466b3ff4
fix: coverity warnings ( #3632 )
...
* fix: uninitialized field natpmp
* fix: unchecked downcast result
* fix: potential tr_error leak
* fix: potential tr_error leak
* fix: potential tr_error leak
* fix: potential nullptr dereference in test fixtures
* fix: handshake fields not initialized in constructor
* chore: cast unchecked return value to void
* chore: cast unchecked return value to void
* chore: cast unchecked return value to void
* chore: make single-arg constructors explicit
* fix: code smell make variable a pointer-to-const
* fix: code smell make variable a pointer-to-const
* chore: make single-arg constructors explicit
* chore: silence sonarcloud false warning on commented-out-code
* chore: fix code smell use std::array
* chore: make EvTimer::handleTimer() const
* chore: mark tr_bandwidth remove_child as noexcept
2022-08-13 12:11:07 -05:00
1c8032d23a
fix: tr_session field order ( #3630 )
2022-08-12 12:22:23 -05:00
3020e45f4b
docs: update Web-Interface.md ( #3622 )
2022-08-12 07:54:07 -05:00
fcbcc6123b
Add link to building manual in project README.md ( #3629 )
2022-08-12 07:53:35 -05:00
7c5862a5f5
refactor: remove tr_new, tr_free pt. 1 ( #3626 )
...
* refactor: tr_torrentGetMetadataPiece() returns an optional vector
* refactor: use tr_pathbuf in create_temp_path()
* refactor: use tr_pathbuf in win32 create_temp_path()
* refactor: use std::vector in isPeerInteresting()
* refactor: remove tr_new0 from tr_peerMgrPeerStats()
* refactor: remove tr_new0 from rechokeUploads()
* refactor: silence clang nullptr dereference warning
* refactor: make tr_natpmp a C++ class
* refactor: use std::string in tr_log_message
2022-08-11 19:59:58 -05:00
e781ee1773
refactor: timer pt 3 ( #3624 )
2022-08-11 14:30:00 -05:00
63eab54fd5
refactor: timer pt 2 ( #3617 )
...
* feat: add convenience variants of TimerMaker::create()
* refactor: use libtransmission::Timer in peer-mgr
* refactor: use libtransmission::Timer in peer-msgs
* refactor: use libtransmission::Timer in tr-utp
* refactor: use libtransmission::Timer in tr-dht
* refactor: use libtransmission::Timer in port-forwarding
* refactor: use libtransmission::Timer in webseed
* refactor: use libtransmission::Timer in tr-lpd
* refactor: use libtransmission::Timer in rpc-server
* chore: remove unused function tr_timerAdd()
* chore: remove unused function tr_gettimeofday()
* fixup! chore: remove unused function tr_timerAdd()
* fixup! refactor: use libtransmission::Timer in port-forwarding
2022-08-11 12:28:37 -05:00
7c152c1db4
docs: update Web-Interface.md ( #3615 )
2022-08-10 20:46:57 -05:00
a700259cc0
macOS convert message window to autolayout ( #3604 )
...
fixes some clipping in the macOS Message Log window
#3574
2022-08-10 09:47:13 -05:00
c66303fae2
refactor: watchdir ( #3606 )
2022-08-10 08:34:51 -05:00
b1cc968969
Fix out-of-bounds read in torrent parsing ( #3600 )
...
Fixes #3591
2022-08-09 17:04:56 -05:00
a5f7df34ab
docs: update Web-Interface.md ( #3601 )
2022-08-09 15:21:02 -05:00
0da5660c6e
Increase font size of TrackerCell from 9 to 9.5 ( #3571 )
2022-08-09 08:15:52 -05:00
b49cccbd3e
refactor: add timer class ( #3603 )
...
Wraps around evtimer so that some of the codebase can use libevent without coupling to it.
2022-08-08 17:53:20 -05:00
83ffa6bf1b
chore: fix spdx abbreviations ( #3602 )
2022-08-08 13:05:39 -05:00
31a733fab7
refactor: make tr_session_id a class ( #3598 )
2022-08-06 14:27:37 -05:00
1f5c650f56
docs: update Web-Interface.md ( #3597 )
2022-08-06 12:11:58 -05:00
90f08f4fa1
refactor: fix recent sonarcloud warnings ( #3593 )
2022-08-05 20:37:21 -05:00
868fc1ab78
Refactor/tr variant from buf ( #3592 )
...
* refactor: use std::string in tr_watchdir_inotify_on_event()
* refactor: add template tr_variantFromBuf() variant
if it has .data() and .size() it is good
2022-08-05 16:12:45 -05:00
4bc1589c5d
refactor: remove tr_win32_utf8_to_native_ex() ( #3590 )
2022-08-05 14:16:25 -05:00
8b983b3d1c
refactor: tr_sys_path_resolve() returns a std::string ( #3587 )
...
* refactor: tr_sys_path_resolve returns std::string
2022-08-05 11:36:01 -05:00
3ed6b187bb
refactor: iwyu utils.h ( #3583 )
2022-08-04 08:44:18 -05:00
4f6909a27a
refactor: tr_sys_dir_get_current() returns a std::string ( #3581 )
2022-08-03 23:59:41 -05:00
8a77f571ec
Save images from docs in repo ( #3564 )
2022-08-03 18:30:27 -05:00
ef34c7c4dc
refactor: use std::wstring on win32 ( #3578 )
2022-08-03 18:07:38 -05:00
3428076ecd
fix: cppcoreguidelines-special-member-functions warnings in libtransmission ( #3575 )
2022-08-03 12:03:28 -05:00
9afbf58c4e
Fix peer port change in session rpc ( #3573 )
...
Currently transmission keeps listening to the old port when you change
it so incoming peers can't connect.
2022-08-03 10:07:45 -05:00
dab81c1af6
fix: readability-inconsistent-declaration-parameter-name warnings in libtransmission ( #3572 )
2022-08-03 01:15:37 -05:00
8e604b44a5
Fix broken tr_sessionSetPeerPortRandom() function. ( #3569 )
2022-08-02 22:38:37 -05:00
df7a44adb2
refactor: in sendPex(), reuse the temporary buffer ( #3568 )
2022-08-02 18:35:16 -05:00
f39826cc59
fix: clang-tidy-15 warnings ( #3570 )
...
* fix: bugprone-assignment-in-if-condition warning in tr_bitfield::countFlags()
* fix: bugprone-assignment-in-if-condition warning in tr_watchdir_generic_new()
* fix: bugprone-assignment-in-if-condition warning in torrentRenamePath()
* fix: bugprone-assignment-in-if-condition warning in tr_watchdir_inotify_on_event()
* fix: bugprone-assignment-in-if-condition warning in tr_variantWalk()
* fix: misc-const-correctness warning in TrackerDelegate::getText()
* fix: bugprone-assignment-in-if-condition warning in Session::updateStats()
* fix: performance-unnecessary-value-param warning in discoverThreadfunc()
* fix: clang-analyzer-core.UndefinedBinaryOperatorResult warning in tr_completion::setHasAll()
* fix: clang-analyzer-core.UndefinedBinaryOperatorResult warning in tr_torrentFileCompleted()
* fix: silence clang-analyzer-cplusplus.NewDelete warning when using QPointer
This appears to be a false positive; added NOLINT
2022-08-02 18:34:53 -05:00
bf8f72e61f
refactor: tr_metainfo_builder() ( #3565 )
2022-08-02 14:46:08 -05:00
5eb7f75010
refactor: tr_sys_path_get_info() now returns a tr_sys_path_info ( #3566 )
...
* refactor: tr_sys_path_get_info() now returns a tr_sys_path_info
* refactor: tr_sys_file_get_info() now returns a tr_sys_path_info
2022-08-02 12:41:04 -05:00
3982532d65
macOS disable green maximize button on Inspector window ( #3563 )
...
Fixes #3486
2022-08-02 08:19:03 -05:00
2ff4dd139f
macOS autolayout fixes on Inspector - Options tab ( #3559 )
...
* macOS autolayout fixes on Inspector - Options tab
Fixes #3558
* macOS - equal height NSPopupButtons on Inspector - Options tab
2022-08-02 01:37:49 -05:00
a71de1e0cc
Update Web-Interface.md ( #3557 )
2022-08-01 12:42:41 -05:00
Charles Kerr