SweetPPro
aabb8c809e
macOS remove FullScreen support ( #3220 )
...
removed fullscreen support, as it opens a can of worms trying to fully support it....
https://github.com/transmission/transmission/issues/3215#issuecomment-1147477253
2022-06-08 14:15:51 -05:00
Charles Kerr
12592e20d6
build: remove unused function checks ( #3233 )
...
* build: remove unused -DHAVE_ASPRINTF from xcode build
* build: remove unused -DHAVE_ZLIB from cmake and xcode
we use libdeflate instead
* build: remove unused -DHAVE_LIBGEN from xcode
2022-06-08 13:35:07 -05:00
Balázs Meskó
0df6c23c7b
fix: mark non-c-strings for gettext i18n ( #3210 )
2022-06-08 01:04:17 -05:00
A Cœur
7b6b87b0e6
fix: macOS build warning "cannot find protocol definition for 'PortCheckerDelegate'" ( #3222 )
2022-06-07 14:27:40 -05:00
orbital-mango
49b62319c3
feature: add missing accelerators for File menu (GTK) ( #3213 )
2022-06-07 12:17:35 -05:00
SweetPPro
5a140d205d
feat: use system lock icon if available ( #3221 )
2022-06-06 17:56:05 -05:00
Charles Kerr
6c9c446734
docs: fix documented type of rpc-version-semver ( #3209 )
2022-06-05 21:17:05 -05:00
SweetPPro
8d61f07930
fix: missing source file in CMake macOS build ( #3208 )
...
* Update CMakeLists.txt
correctly add new files to xcode project
2022-06-05 13:33:18 -05:00
Ilkka
4d888ee8fb
Move function declaration ( #3207 )
2022-06-05 12:08:58 -05:00
SweetPPro
9cbb4d3384
fix a number of UI render issues in the macOS torrent creator window ( #3205 )
...
* fixes a number of UI issues in the macOS torrent creator window listed in: https://github.com/transmission/transmission/issues/1891
* also fixes positioning of the source field, the piece info textfield, and the piece info stepper
* also updates the tracker add/remove control to use the newer rounded trect style as in the rest of the UI
2022-06-05 11:14:33 -05:00
SweetPPro
70a54b3603
add gearshape temeplate to macOS CMakeLists.txt ( #3202 )
...
add missing macOS icon asset to CMakeLists.txt
https://github.com/transmission/transmission/issues/3199
2022-06-05 09:54:45 -05:00
SweetPPro
163f6c2544
more FullScreen fixes, and some toolbar animation fixes ( #3195 )
...
* Update Controller.mm
fix fullscreen behaviour as described here https://github.com/transmission/transmission/issues/1906
* more FullScreen fixes, and some toolbar animation fixes
https://github.com/transmission/transmission/issues/1906 , https://github.com/transmission/transmission/issues/1903
2022-06-05 08:49:31 -05:00
Robin Seth Ekman
9eeb3db89c
daemon: deprecated --log-error -> --log-level=error ( #3201 )
2022-06-05 01:13:11 -05:00
Charles Kerr
8806f9af68
fix: duplicate template instantiation on raspberry pi armv7 ( #3200 )
2022-06-05 00:01:23 -05:00
A Cœur
84195254ec
Fix: "Cannot begin activity without reason string or empty reason string" ( #3197 )
2022-06-04 18:42:32 -05:00
SweetPPro
d31254df50
Update Controller.mm ( #3191 )
...
fix fullscreen behaviour as described here https://github.com/transmission/transmission/issues/1906
2022-06-04 14:30:03 -05:00
Charles Kerr
2ff4041074
fixup! fix: coverity warnings ( #3168 ) ( #3193 )
2022-06-04 11:33:03 -05:00
Charles Kerr
7f1e12f220
refactor: do not prune peer atoms ( #3192 )
...
* refactor; do not prune peer atoms
* feat: improve connectivity check for peer candidates
2022-06-04 10:29:24 -05:00
A Cœur
4906349e3a
Make Sparkle optional to allow running Transmission without Apple Developer Program ( #3050 )
...
* Make Sparkle optional to allow building without Apple Developer Program
* Display a nice alert for developers clicking "checkForUpdates" when app isn't signed for Sparkle
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-06-03 12:47:33 -05:00
Charles Kerr
c5a73b0a79
refactor: remove peer_atom.shelfDate() ( #3187 )
2022-06-03 10:09:16 -05:00
Mike Gelfand
79d90167fd
Sync translations ( #3184 )
...
* Sync translations with code
* Sync translations with Transifex
2022-06-03 10:06:59 +01:00
SweetPPro
df657e9a04
Updated macOS segmented control alignment and popup button style ( #3156 )
...
* updated macOS group popup button alignment
popup button alignment enhancements described in the following issue: https://github.com/transmission/transmission/issues/3143
* updated macOS segmented controls in Preferences window
as described in the following issue: https://github.com/transmission/transmission/issues/3143
2022-06-02 19:05:15 -05:00
Charles Kerr
c2cd09d8d7
fix: do not crash when pruning idle peer atoms ( #3182 )
2022-06-02 10:00:12 -05:00
Charles Kerr
654bc409d7
refactor: remove peer_atom.peer field ( #3177 )
2022-06-01 22:36:00 -05:00
Charles Kerr
75a7c5f080
refactor: add tr_peerMsgs.networkSocket() ( #3175 )
2022-06-01 21:33:33 -05:00
FX Coudert
f5e6c5b782
fix: minor xcode warnings in macOS client ( #3174 )
2022-06-01 19:51:09 -05:00
Charles Kerr
9170c0f5fc
fix/unexpected-filehash-warning ( #3173 )
2022-06-01 16:14:09 -05:00
Charles Kerr
256b436023
fix: clang 15 warnings ( #3172 )
...
* fix modernize-macro-to-enum libtransmission warnings
* fix readability-simplify-boolean-expr libtransmission warnings
* fix bugprone-unchecked-optional-access libtransmission warnings
2022-06-01 11:56:59 -05:00
SweetPPro
26ed2a0ec8
fix removal of torrent files with a folder structure ( #3151 )
...
* fix removal of torrent files with a folder structure
fix for https://github.com/transmission/transmission/issues/3085 and possibly https://github.com/transmission/transmission/issues/2379
2022-06-01 10:25:06 -05:00
orbital-mango
12bf2896b6
feature: add piece size selection on torrent creation (GTK) ( #3145 )
2022-06-01 09:11:30 -05:00
Matan Ziv-Av
429961a335
Filtering torrents in transmission-remote ( #3125 )
...
* Filtering torrents in transmission-remote
- Add `-F <filter>` option to filter selected torrent
- May filter on uploading/downloading, label, torrent name,
and upload ratio, for now
- Filters may be negated
- Filters may be chained (logical and)
- Add `-ids` option to print ids of filtered torrents.
* Add "partially wanted" filter to transmission-remote
2022-05-31 21:57:44 -05:00
Charles Kerr
84d65d8e61
fix: coverity warnings ( #3168 )
...
* fix: uninitialized peer_atom field
* fix: silence inaccurate open-files-test warning
* fix: assertion-is-always-true
asserting unsigned val is >= 0
* fix: unnecessary nullptr check
* fix: nullptr dereference warning
2022-05-31 18:58:20 -05:00
Charles Kerr
1c3d60fcd5
refactor: simplify announceToScrape() ( #3167 )
2022-05-31 12:12:25 -05:00
Charles Kerr
d9f70f51dc
perf: avoid std::string temporaries in sessionLoadTorrent() ( #3165 )
2022-05-31 10:53:46 -05:00
Charles Kerr
d1030b58b1
perf: use std::string_view for compile-time UserAgent ( #3161 )
2022-05-31 09:28:01 -05:00
Charles Kerr
0097921f42
perf: avoid some unnecessary psl domain strdups ( #3160 )
...
We were incorrectly duplicating most domains because the "do we need
to convert before feeding to psl" test incorrectly returned true for
many domains.
2022-05-30 21:55:05 -05:00
Charles Kerr
1fc0e5d0d8
refactor: simplify atom pruning ( #3159 )
...
Possible fix for #3153
2022-05-30 14:36:03 -05:00
Charles Kerr
d1028510c1
refactor: use std::vector instead of tr_ptrArray in peer-mgr ( #3149 )
...
* refactor: make peer_atom.pool a std::vector
* refactor: remove unused tr_ptrArray methods
* refactor: remove unused #include ptrarray.h
* refactor: remove unused tr_ptrArrayRemove()
* refactor: remove unused peer-mgr.cc code
2022-05-27 16:27:47 -05:00
Charles Kerr
992775cfdc
refactor: struct peer_atom ( #3147 )
...
* refactor: make peer_atom.blocklisted private
* refactor: make tr_atomAddrStr a member function
* refactor: make atomIsSeed a member function
* refactor: make tr_isAtom a member function
* refactor: make peer_atom constructor
* refactor: make getReconnectIntervalSecs a member function
* refactor: make peer_atom.fromFirst const
2022-05-27 12:19:24 -05:00
SweetPPro
182e51492a
fix macOS statusBar icons ( #3113 )
...
* fix macOS statusBar icons
* improved CleanupTemplagte images
2022-05-27 06:59:37 -05:00
Charles Kerr
cec2195c78
refactor: tr_peerMgrGetPeers() returns a vector ( #3142 )
...
* refactor: tr_peerMgrGetPeers() returns a vector
* chore: iwyu <iterator> for std::back_inserter
* chore: iwyu <vector> for std::vector
2022-05-26 20:29:10 -05:00
A Cœur
b033b6598e
Fix group icon border ( #3094 )
2022-05-26 16:04:20 -05:00
Charles Kerr
51760bd5c1
refactor: make tr_peerIoGetAddress() a member function ( #3141 )
...
* refactor: make tr_peerIoGetAddress() a member function
* refactor: make tr_peerIo.addr a private field
* refactor: make tr_peerIoIsIncoming a member function
* refactor: make tr_peerIoHasBandwidthLeft a member function
* refactor: make tr_peerIoGetPieceSpeed_Bps a member function
* refactor: make tr_peerIoSupportsFEXT() a member function
* refactor: mark tr_peerIo::supportsDHT nodiscard
* refactor: update naming style for tr_peerIo fields
* refactor: make tr_peerIo.is_seed a private field
2022-05-26 12:17:03 -05:00
Charles Kerr
4f0f3f1c49
refactor: prefer std::vector over raw array in torrentGet() ( #3140 )
2022-05-26 09:36:00 -05:00
Charles Kerr
50cb57784e
build: use GitHub actions to check code-style ( #3138 )
2022-05-26 07:38:20 -05:00
Charles Kerr
46eb379205
fix: ESPIPE "illegal seek" error while seeding ( #3137 )
...
* fix: ESPIPE "illegal seek" error while seeding
The root cause is createSocket returning `{}` instead of `TR_BAD_SOCKET`
when we have too many peers in use. This defaulted to fd 0, which wound
up closing stdin.
Commit also includes some const-correctness changes made while tracking
the problem down.
2022-05-25 18:16:15 -05:00
orbital-mango
b4624cc775
fix: GTK file list size and progress % regression ( #3127 )
2022-05-25 13:27:33 -05:00
Gary Elshaw
0ce8777d1f
MacOS Transmission icons for Web ( #3130 )
2022-05-25 10:46:13 -05:00
Gary Elshaw
d6a5f1462c
MacOS Transmission icons for QT ( #3128 )
2022-05-24 21:18:08 -05:00
Gary Elshaw
de4148a697
chore: update GTK client icon to match Big Sur icon
2022-05-24 19:04:56 -05:00
