017fa1cf1e
fixup! chore: add precommit hook for testing code style ( #1448 )
2020-09-14 13:02:03 -05:00
be219ddee0
chore: add precommit hook for testing code style ( #1448 )
...
* chore: add precommit hook for testing code style
* chore: use prettier + eslint for js code
2020-09-13 21:41:32 -05:00
efaa66a920
fix: resolve some lgtm warnings ( #1444 )
...
* fix: warnings found by LGTM static analyzer
2020-09-11 16:07:45 -05:00
8739cb9c88
fixup! (trunk) update credits ( #1205 )
2020-05-02 11:42:18 -05:00
c951848a5b
Merge branch '2.9x'
2018-05-01 22:44:51 +03:00
913d9d3f37
HTML-escape torrent name displayed in trackers inspector tab
...
This will prevent injection of arbitrary HTML when multiple torrents are
selected. Follow-up to the previous commit.
2018-04-17 13:25:49 +03:00
523d8c1317
Tracker error XSS in inspector (web client)
...
Tracker error messages are inadequately output encoded when rendered by the
tracker information page inside the WebUI, allowing a malicious tracker to
inject an XSS payload into the page. Esploiting this issue allows an
attacker to supply arbitrary client-side code that will ultimately be
rendered and executed within the end user's web browser.
Found by Rory McNamara (Gotham Digital Science). CVE pending.
2018-04-17 13:25:49 +03:00
b4068e39f0
Merge branch 'master' into master
2017-02-12 18:44:06 +03:00
076535e3d3
Update inspector.js
...
https info not showed
2017-02-12 18:41:50 +03:00
a3654c65a5
Replace setInterval() with setTimeout() for web UI refresh (patch by WGH)
...
Fixes: TRAC-6031
2017-01-15 11:17:31 +03:00
5569efc3d4
#6089 : Beautified JavaScript (patch by skybon)
2016-03-10 19:05:13 +00:00
7177d43ba1
#5944 : Unify indentation style and strip trailing whitespaces across JS code, no functional changes (patch by xzcvczx + a lot more)
2015-05-05 19:12:48 +00:00
06d73853b9
Even better (and unified) torrent origin logic for GTK+, Qt and web clients
2015-04-22 21:04:49 +00:00
ea368388ed
Fix JS error on undefined creator during inspector update
...
Since torrents' info is fetched asynchronously, it may not yet be
available when inspector updates. Account for possibly undefined
creator.
Refine logic used to construct torrent origin phrase to prevent
results such as "Created by on <date>" or "Created by <creator>
on ".
2015-04-22 20:36:28 +00:00
d11f016ae8
(trunk, libT) #5699 'Toggle Inspector's Origin: is incorrect' -- fixed, patch by enzotrew
2014-07-03 19:31:59 +00:00
157bbe73f6
(trunk, web) #5620 'Inspector - Clickable urls in Comment field' -- added with patch by e-moe, thanks also to cfpp2p for testing
2014-04-15 21:30:38 +00:00
32fc85641a
Make accidentally-public function names private
...
inspector.js' functions, beginning with addSubtreeToView(), are leaked
into the DOM due to a missing comma at the end of the previous func.
Bug #5289 <https://trac.transmissionbt.com/ticket/5289 >
2013-02-10 18:32:40 +00:00
dbaf0bcbeb
(trunk, web) #5119 'Error when displaying tracker list' -- fixed.
2012-11-11 15:13:47 +00:00
79c7bab472
#5118 (web client) Tracker tier count should start at 1
2012-11-02 21:42:10 +00:00
d6635829d5
remove dead code Inspector.accumulateString
2012-10-19 15:31:42 +00:00
4dd6e35bd7
(trunk, web) replace Transmission.formatter.plural() with a slightly less brittle pluralization tool
2012-10-07 18:10:26 +00:00
ed2d2de530
(trunk, web) fix #5055 'torrents that include HTML in the comment section don't display properly in the web browser.'
2012-10-05 02:23:17 +00:00
6438568d66
(trunk web) #5013 fix r13523 tyop
2012-09-23 22:33:55 +00:00
53ef843cbd
(trunk web) #5013 "WebUI Inspector file tree" -- possible reimplementation.
2012-09-23 22:05:21 +00:00
7b7da2d315
in file-row getPath(), don't leak 'path' into the global namespace
2012-09-23 17:21:19 +00:00
b4b7483f2e
in updateFilesPage(), fix about a dozen variables that leaked into the global namespace
2012-09-23 17:08:27 +00:00
fe42c6285d
(trunk, web) r13437 regex bugfix by cfpp2p
2012-09-19 05:28:13 +00:00
a06a48dad3
(trunk web) #5013 "WebUI Inspector file tree" -- use patch submitted by PsychoMario
2012-08-18 15:04:06 +00:00
4a344d0656
(trunk web) #4979 "CSS Issues in Web Client" -- proposed fix. See ticket for more details.
2012-07-20 17:37:50 +00:00
306bd497b8
(web) #4841 & #4842 Fix inspector statistics when multiple torrents are selected. Fix the ratio displayed when the download count for a single transfer is 0 but there is data on disk.
2012-03-20 00:41:57 +00:00
9a27751d77
(trunk web) #4731 "'Select All' and 'Deselect All' options missing from Inspector>Files" -- fixed.
2012-02-03 22:59:33 +00:00
327dfa64d9
remove unused variables
2011-11-06 16:06:48 +00:00
69d782c2de
(trunk web) sync the web client's inspector's info tab with the one in the GTK+ and Qt clients. This fixes #4609 and #4608 .
2011-11-04 21:05:24 +00:00
a2145b188b
(trunk web) changes to clutch's file priority UI:
...
1. use form checkboxes for the 'file wanted' toggle
2. remove unused file_wanted_buttons.png
3. narrow the priority buttons a little
4. narrow the priority buttons' gradient range by about 2/3 so that the colors don't look harsh when there is row after row of priority buttons
2011-10-26 15:50:31 +00:00
568a6bd119
(trunk web) convert the inspector tab & bottom bar's buttons to use the same css as the inspector's file priority buttons. This is a work in progress & is being checked in for apple testing
2011-10-23 17:10:44 +00:00
e3a6c7402d
(trunk web) #4579 "lock_icon.png does not display in inspector tab for encrypted peers" -- fixed.
2011-10-20 00:10:06 +00:00
1f6d927bac
(trunk web) #4568 "Web Client blank content area in Opera Internet Browser" -- fix HTML5 validation errors reported by validator.w3.org. This fixed the blank content area problem seen with Opera.
2011-10-15 01:33:16 +00:00
71c06d2953
#4521 '(web) Make urls in comments clickable' -- done.
2011-09-27 16:44:35 +00:00
b396ed9f6b
when no torrents are selected, have the inspector's piece info show 'N/A'
2011-09-15 04:40:38 +00:00
97c80f76db
on startup, init the inspector's fields to 'N/A' where appropriate
2011-09-15 03:13:50 +00:00
6b8a224059
(trunk web) refactor the preferences dialog into its own class. Make the prefs dialog invokable on iPhones/Androids ( #1131 ) and add stop ratio functionality ( #2006 ).
2011-09-14 05:10:51 +00:00
442d9fbea9
(trunk web) use "===" instead of "==" when appropriate.
2011-09-05 07:46:55 +00:00
2928e9e6ee
(trunk web) remove unused variable 'tr' in updateFilesPage()
2011-09-03 22:45:41 +00:00
bd1e5b8e12
avoid unnecessary callback closures in the inspector.
2011-09-03 19:15:03 +00:00
9951f8af9f
plug a handful of context leaks.
2011-09-03 05:12:14 +00:00
f836308b42
(trunk web) better encapsulation of FileRow -- make most of its fields and methods private. transmission.js and remote.js don't know about FileRow anymore.
2011-09-03 04:33:04 +00:00
3b4fccadf1
(trunk web) refactor the inspector into its own class; make most of the methods private.
2011-09-02 19:29:41 +00:00
Charles Kerr