5f25e3be7f
anti-brute force for RPC Server
2017-08-12 16:36:43 +02:00
6410a460ea
Merge pull request #360 from clyang/master
...
Improving ToS on IPv6 connections
2017-08-08 18:32:44 +03:00
e1c8ec41f8
Add Peer ID for Folx
...
Based on experiments with Folx version 5.2.1.13690 running on macOS
Sierra.
Folx uses Azureus-style Peer ID with "-FL" prefix.
2017-08-05 12:29:16 +05:30
81c9653383
Improve ToS on IPv6 connections
2017-08-03 06:30:54 +03:00
8c87a58cdd
Add Peer ID for Free Download Manager (FDM)
...
Based on experiments with FDM 5.1.32 running on Windows 10.
FDM uses Azureus-style Peer ID with "-FD" prefix.
2017-08-02 20:33:41 +05:30
bb4741002f
Go back to using hash as base name for resume and torrent files
...
The format introduced in TRAC-394 is nice but brings its own issues (e.g.
TRAC-4189, #122 ). I'm okay with a bit of grepping myself if it makes the
experience better for end users.
Using hashes results in filenames well under 255 bytes limit on some
filesystems. If even that will not be enough, I'd suggest reporting the
issue elsewhere.
Fixes : #122
2017-07-26 21:32:26 +03:00
55b41c9015
Patch up file test to allow for a bit of time discrepancy
...
Since one cannot really compare system time to filesystem time (see e.g.
https://lkml.org/lkml/2017/3/30/809 ), allow for 1 second error to avoid
(or at least minimize) random test failures.
2017-07-21 00:45:30 +03:00
44411d719c
Change TR_CURL_SSL_VERIFY to TR_CURL_SSL_NO_VERIFY
...
use secure by default and change the env var to match curl -k behaviour
Closes : #179
2017-07-16 20:48:44 +03:00
580c5e4166
Rename `tr_sys_file_prefetch` to `tr_sys_file_advise`
...
New function now supports two flags: will need and don't need.
2017-07-08 16:09:37 +03:00
28c872af1e
Change `tr_sys_file_prefetch` behavior a bit
...
Return true by default. Only return false if we did in fact perform some
action and it failed.
2017-07-08 12:51:36 +03:00
8c88e8bba0
Change torrent location even if no data move is needed
...
This helps when old and new location point to the same place but the actual
path differs (i.e. one of the paths is a symlink).
Fixes : #35
2017-07-06 21:46:32 +03:00
a86266d3c2
Don't switch trackers while announcing
...
Fixes : #297
2017-07-04 21:22:26 +03:00
d46fdda9ea
Correct "annouce" spelling
...
Fixes : #303
2017-07-02 19:18:02 +03:00
27b6884408
Move uTP timer to session struct
2017-07-02 13:31:33 +03:00
87c9596305
Fix a couple more implicit boolean expressions
2017-07-02 13:26:26 +03:00
18aabdeb06
Introduce peer socket struct to improve readability
2017-06-28 18:50:05 +03:00
74548e01b6
Remove obsolete comment as we're using C99 now
2017-06-28 18:50:05 +03:00
13bbaeec76
Use field initializers for readability
2017-06-24 13:30:33 +03:00
b7b1d2475e
Fixed platform-quota.c for DragonFly. The patch is taken from dports.
2017-06-19 19:27:05 +03:00
f701d501a8
Move generic macros to a separate tr-macros.h file
2017-06-18 17:11:20 +03:00
deea6fc6a2
Bring assertions closer to the beginning of blocks
2017-06-13 07:44:09 +03:00
98695fe3c1
Introduce our own assertion macros with finer control
2017-06-08 10:24:12 +03:00
5f7bc801c8
Make use of new checking capabilities in unit tests
2017-05-30 20:56:12 +03:00
3d0b06ca0f
Add generic `check_mem` (libtest)
2017-05-30 20:09:19 +03:00
2a7cf67913
Add generic `check_bool`, extend `check` to be more informative (libtest)
2017-05-30 19:21:14 +03:00
b1b5a577cf
Transform `check_ptr_eq` into generic `check_ptr` (libtest)
2017-05-30 17:51:50 +03:00
437904198e
Transform `check_uint_eq` into generic `check_uint` (libtest)
2017-05-30 17:51:50 +03:00
9c3c6f11e0
Transform `check_int_eq` into generic `check_int` (libtest)
2017-05-30 17:51:50 +03:00
14c30119d4
Transform `check_str_eq` into generic `check_str` (libtest)
2017-05-30 17:51:46 +03:00
341b778099
Continue running other test-cases even if one fails (libtest)
2017-05-30 17:44:51 +03:00
c071f824ec
Pass `(u)intmax_t` instead of `(u)int64_t` to `check_(u)int_eq` (libtest)
2017-05-30 17:44:47 +03:00
7a238e7c65
Rename `check_streq` to `check_str_eq` to be in line with other macros (libtest)
2017-05-30 17:44:42 +03:00
432d573f2c
Fixup 2321bc3fad (unintended logic change, spotted by cfpp2p in #297 )
2017-05-29 08:50:40 +03:00
f27596238d
Include stdbool.h unconditionally
...
All the compilers should provide the header file by now. Remove `tr_isBool`
sanity checks along the way as compiler should guarantee that bool (_Bool)
values are 0 or 1 and nothing else.
2017-05-24 22:53:06 +03:00
295d3359b2
Little bastards keep popping up here and there :(
2017-05-23 22:17:17 +03:00
501be27972
Reduce code duplication in logging macros
2017-05-22 23:20:28 +03:00
dda33afbe0
Add Peer ID for PicoTorrent
...
Based on information from https://github.com/picotorrent/picotorrent and
http://www.picotorrent.org/ .
PicoTorrent uses Azureus-style peer ID: -PI-. Example: -PI0091- (major:
0, minor: 09, patch: 1).
2017-05-21 12:30:47 +05:30
82722476aa
Fix some issues reported by Coverity
2017-05-20 23:31:56 +03:00
8f3cb1c68d
Wrap sizeof arguments in braces
2017-05-20 19:29:23 +03:00
6303bb2247
Disable part of mmap test on OpenBSD that depends on UBC
2017-05-20 13:34:23 +03:00
4d7446e477
LibreSSL compatibility
...
This seems to be the idiomatic way to fix libressl compatibility issues,
judging by what most other open source projects seem to be doing.
I've confirmed that transmission builds with libressl for me after this
patch is applied.
2017-05-20 07:16:53 +02:00
6b0229a546
Fix some issues reported by Coverity
2017-05-16 21:37:00 +03:00
1e3d20422a
Reduce for loop variables scope
2017-05-14 01:38:31 +03:00
6d5e48f9e2
Fix some more off-by-one errors on last piece
...
See: TRAC-4037 and e2584b04ff
2017-05-09 14:23:25 +03:00
ccabc01900
lib: fix translator comment extraction
...
gettext won’t pick up a comment if it’s
not exactly one line above the string.
2017-05-02 21:22:15 +02:00
87220d44a5
Fix FTBFS on Windows (oops!)
2017-05-01 19:08:30 +03:00
14370e5353
Fix a number of other style inconsistencies met along the way (part 2)
2017-05-01 18:47:49 +03:00
e1d53855f4
Avoid declaring multiple variables on the same line
2017-05-01 18:46:41 +03:00
1bc247c105
Merge pull request #161 from slokhorst/rpc-ipv6
...
Allow the RPC server to listen on an IPv6 address
2017-05-01 13:31:14 +03:00
6a74bd438c
Announce INT64_MAX as size left if the value is unknown
...
This helps with trakers like Amazon S3 where signed type is used but
negative values aren't accepted.
Fixes : #250
2017-05-01 12:33:55 +03:00
ac4fa04277
Announce -1 as size left if the value is unknown
...
Fixes : #250
2017-04-30 21:18:02 +03:00
efaa9d0ddc
Compare system function return value to a specific value indicating the error
2017-04-30 19:47:18 +03:00
b342d134cb
Merge pull request #256 from kholia/Xfplay
...
Add Peer ID for Xfplay torrent client
2017-04-30 19:43:49 +03:00
fbd8d4c79f
Fix a number of other style inconsistencies met along the way
2017-04-30 19:33:55 +03:00
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
e970d7e546
Add Peer ID for Xfplay torrent client
...
This is based on the following resources,
http://www.xfplay.com/history.html
https://down.xfplay.com/xfplay9.994.exe
https://down.xfplay.com/xfplay9.992.exe
https://down.xfplay.com/xfplay9.991.exe
https://down.xfplay.com/xfplay9.99.exe
http://q.xfplay.com/
2017-04-29 12:40:55 +05:30
ac661ff099
Allow the RPC server to listen on an IPv6 address
2017-04-26 17:46:36 +02:00
6a15bc6742
Fix mount points enumeration (platform quota) on Solaris
...
Per documentation, `getmntent` returns 0 on success and -1 on error.
2017-04-22 21:42:44 +03:00
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
0f75e64d71
Detach the thread from within itself to avoid race condition
...
Fixes : #188
2017-02-23 00:07:39 +03:00
944382a62e
Add TCP_FASTOPEN support
...
Should make transmission slightly faster.
2017-02-19 12:54:01 +03:00
9e1c76a50f
fix spelling mistake
2017-02-01 10:14:11 +00:00
1cc67b31dd
Use PRIdMAX instead of TR_PRI_SOCK to accomodate intltool
2017-01-27 04:50:14 +03:00
c1f08edf79
Fix memory leaks found by GCC's -address=sanitize (reported by milloni)
...
Fixes : #56
2017-01-17 23:55:34 +03:00
67bda2dcb8
Handle two more cases where dirname/basename may have returned NULL (adds to 91f8ceb20d)
2017-01-17 02:22:31 +03:00
fd93316466
Improve version.h file generation
...
Store full revision hash in REVISION file. Write fixes 10 chars of revision
hash to version.h. Use `#pragma once` in version.h. Support getting revision
from TeamCity environment variable (similar to Jenkins).
2017-01-15 00:54:56 +03:00
3375b22b23
Simplify `tr_ssha1_matches` logic
...
Gets rid of needless heap memory allocations and copying. Convert SHA1 hash
to hex in-place.
Fixes : #141
2017-01-09 14:15:07 +03:00
15625de3c7
Extend SSHA1 test to check for predefined matches
...
Reduce number of test iterations to 4K along the way to shorten execution
time.
2017-01-09 14:12:17 +03:00
4179a623d5
Interrupt verification ASAP if torrent is being removed
2016-12-31 14:23:06 +03:00
0ac657c5f1
Fix up rename test to avoid random use-after-free failures
2016-12-25 19:44:38 +03:00
3cda09ea81
Fix up rename test to avoid random duplicate torrent failures
2016-12-24 21:24:50 +03:00
88505c345f
Allow for different-cased "nan" value returned by tr_truncd
2016-12-24 20:20:55 +03:00
448d8f39f6
CMake support for Solaris
2016-12-24 20:16:54 +03:00
193d68cc5c
Move tr_metainfoFree call higher per review comment
2016-12-09 22:01:58 +03:00
8541d74793
free the info resource if failed
...
free the info resource if failed
2016-11-07 14:07:56 +08:00
d8dd6f9c75
Merge pull request #60 from milloni/strncmp-instead-of-memcmp
...
Use strncmp instead of memcmp to avoid out-of-bounds reads
2016-11-02 23:13:25 +03:00
5b9ba3be0d
HTTPS links for trac, forum, portcheck, and build subdomains.
2016-11-02 20:50:22 +01:00
71af7be04f
Improve support for wolfssl (formely cyassl)
2016-10-26 22:27:20 +03:00
7f94c8df6c
Add support for mbedtls (formely polarssl)
2016-10-26 22:27:20 +03:00
69c33d0e18
Fix signedness related warnings
2016-10-20 20:27:55 +02:00
c6ad5bd36c
Go back to using memcmp in libtransmission/net.c
2016-10-20 17:35:46 +02:00
0390684bc4
Merge pull request #42 from wbx-github/master
...
uClibc-ng since 1.0.18 has sys/quota.h synced with GNU libc
2016-10-19 21:01:06 +03:00
bae138ca22
uClibc-ng since 1.0.18 has sys/quota.h synced with GNU libc
2016-10-19 19:33:35 +02:00
eda26f7590
Make sure `tr_sha1` calls pass lengths as int
...
This fixes inability to authenticate with password-protected session, and
a few more issues it seems.
2016-10-18 00:05:03 +03:00
3a1730495d
Use strncmp instead of memcmp to avoid out-of-bounds reads
2016-10-05 16:19:31 +02:00
17fb783c50
Add session-id.{c,h} to autoconf and Xcode builds
2016-09-27 21:36:01 +03:00
661e2b513d
Return session ID as part of "session-get" response
2016-09-27 21:18:36 +03:00
ff73e65069
Handle "fields" argument in "session-get" RPC request
...
If "fields" array is present in arguments, only return session fields
specified. Otherwise return all the fields as before.
2016-09-27 21:18:32 +03:00
b82f6009dd
Maintain lock file(s) corresponding to session ID
2016-09-27 20:53:10 +03:00
26b0a041cc
Factor out session ID into a standalone entity
2016-09-21 22:29:56 +03:00
4c00df9463
Abort handshake if establishing DH shared secret fails
...
Fixes #27
2016-09-18 14:01:00 +03:00
8c8386a7f3
Fix coding style and building with !TR_LIGHTWEIGHT
2016-09-07 01:09:04 +03:00
f91cf5ad8c
transmission: build against openssl 1.1.0
...
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
2016-09-06 00:11:17 +02:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
1b81bb7682
Replace SVN and SCM with VCS everywhere
2016-09-02 22:21:00 +03:00
076fd29098
#6071 : Fix typo in comment
2016-04-23 16:21:39 +00:00
7cd2d10d00
crypto.h and crypto-utils.h can't use #pragma once, it breaks our name munging in crypto-test-ref.h
2016-03-29 19:02:26 +00:00
c1abfe87c8
maybe fix double-include of crypto.h / crypto-utils.h in crypto-test
2016-03-29 17:18:50 +00:00
1af60ad6ad
use '#pragma once' instead of #ifndef..#define..#endif guards
2016-03-29 16:37:21 +00:00
77b5105ea0
fix bad TR_DEPRECATED macro on clang :P
2016-03-29 16:01:41 +00:00
8d38442cc1
give a useful definition of TR_DEPRECATED on msvc as well
2016-03-29 15:47:29 +00:00
5fbd24fda5
fix a handful of minor compiler warnings, mostly in the unit tests, eg field width shortening or implicit signed/unsigned conversions
2016-03-29 03:04:54 +00:00
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
91f8ceb20d
Handle potential dirname/basename errors where needed
2016-03-13 10:41:52 +00:00
86f231184b
Fix warning for when 2nd `iconv()` argument is const
2016-02-23 05:07:43 +00:00
990dea4dd3
Only depend on iconv if found
2016-02-07 12:00:15 +00:00
96ea2c82fd
Check for `iconv()` instead of `iconv_open()`, adjust utils test
2016-02-07 11:54:01 +00:00
a447f0d628
#6064 : Add test cases which exhibit the issue
2016-02-06 22:23:36 +00:00
1eb0ae0a3a
#6064 : Merge ConvertUTF.c fixes from LLVM (?)
2016-02-06 22:05:22 +00:00
9e7293b710
Add hidden "watch-dir-force-generic" setting handling to daemon
2016-01-25 22:09:49 +00:00
39749f8e4b
Make it possible to force generic watchdir implementation in runtime
2016-01-25 21:48:58 +00:00
0e7a8eb7aa
Add bitfield test for has all/none
2016-01-08 11:12:22 +00:00
13a98a02b8
Use `TR_BAD_SIZE` instead of -1 in `tr_quark_new()` calls
...
Extend quark test to improve branch coverage.
2016-01-07 19:20:14 +00:00
bfbf81cea1
#6048 : Improve error checking on metadata retrieval
2016-01-07 17:12:14 +00:00
eb49800fab
#5737 : Retry if RPC server fails to bind to specified address
2016-01-07 15:28:58 +00:00
53c38c760d
Add tests in such a way that target name is expanded (CMake)
2016-01-04 19:50:32 +00:00
4a634ae026
#5663 : Autotools fixes: proper kqueue check, macro definitions
2016-01-04 19:14:38 +00:00
9ecd2ad319
Improve file test modification time checks
2016-01-04 05:04:55 +00:00
6e00b1c543
Uncomment error prefixing tests
2016-01-03 21:03:54 +00:00
52b2a7557f
Fix line endings on last commit
2016-01-02 15:26:23 +00:00
119d10f01e
#5663 : Emulate `GetOverlappedResultEx` on Windows Vista/7
2016-01-02 15:23:38 +00:00
ea48360212
#5663 : Rework directory watching in daemon
...
Implement BSD/Darwin (kqueue) and Windows (ReadDirectoryChanges) mechanisms
for receiving directory change notifications. Use events instead of polling
for changes. Retry file parsing up to 3 times before giving up.
Huge thanks to missionsix for preparing first two versions of the patch.
2016-01-02 14:28:59 +00:00
de304e8a35
#5407 : In `tr_peerMgrGetDesiredAvailable()`, check if swarm is running (suggested by x190)
2015-12-31 14:33:02 +00:00
7d30ad3ff6
#5891 : Move UDP shutdown timer setup to sessionCloseImplStart
2015-12-31 14:24:15 +00:00
d3f5b5d5ab
#5891 : Fix crash on session shutdown (evdns_getaddrinfo_cancel)
2015-12-31 14:17:37 +00:00
40f3de0572
Loosen bitfield assertions to account for unknown bit counts
2015-12-31 05:22:42 +00:00
d4213f09d5
On second thought, bring back stdbool.h check back
...
Might be useful for uClibc (which still doesn't provide it) and others.
2015-12-29 19:44:50 +00:00
eb8fc35ac6
Remove useless checks and definitions (C99)
...
Now that MSVC support for C99 is quite good, remove previously needed but
now unused checks and definitions, like PRI* format macros (including
PRIdMAX and TR_PRIuSIZE, replaced with %jd and %zu) and inline macro.
Also, remove ssize_t typedef and replace few occurences with ev_ssize_t.
Also, remove check for stdbool.h availability (guaranteed by C99) and
include it unconditionally (except when in C++ mode).
2015-12-29 19:37:31 +00:00
eee92c82ac
Always add all source files to targets
...
Mark files which shouldn't be compiled as header-only, but still add
them as sources so that they are visible in e.g. MSVS project tree.
2015-12-29 02:04:37 +00:00
db9d46bb91
Would you please die already, nasty chdir warning...
2015-12-29 00:48:55 +00:00
a6d4bd35fc
Get rid of some more warnings
2015-12-29 00:42:40 +00:00
15c9e5c126
Get rid of some more warnings
2015-12-28 23:53:55 +00:00
4f266a5b15
Optimize URL-parsing functions a bit; rewrite `tr_urlParse()`
2015-12-28 23:52:26 +00:00
d0e157eceb
Fix bitfield bit removal, add more asserts, extend unit test
2015-12-27 16:34:47 +00:00
e3c5ab74ed
#5963 : Fix two more places where int is used in boolean context
2015-12-27 15:19:03 +00:00
3523277e7f
Ongoing refactoring (use size_t instead of int)
2015-12-25 11:34:35 +00:00
4a4badd4af
Ongoing refactoring (use size_t instead of int)
2015-12-25 10:19:50 +00:00
9853eb6715
Print log messages in one `OutputDebugString()` call (Windows)
2015-12-13 10:34:53 +00:00
ceb19b9711
Optionally return result length from `evbuffer_free_to_str()`
2015-12-13 10:23:22 +00:00
073b05bb85
Reserve a few more bytes for base64 operations to prevent heap corruption
2015-12-13 01:29:39 +00:00
3ea43ba778
fix const warnings
...
In particular, in passing argv around as a "const char * const *"
instead of a "const char *".
2015-12-06 22:39:14 +00:00
3d76f23b2b
fix unused label warning
...
some #ifdef code had a goto label 'non_sparse_out', so that goto label was
unused on platforms where all those #ifdef blocks were disabled.
2015-12-06 22:24:35 +00:00
b559a20029
const correctness
...
silence some qual-cast warnings by sprinkling more consts throughout,
e.g. casting a const void* to a const struct foo * const *
2015-12-06 22:13:10 +00:00
39c48a162e
(trivial) remove trailing enum comma
2015-12-06 21:41:18 +00:00
562f56459f
remove unused macro
2015-12-06 16:39:38 +00:00
505561c055
#5802 : Require absolute paths in "session-set" and "free-space" requests as well
2015-11-05 21:48:00 +00:00
f6f15d6937
Use tr_realloc (BSD reallocf-alike) instead of plain realloc
2015-10-25 17:13:14 +00:00
3d8c4c3960
Support absolute paths longer than ~260 chars on Windows
2015-10-23 05:29:47 +00:00
bobbyhopere