Jordan Lee
c1273a03a4
(trunk gtk) tweak to r12398: because most of the strings in category_filter_model_update() will be duplicates of each other, use g_string_chunk_insert_const() instead of g_string_insert().
2011-04-29 20:22:11 +00:00
Jordan Lee
53fede89f6
(trunk gtk) in filter.c's category_filter_model_update(), use a string chunk for all those temporary strings that are allocated in a looop
2011-04-28 23:13:14 +00:00
Jordan Lee
b93bef2712
(trunk gtk) gtr_get_host_from_url(): avoid a couple of malloc() + free() calls.
2011-04-28 18:37:27 +00:00
Jordan Lee
6326003e73
(trunk gtk) very minor tweak in deciding which rows to update in the torrent model.
...
Since we only display speed to two decimal places, we don't need to compare previous and current torrent speed with more precision than that.
2011-04-20 01:16:16 +00:00
Jordan Lee
fdbe7dc2da
(trunk gtk) more heap pruning, in tr_core
...
Tweak how we loop through the torrents in the model, again to avoid unnecessary GtkTreePath temporaries.
2011-04-13 22:16:50 +00:00
Jordan Lee
6cd1dcb574
(trunk gtk) Avoid unnecessary GtkComboBox queries.
...
Instead of calling gtk_combo_box_get_active_iter() on the filterbar's two comboboxes in every periodic update, keep the state information in a local struct and update it when the selection changes. That way the filter code doesn't even need to know about the GtkComboBox or the GtkTreeModel.
2011-04-13 22:04:31 +00:00
Jordan Lee
1d7a4eb528
(trunk gtk) more heap pruning: minor GtkTreeModel changes
...
Use gtk_tree_model_iter_nth_child() instead of gtk_tree_model_get_iter_first() to avoid an unnecessary gtk_tree_path object being created and destroyed. This is a very minor change and I'm not sure how useful it really is, but it doesn't hurt.
2011-04-13 22:00:55 +00:00
Jordan Lee
01461d0b4a
(trunk gtk) more heap pruning:
...
querying gconf2 each time the curl callack function is called is expensive, so query it once -- then again later, if the proxy settings change -- and remember the values in a local struct.
2011-04-13 06:18:30 +00:00
Jordan Lee
4a15899499
(trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer.
2011-04-12 11:13:41 +00:00
Jordan Lee
b1459c5d3b
(trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings
2011-04-12 10:51:52 +00:00
Jordan Lee
b797f51144
(trunk gtk) more heap pruning: give torrent-cell-renderer an internal GString buffer so that we don't have to create & free so many short-term strings
2011-04-12 10:04:05 +00:00
Jordan Lee
4ce3555786
(trunk gtk) minor janitorial: const correctness in tr-core's compare_by_name()
2011-04-11 16:27:41 +00:00
Jordan Lee
07e60d1fc0
(trunk gtk) more heap pruning: use a GStringChunk for the collated torrent names in tr-core.c
2011-04-07 04:29:37 +00:00
Jordan Lee
e02ce61d3e
(trunk gtk) removed the unused MC_NAME column from the torrent GtkListStore.
2011-04-05 17:00:38 +00:00
Jordan Lee
fb2ffbc542
(trunk gtk) use GQuarks instead of strings for keys in tr-icon and tr-window
2011-04-05 16:16:06 +00:00
Jordan Lee
c213d91ffd
(trunk gtk) use GQuarks instead of strings for keys in the filterbar's key/value pairs
2011-04-05 15:59:41 +00:00
Jordan Lee
708838b146
(trunk gtk) more heap pruning: in the main window's torrent list, only update the case-insensitive "collated name" of a torrent when the torrent's metadata changes (such as when a magnet link's metadata finishes downloading).
2011-04-05 15:41:51 +00:00
Jordan Lee
afa016704f
(trunk libT) more heap pruning: use a hash, rather than an allocated string in tr-core when watching for a torrent's tracker list to change
2011-04-05 01:36:37 +00:00
Jordan Lee
d233ea82e7
(trunk gtk) more heap pruning: avoid unnecessary malloc() + free() calls in gtr_get_host_from_url()
2011-04-04 16:54:09 +00:00
Jordan Lee
c16406bf7c
(trunk gtk) remove "dead nested assignment" wart detected by clang static analyzer
2011-03-31 04:58:38 +00:00
Jordan Lee
eb06d81fb9
(trunk) fix a handful of small memory leaks that valgrind found.
2011-03-25 17:42:47 +00:00
Jordan Lee
bd88521332
(trunk) yet more "#include" tweaks
2011-03-25 15:03:42 +00:00
Jordan Lee
b0379147d9
(trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5
2011-03-25 07:32:30 +00:00
Jordan Lee
4a1a4ebcc0
(trunk gtk) gtk_open_uri(): use gtk_show_uri() as the default implementation for GTK+ > 2.14.0.
...
gtk_show_uri() was added in 2.14.0
2011-03-25 06:40:46 +00:00
Jordan Lee
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
Jordan Lee
433da8df9a
(trunk gtk) gtr_compare_double() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-24 18:32:05 +00:00
Jordan Lee
a891136602
(trunk gtk) gtr_localtime() is only used in one place, so make it a private function there instead of leaving it public in util.h
2011-03-24 18:29:07 +00:00
Jordan Lee
e46d0a72ba
(trunk gtk) gtr_cell_renderer_get_padding() is only used in one place, so make it a private function there instead of leaving it public in util.h
2011-03-24 18:24:21 +00:00
Jordan Lee
5417711cd4
(trunk gtk) remove function gtr_strcmp0, which is redundant due to tr_strcmp0
2011-03-24 18:20:47 +00:00
Jordan Lee
0a1df687bb
still trying to make hudson happy
2011-03-22 16:07:49 +00:00
Jordan Lee
034a65aaf1
(trunk gtk) revert r12201 to try & make hudson happy
2011-03-22 16:03:10 +00:00
Jordan Lee
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
Jordan Lee
e259d0abbe
(trunk gtk) tweak Makefile.am
2011-03-21 20:45:50 +00:00
Jordan Lee
2544b4b228
(trunk gtk) dbus tweaks in Makefile.am based on examples from http://live.gnome.org/DBusGlibBindings .
...
1. tweak the way dbus-binding-tool is invoked... use --output=$@ $^
2. add the file generated by dbus-binding-tool to BUILT_SOURCES
2011-03-21 20:26:15 +00:00
Jordan Lee
374ed10f3b
(trunk) it's bad form to #include so many system headers in libtransmission/utils.h...
2011-03-16 18:04:23 +00:00
Jordan Lee
591b95286f
Show whether a tracker is http or udp. Without that context, it could be confusing to see the same tracker twice in a tier
2011-03-15 17:03:09 +00:00
Jordan Lee
fee784f1d8
(trunk) #4081 "Add 'cookieString' argument 'torrent-add' method in RPC" -- done.
2011-03-15 04:22:47 +00:00
Jordan Lee
018585d3b0
(trunk gtk) fix condition that could crash in some cases when right-clicking in the file list menu.
2011-03-13 16:45:32 +00:00
Jordan Lee
55381159f6
(trunk gtk) #4075 "add x-scheme-handler/magnet to desktop file" -- fixed.
...
Thanks to ampelbein for the patch :)
2011-03-13 15:56:12 +00:00
Jordan Lee
afe6d42ac1
(trunk gtk) when a tracker is manually added to a torrent, check the tracker's validity with tr_urlIsValidTracker()
2011-03-13 07:49:32 +00:00
Jordan Lee
e45a6dabc9
(trunk gtk) fix 2.22+ time display regression in the GTK+ client.
2011-03-11 04:10:28 +00:00
Jordan Lee
9145bce9cd
(trunk gtk) fix time display oops
2011-03-06 15:06:38 +00:00
Jordan Lee
05c39eaa3e
add a missing icon
2011-03-06 05:41:41 +00:00
Jordan Lee
411b0bbd1a
(trunk gtk) #4088 "Transmission needs 256x256 icon too" -- added large Tango icon by Andreas Nilsson. Thanks Andreas!
...
This larger icon is apparently needed for GNOME 3.
2011-03-05 19:15:37 +00:00
Jordan Lee
0a62f69f1c
(trunk gtk) copyediting.
2011-03-04 15:49:51 +00:00
Jordan Lee
ae20b67f16
(trunk gtk) remove unused code: gtr_warn_if_fail()
2011-03-04 15:21:00 +00:00
Jordan Lee
9c7caec13f
(trunk gtk) minor copyediting for clarity/readability
2011-03-04 14:31:23 +00:00
Jordan Lee
9283ef2ebb
(trunk gtk) #4080 "Toggling speed limit mode from the web interface doesn't affect GUI" -- fixed.
2011-03-04 05:58:32 +00:00
Jordan Lee
c6dd0b0ed4
(trunk libT) fix tr_ctorFree() crash reported by Rolcol
2011-03-04 04:45:34 +00:00
Jordan Lee
dcc070c86c
(trunk gtk) some tr-core cleanup
...
Variable and function name cleanup; regrouping related functions together, etc.
2011-03-03 07:17:57 +00:00
Jordan Lee
c7006ed8b3
(trunk gtk) remove the TrTorrent GObject subclass.
2011-03-03 01:59:25 +00:00
Jordan Lee
0a8535d9a5
(trunk gtk) #4040 "Show the torrent name in the Peers Tab's tooltips" -- done.
2011-02-19 13:04:09 +00:00
Jordan Lee
db8b83854e
(trunk gtk) Don't display uTP checkbox in non-uTP builds.
...
Tweak to r11976 s.t. the "Edit GNOME Proxy Settings" button doesn't get grouped in the "Peer Limits" section when uTP is disabled. :)
2011-02-19 09:30:06 +00:00
Jordan Lee
88a61d3b62
(trunk gtk) #4038 "Prefs dialog's blocklist section allows the 'update' button to be clicked when no blocklist is specified" -- fixed.
2011-02-19 09:02:39 +00:00
Juliusz Chroboczek
ee86584263
Don't display uTP checkbox in non-uTP builds (gtk).
...
Reported by Rolcol.
2011-02-18 22:22:02 +00:00
Jordan Lee
3f1b060241
(trunk T) add preliminary enable/disable toggles in daemon, gtk, and qt clients. 'preliminary' because this may be widened to a tri-state of inabled, disabled, and incoming only
2011-02-18 00:33:29 +00:00
Jordan Lee
7df7d34f6d
automake/autoconf; #includes in libtransmission
2011-02-18 00:32:19 +00:00
Juliusz Chroboczek
bd0ea13701
(gtk) Add tooltip for uTP peers.
2011-02-18 00:24:33 +00:00
Jordan Lee
716a3c90c2
(trunk) #4032 "Better error detection / reporting in http announces" -- added to trunk.
...
This patch adds two new flags to the callback function -- did_connect and did_timeout -- that are calculated inside of web.c using information from libcurl. This allows the announcer to detect timeouts more accurately and also to distinguish between unresponsive peers (which get the preexisting "Tracker did not respond" error message) and unconnectable peers (which get a new error message, "Could not connect to tracker").
2011-02-17 02:26:24 +00:00
Jordan Lee
dede299e04
(trunk gtk) #3866 "popup menu for file list manipulation" -- remove unused code in file-list.c
...
This code can be pulled back out of svn and readded if it's needed in the future.
2011-02-15 15:21:22 +00:00
Jordan Lee
72f9ab91fa
(trunk) make tr_torrentName() a public function.
...
This has been a private function in libtransmission for awhile now but it makes more sense as a public function.
2011-02-15 15:18:51 +00:00
Jordan Lee
59e8348b15
(trunk gtk) #4012 "Cannot set individual seeding time in GTK+ client" -- fixed.
...
The code in gtk/details.c was still using the pre-release RPC key "seedInactiveLimit" when it should have been using "seedIdleLimit" instead.
2011-02-12 23:54:33 +00:00
Jordan Lee
62b732708a
(trunk gtk) msgwin.c: silence compiler warning "warning: ‘pinned_to_new’ may be used uninitialized in this function"
2011-02-09 05:10:29 +00:00
Jordan Lee
24b9dc7dc2
(trunk gtk) #3866 "Popup menu for file list manipulation" -- removing from the 2.20 milestone
...
Looking over the 2.20 tickets, this one keeps sticking out. A popup menu may be useful if the "delete files" ticket is accepted in 2.30, but for this release (2.20) it doesn't really add anything new. One lesson from the 2.1x cycle was that features are a harder to remove than to add. So I'm going to hold off on adding this feature until it has a clear raison d'être.
2011-02-06 18:50:35 +00:00
Jordan Lee
1fabb9b9ea
(trunk) #3675 "Not all .part files are removed" -- handle trashing files via RPC.
...
When libtransmission gets a "remove torrent" request from RPC, it tries to delegate the work. This is because the GTK+ and Mac clients don't want torrents disappearing in a different thread and causing possible thread issues. So the GTK+ and Mac clients get notification about this via libtransmission's RPC callback and remove the torrents themselves. Unfortunately, that notification doesn't include information about whether or not to delete local data.
This commit adds that information to the RPC callback so that the Mac and GTK+ clients will know whether or not to trash the local files when a third-party RPC client requests that at torrent and its files be deleted.
2011-02-06 17:30:46 +00:00
Jordan Lee
c90ddfa1c3
(trunk libT) #3980 "segfault when adding many torrents remotely" -- possible fix.
...
gtk/main.c's onRPCChanged() is called from inside the libtransmission thread, yet it still made GTK+ calls to modify the GTK+ client's tr-core object when a torrent was added. This caused a race condition inside of the GTK+ internals. onRPCChanged() already knows to delegate work back to the GTK+ thread when a torrent is removed via RPC. This commit uses the same kind of mechanism to delegate work back to the GTK+ thread when a torrent is added via RPC.
2011-02-05 05:03:00 +00:00
Jordan Lee
a358858a99
(trunk libT) #3978 "Message window column sorting fails and triggers gtk warnings" -- fixed.
...
I'm not sure why sorting was in there in the first place; it doesn't make sense in a message log.. Disabling sorting fixes this bug.
2011-02-04 06:12:55 +00:00
Jordan Lee
7a5f87a207
(trunk gtk) #3972 "Verify progress changes not displaying" -- fixed.
...
make sure to call gtk_list_store_set() on rows matching torrents whose tr_stat.recheckProgress value has changed, triggering a row change event that causes the verify progress change to be displayed.
2011-02-02 02:45:20 +00:00
Jordan Lee
3f2e8b7b02
(trunk gtk) #3817 "use the OS' proxy support" -- fix memory leaks in the GTK+ implementation.
...
r11512 introduced a handful of memory leaks by not freeing the GConfValue objects after use.
2011-02-01 17:46:42 +00:00
Jordan Lee
705b27d128
(trunk gtk) #3876 "Give filesize its own column in the Files tree" -- fix minor memory leak introduced by r11642
...
r11642 allocated a pango font description with pango_font_description_copy() but never freed it.
2011-02-01 17:42:50 +00:00
Jordan Lee
88df1b15ee
(trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fix minor r11799 regression.
...
Clearing the model on shutdown generated a warning because it used the wrong cast. Rather than fixing the cast, add tr_core_clear() for symmetry with tr_core_load().
2011-02-01 01:45:41 +00:00
Jordan Lee
be99878e98
(trunk gtk) #3971 "favicons do not work for IP addresses" -- fixed.
...
gtr_get_host_from_url() wasn't written to handle dotted-quad or IPv6 address strings, but can handle them now.
2011-02-01 01:38:58 +00:00
Jordan Lee
b084493bfe
(trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fixed.
...
Long description in #3970 . Split tr_core's torrent GtkTreeModel into two models: one low-level unsorted one, and one proxy sorted one. That way we don't have to disable sorting before walking through the low-level one to sync the table's attributes with the tr_torrent and tr_stat.
2011-01-31 23:01:46 +00:00
Jordan Lee
1127463a1c
#3042 "Open torrent dialog focus not restored" -- fixed. patch by ijuxda.
...
the callback function for GtkWidget's focus-in-event should return TRUE to stop other handlers from being invoked for the event or FALSE to propagate the event further.
2011-01-25 04:26:10 +00:00
Jordan Lee
92def6b960
(trunk gtk) #3887 : "CPU spikes to 100% on scrolling" -- workaround committed.
...
The patch avoids use of GtkCellRendererText's "sensitive" property, and instead renders paused torrents' text using the widget's style's color for insensitive text. This approach honors the theme's "insensitive" color setting and uses it to draw insensitive text with no etching or shadowing.
The better option is still for Murrine to fix its text shadow issue... but until then, here is a workaround.
2011-01-22 13:26:44 +00:00
Jordan Lee
d6518b93b8
(trunk gtk) #3930 : Add drag-and-drop support for info hashes.
...
The "Add URL" dialog accepts URLs, magnet links, and infohashes, but only copyies urls and magnet links from the clipboard. Patch by cantabile.
2011-01-21 21:35:11 +00:00
Jordan Lee
4d529db419
(trunk gtk) include the torrent hashcode in the model's collated name.
...
This simplifies sorting by name by merging the primary and secondary keys (case-insensitive name, and hash string) into a single key.
2011-01-21 18:30:08 +00:00
Jordan Lee
287d61197a
(trunk gtk) set GtkLabel's "single-line-mode" flag to TRUE in the toolbar, in the stats dialog, and in the details dialog's info tab.
...
According to the GTK+ documentation, this "can be an advantage in situations where resizing the label because of text changes would be distracting, e.g. in a statusbar." It doesn't seem to prevent relayout in GTK+ 2.20.1, but maybe other versions of GTK+ will make better use of the flag.
2011-01-21 17:31:35 +00:00
Jordan Lee
acd941f17a
(trunk gtk) companion commit to r11738 to reduce unnecessary re-rendering in the main window
...
The main window called gtk_tree_model_filter_refilter() once per second to refresh the torrent list's filtering. This is not an efficient approach: gtk_tree_model_filter_refilter() emits a "row changed" event for every row, causing unnecessary re-rendering.
I've removed the call to gtk_tree_model_filter_refilter() and expanded the model to includes all the fields necessary for filtering. That way we only fire "row changed" events for rows that actually change.
By reducing the number of renders in steady state, this might ameliorate https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/655024
However it will *not* help the related "CPU spikes to 100% on scrolling" ticket at https://trac.transmissionbt.com/ticket/3887 because rendering paused torrents is still exceptionally expensive in the murrine theme.
2011-01-21 17:07:23 +00:00
Jordan Lee
58c7556534
(trunk gtk) #3916 "Reorder the list when metadata is downloaded" -- fix r11737 typo.
2011-01-21 16:36:57 +00:00
Jordan Lee
aea77bc9f6
(trunk gtk) make "gtr_label_set_text" public and use it everywhere instead of gtk_label_set_text()
...
Some of the refresh events to the main window's torrent list are caused by main window relayout caused by the toolbar's GtkLabels recalculating their size after being updated once per second. To prevent relayout in some trivial cases, I'm replacing the gtk_label_set_text() calls with gtr_label_set_text() because the latter doesn't update the label widget if the old and new text strings are the same.
There are other changes that can handle more important cases -- I'll test those out next.
2011-01-21 16:32:27 +00:00
Jordan Lee
9ce58e33ac
(trunk gtk) #3916 "Reorder the list when metadata is downloaded" -- fixed.
...
When tr_info.name changes, update the collated name in the main window's TreeStore.
2011-01-21 02:58:58 +00:00
Jordan Lee
a63fdd15b4
(trunk) #3926 "use 'Open Torrent' instead of 'Add Torrent' in GTK+ and Qt clients" -- fix accelerator ambiguity.
...
Using Ctrl-O for "Open File" causes a conflict with the existing Ctrl-O for "Open Folder." The HIG-compliant shortcut wins the conflict, so "Open Folder" gets a new accelerator.
2011-01-20 20:32:28 +00:00
Jordan Lee
7dd9427a1f
(trunk gtk) #3909 -- don't use Ctrl-M as the shortcut for "Copy Magnet Link to Clipboard."
2011-01-20 20:07:09 +00:00
Jordan Lee
3b28138c71
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- change the filename from add-dialog.[ch] to open-dialog.[ch]. whoooo
2011-01-20 19:57:42 +00:00
Jordan Lee
131afcc3a4
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- text changed.
2011-01-20 19:48:13 +00:00
Jordan Lee
ddba265755
(trunk gtk) source code formatting tweak
2011-01-19 14:25:22 +00:00
Jordan Lee
9d038a8539
(trunk gtk) #3913 "Area to display a torrent's comment is small" -- fixed.
2011-01-19 14:22:29 +00:00
Jordan Lee
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Jordan Lee
87e78816ad
(trunk gtk) #3519 "webseeds don't work" -- the `active' filter in the GTK+ client didn't test for webseed activity.
2011-01-18 23:26:41 +00:00
Jordan Lee
d3eb8c6ea4
trivial minor changes to indentation, text strings, etc.
2011-01-18 00:31:05 +00:00
Jordan Lee
d1a7f70313
(trunk gtk) #3907 "in the details dialog's peers tab, 'status' is a misnomer" -- changed to 'flags'.
2011-01-17 16:13:45 +00:00
Jordan Lee
6d1ad8e0cb
(trunk gtk) #3908 "details dialog's information tab shows (verified + unverified) + unverified" -- fixed.
2011-01-17 16:10:17 +00:00
Jordan Lee
a433b0c4cc
#3686 "add rpc command to cleanly shutdown daemon" -- added for libT, tr-daemon, tr-gtk, tr-remote, and the rpc spec
2011-01-15 18:12:45 +00:00
Jordan Lee
1a862315de
(trunk gtk) #3903 "Scroll to new messages when viewing new messages in the message window" -- added.
2011-01-15 07:57:01 +00:00
Jordan Lee
e4bd783ec2
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Jordan Lee
36e54b59e9
(trunk gtk) #3897 "filterbar should use tr_torrentStatCached() instead of tr_torrentStat()" -- fixed.
2011-01-13 11:57:06 +00:00
Jordan Lee
88d58502aa
(trunk gtk) #3896 "Redundant call to tr_torrentStat() in tr_core_update()" -- fixed.
2011-01-13 11:50:58 +00:00
Jordan Lee
721cd1c3c3
(trunk gtk) #3876 "Give filesize its own column in the Files tree" -- added.
2011-01-06 17:21:55 +00:00
Jordan Lee
aea8d8d0b5
(trunk gtk) #3519 "webseeds don't work" -- fix webseed peer counts and download speeds in the GTK+ client's main window
2011-01-06 02:40:10 +00:00
Jordan Lee
c48528faf1
(trunk gtk) #3866 "Popup menu for file list manipulation" -- patch by ijuxda + random bugs by me
2011-01-05 07:08:34 +00:00
Jordan Lee
c7cc8301db
(trunk) update credits
2011-01-03 05:58:58 +00:00
Charles Kerr
992623756c
(trunk gtk) #3847 "GTK+ 3 transition: use accessor functions unstead of direct access" -- use GTK_CELL_RENDERER() macro for casting a TorrentCellRenderer to a GtkCellRenderer. Thanks to ijuxda for the suggestion.
2010-12-27 23:49:45 +00:00
Charles Kerr
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
Charles Kerr
0a160aec49
(trunk gtk) GTK_DIALOG_NO_SEPARATOR will be removed in GTK 3, so don't use it.
2010-12-25 02:05:15 +00:00
Charles Kerr
5c53e35dbf
(trunk gtk) #3836 "libevent2 support" -- remove "#include <evhttp.h>" from gtk/ client
2010-12-24 09:23:57 +00:00
Charles Kerr
f5b13c46dc
(trunk gtk) #3847 "GTK+ 3 transition: Use accessor functions instead direct access" -- don't directly access GtkCellRenderer.xpad, GtkCellRenderer.ypad, or GtkWidget.window.
2010-12-24 09:04:52 +00:00
Charles Kerr
ba2e18b0c3
(trunk, gtk) some code cleanup: (1) details dialog handler, (2) selection change handler
2010-12-23 22:31:28 +00:00
Charles Kerr
bf2835c557
(trunk gtk) remove unused code: tr_core_quit()
2010-12-23 21:50:09 +00:00
Charles Kerr
81cb2276c8
(trunk gtk) #3844 "error popup when adding a relative path" -- fixed. initial patch by ijuxda.
2010-12-22 07:04:11 +00:00
Charles Kerr
a297cd328a
(trunk gtk) add GTR_UNICODE_BULLET
2010-12-22 07:00:25 +00:00
Charles Kerr
057487d18e
(trunk gtk) more gtr_ naming cleanup
2010-12-22 06:25:30 +00:00
Charles Kerr
b86e1e1056
(trunk gtk) kill "pref_flag_t" in a burlap sack and throw it off the cliff into the freezing water below
2010-12-22 06:11:49 +00:00
Charles Kerr
6627aade08
(trunk gtk) don't use the GSEAL'ed variable vbox GtkDialog directly... use gtk_dialog_get_content_area() instead
2010-12-22 03:12:47 +00:00
Charles Kerr
1b7a8cdc68
(trunk gtk) fix r11563 bug that stopped showing the Torrent Options dialog
2010-12-22 03:06:06 +00:00
Charles Kerr
5eafe91824
(trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately.
2010-12-21 19:20:58 +00:00
Charles Kerr
0372797e6f
(trunk gtk) hig.c cleanup. (1) make hig_workarea_add_control private (2) remove unused function hig_message_dialog_set_text
2010-12-21 17:22:37 +00:00
Charles Kerr
250a5fd8ec
(trunk gtk) remove dead code: gtk/tracker-list.[ch]
2010-12-21 17:19:07 +00:00
Charles Kerr
c0723bcac8
remove unused code: gtr_toolbar_set_orientation() is unnecessary because we always use the default setting
2010-12-21 16:50:41 +00:00
Charles Kerr
fee807cd57
minor tweak: tr_core_load() should return void, not int
2010-12-21 16:49:57 +00:00
Charles Kerr
345b14adbc
(trunk) #3836 "libevent2 support" -- bump libevent2 requirement to 2.0.10. This will break the Mac build for a minute intil BMW applies his Mac patch
2010-12-20 02:07:51 +00:00
Charles Kerr
3a6cf6afc9
(trunk gtk_) #3837 "Dangling pointer after quit cancel" -- fixed.
2010-12-19 09:50:28 +00:00
Charles Kerr
5bf05ab31b
(trunk gtk) #3838 "Unselected active torrents not counted for quit check" -- fixed.
2010-12-19 09:33:02 +00:00
Charles Kerr
3054f9a166
(trunk gtk) #3834 "'Origin' field in Torrent Properties dialog should be ellipsized" -- fixed.
2010-12-17 16:30:40 +00:00
Charles Kerr
1d9b9ce245
(trunk) clarify http_proxy in the manpages
2010-12-16 16:19:19 +00:00
Charles Kerr
821d315453
(trunk) #3675 "Not all .part files are removed" -- added patch for libtransmission and GTK+ client
2010-12-16 03:38:07 +00:00
Charles Kerr
27a1b2dc33
(trunk) one of the periodic, banal "remove-trailing-spaces from lines of source code" cleanup commits
2010-12-12 16:43:19 +00:00
Charles Kerr
465a2e7c90
(trunk) extremely minor manpage copyediting
2010-12-12 16:36:46 +00:00
Charles Kerr
607de96979
(trunk) #3817 "Use the OS' proxy support" -- add manpage documentation for http_proxy to transmission-gtk and transmission-cli.
2010-12-12 16:33:08 +00:00
Charles Kerr
b313c6f617
(trunk gtk, qt) "Show 'queued to verify' torrents in the 'verifying' filter" -- added to trunk.
2010-12-12 16:07:04 +00:00
Charles Kerr
5d72e8b7f7
(trunk gtk) futz with the preferences dialog layout & terminology a little bit. steal a little back from qBittorrent.
2010-12-11 18:49:59 +00:00
Charles Kerr
0e9247b84a
(trunk) #3817 "use the OS' proxy support" -- implemented for libtransmission, transmission-gtk
2010-12-10 18:51:05 +00:00
Charles Kerr
fb106b541c
(trunk gtk) #3719 "handle API changes to libnotify" -- fixed with patch from _v_l
2010-12-10 14:48:56 +00:00
Charles Kerr
d216d435a2
(trunk gtk, qt) #3770 "GTK and Qt clients should sort-by-progress as the Mac client does" -- fixed.
2010-12-01 05:41:58 +00:00
Charles Kerr
c9af96eb43
(trunk gtk) #3777 "Ellipsize Error: line" -- fixed.
2010-11-29 12:42:12 +00:00
Charles Kerr
0a64fd4b40
(trunk gtk) #3701 "Unblur statusbar icons" -- fixed.
2010-11-27 19:30:20 +00:00
Charles Kerr
04c60c7221
(trunk gtk) #3697 "make blocklist URL configurable" -- better error handling in GTK+ client if the user-specified blocklist can't be fetched
2010-11-13 17:05:22 +00:00
Charles Kerr
fafc36f78e
(trunk gtk) remove calls to gtk_dialog_set_has_separator(), which has been removed in GNOME 3
2010-11-10 06:29:08 +00:00
Charles Kerr
ffe54a20ed
(trunk) #3698 "creation date of magnet links are set before the epoch." -- fixed.
2010-11-08 19:16:03 +00:00
Charles Kerr
865c0853d5
(trunk gtk) #3710 "Handle API changes to libnotify 0.7" -- fixed. The cpp hack is borrowed from qbittorrent and torium... :)
2010-11-06 14:37:34 +00:00
Charles Kerr
92620b72b0
(trunk) #3697 "make blocklist URL configurable" -- implemented in GTK+, Qt, and RPC
2010-10-31 17:16:12 +00:00
Charles Kerr
22c622a92f
(trunk) #3688 "remove proxy support" -- remove from libtransmission
2010-10-31 17:05:31 +00:00
Charles Kerr
0fcc5845d9
(trunk gtk) disable preferences proxy tab
2010-10-29 04:19:37 +00:00
Charles Kerr
5725b7c922
(trunk) #3663 "clang warnings in 2.11" -- fixed.
2010-10-24 05:52:38 +00:00
Charles Kerr
1c2a7359af
(trunk gtk) "hibernation inhibition broke in transmission-2.00" -- fixed.
2010-10-21 20:04:00 +00:00
Charles Kerr
571f6b8e07
(trunk gtk) #3421 "protect against division by zero in details window" -- fixed another case reported by kovalev
2010-10-21 12:27:40 +00:00
Charles Kerr
d365c40958
(trunk gtk) #3644 "About Dialog appear with main window" -- handle another special case. Fix confirmed by kovalev
2010-10-18 22:18:15 +00:00
Charles Kerr
ac588c4835
(trunk gtk) #3644 'about dialog keeps reappearing' - fixed.
2010-10-18 11:43:30 +00:00
Charles Kerr
d908c7fc9e
(trunk gtk) #3635 "transient children of the main window aren't hidden when the main window is hidden to the notification area" -- fixed in trunk for 2.11.
2010-10-15 23:23:57 +00:00
Charles Kerr
56e90f1457
(trunk) more "svn propset" tweaks for $Id$
2010-10-01 20:22:51 +00:00
Charles Kerr
f3ab57e082
(trunk gtk) #3589 "drag-and-dropping a magnet link onto the GTK+ client doesn't work" -- fixed.
2010-10-01 13:50:23 +00:00
Charles Kerr
80f69ee7d3
(trunk) fix svn properties on several files. Thanks ot Elbandi for suggesting this
2010-10-01 13:33:39 +00:00
Charles Kerr
4d11079b5d
(trunk gtk) #3585 "in torrent_cell_renderer_get_size(), set x_offset and y_offset even if cell_area is NULL" -- fix r11267 oops
2010-09-27 23:10:54 +00:00
Charles Kerr
4bdd0860cc
(trunk gtk) #3585 -- in torrent_cell_renderer_get_size(), set x_offset and y_offset even if cell_area is NULL
2010-09-27 20:24:41 +00:00
Charles Kerr
d57ba48775
(trunk) #3577 -- replace gear icon for GTK+, Qt clients
2010-09-24 15:22:53 +00:00
Charles Kerr
7f6cfb3c24
(trunk gtk) #3554 "turtle speed button doesn't update when toggled via RPC" -- fix minor bug introduced in r11215
2010-09-24 14:21:08 +00:00
Charles Kerr
c721052abb
(trunk gtk) fix minor memory leak that may or may not be related to https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/630679
2010-09-23 17:20:05 +00:00
Charles Kerr
6e62d0d99d
(trunk gtk) fix a minor UMR error that Valgrind found
2010-09-23 17:05:40 +00:00
Charles Kerr
60132d3781
(trunk gtk) #3543 'wrong link in the about window' -- separate gtr_open_file() from gtr_open_uri()
2010-09-22 16:44:38 +00:00
Charles Kerr
8a81611d16
tweak the valgrind script
2010-09-19 22:21:36 +00:00
Charles Kerr
71d0b05524
(trunk qt,gtk) #3549 "torrent properties window doesn't fix netbook screen" -- merge the "Uploaded" and "Ratio" rows to save a little vertical space
2010-09-19 17:33:25 +00:00
Charles Kerr
e537bdcd4f
(trunk gtk) #3529 "slow priority-sorting in file list" -- fixed
2010-09-17 13:23:20 +00:00
Charles Kerr
bf0e84f266
(trunk) #3549 "torrent properties window does not fit netbook screen" -- fixed
2010-09-17 05:43:06 +00:00
Charles Kerr
efd71c05ab
(trunk gtk) #3554 "alternate speed (turtle) button does not update when toggled via RPC" -- fixed.
2010-09-17 02:27:03 +00:00
Charles Kerr
2d1348c2f7
(trunk gtk) #3555 "disambiguate the string 'None' for better i18n" -- fixed
2010-09-16 17:45:24 +00:00
Daniel Lee
8f57986784
(trunk) don't display "Got a list of 0 peers" for currently paused torrents
2010-09-16 02:00:54 +00:00
Charles Kerr
43f03f3de6
remove sort-by-tracker from the GTK+ client
2010-09-06 00:23:44 +00:00
Charles Kerr
2d5ac5b150
(trunk libT) add a string length argument to tr_urlIsValid()
2010-08-21 12:47:28 +00:00
Daniel Lee
595ad6eb2e
(trunk) Update 'TryExec' in transmission-gtk.destkop to the new binary name
2010-08-09 01:01:48 +00:00
Charles Kerr
c01c18b46b
(trunk) make --version/-V behave the same in the other apps too
2010-08-09 00:18:26 +00:00
Charles Kerr
c75c2c13e9
(trunk gtk) fix label clipping issue in the statusbar
2010-08-06 23:50:35 +00:00
Charles Kerr
42c2fccbfb
(trunk gtk) remove dead code
2010-08-06 15:35:10 +00:00
Charles Kerr
65d5ec0c63
(trunk gtk) small renderer cleanup from the #3488 patch
2010-08-06 15:17:27 +00:00
Charles Kerr
1c0d149c12
(trunk gtk) #3491 "Magnet links don't appear until download of metadata." -- fixed.
2010-08-06 15:03:25 +00:00
Charles Kerr
e934290980
(trunk gtk) portability: use g_dngettext() instead of ngettext()
2010-08-06 14:38:54 +00:00
Charles Kerr
0e03b5e287
(trunk) run all our PNG files through pngout < http://advsys.net/ken/util/pngout.htm > to shrink 'em down
2010-08-06 07:51:24 +00:00
Charles Kerr
92e989f553
(trunk gtk) experimentally remove sexy-icon-entry from the GTK+ client... GtkEntry can handle it now
2010-08-06 06:54:42 +00:00
Charles Kerr
83bdedec8e
(trunk gtk) Remove the `PREF_KEY_MAIN_WINDOW_LAYOUT_ORDER' preferences key. This feature seemed like a good idea once upon a time, but I've never heard a report of anyone actually using it...
2010-08-06 06:22:05 +00:00
Charles Kerr
70be70d85f
nice job.
2010-08-05 13:24:46 +00:00
Charles Kerr
2db6183add
(trunk) ..and the manpages :)
2010-08-05 13:06:20 +00:00
Charles Kerr
7e7cd39c17
whoops
2010-08-05 13:03:00 +00:00
Charles Kerr
9cb6333b6c
(trunk) rename "transmission" as "transmission-gtk" and "transmissioncli" as "transmission-cli" for consistency with the other transmission apps
2010-08-05 12:57:54 +00:00
Charles Kerr
4cc11e47ee
(trunk) synchronize the "see also" sections of the manpages
2010-08-04 23:17:49 +00:00
Daniel Lee
c30ed43082
(trunk) #3185 : Number on drop-down menu "Activity" - "Active" seems does not follow a change in torrent status correctly
2010-08-04 17:35:48 +00:00
Daniel Lee
fc15c5ba4b
(trunk gtk) Clean up r11086
2010-08-04 05:25:43 +00:00
Charles Kerr
5624840ac4
(trunk) #3478 "Display bug when magnet links without display names are added" -- fixed in trunk
2010-08-03 03:16:21 +00:00
Charles Kerr
49e23db0fe
(trunk gtk) more dead code removal
2010-08-02 22:45:38 +00:00
Charles Kerr
36064b8120
(trunk gtk) rewrite the main window's drag-and-drop handler s.t. it's GTK+ 3 compliant
2010-08-02 22:31:31 +00:00
Charles Kerr
5182600179
(trunk) add drag-and-drop support to the "create new torrent" dialogs in the Qt and GTK+ clients
2010-08-02 20:55:11 +00:00
Charles Kerr
5aa04d83ef
(trunk) sync some more GTK+ and Qt strings
2010-08-02 16:29:23 +00:00
Charles Kerr
fb03acbbc2
(trunk) consistency tweaks between the GTK+ and Qt client:
...
1. synchronize some of the keyboard shortcuts
2. synchronize some text in the preferences dialog
3. add a "Desktop" tab in the Qt client's preferences dialog
4. add a "Donate" button to the Qt client's help menu
2010-08-02 03:07:42 +00:00
Charles Kerr
59f5f3ed6b
(trunk gtk) replace tr_strcmp() with gtr_strcmp0(), a porability wrapper around g_strcmp0()
2010-08-01 19:13:34 +00:00
Charles Kerr
3fa4865863
(trunk) #3450 "regression: Qt client dbus support broken" -- fixed
2010-08-01 18:55:04 +00:00
Daniel Lee
ff23406f38
(trunk) #3471:Add 'finished' to filterbar
2010-08-01 17:43:35 +00:00
Charles Kerr
344e4bedc5
(trunk) set minimum widths for the upload/download labels in the statusbar
2010-07-31 06:20:17 +00:00
Charles Kerr
d1ee0559dc
(trunk gtk) simplify the compact mode rendering code a bit
2010-07-31 03:43:12 +00:00
Charles Kerr
65176f2b83
(trunk gtk) remove dead code
2010-07-30 22:21:14 +00:00
Charles Kerr
f4e3b6e670
(trunk gtk) simplify the collation process for sorting torrents by name
2010-07-30 22:19:20 +00:00
Charles Kerr
969c72b927
(trunk gtk) #3454 "update tracker tab to match gtk+ client" -- copy a little bit of the Qt client's layout to the GTK+ client
2010-07-28 17:27:58 +00:00
Charles Kerr
e6bafdf26b
(trunk) #3045 "size units" -- sync the default units in all the apps s.t. they're consistent with each other
2010-07-28 00:31:11 +00:00