eb06d81fb9
(trunk) fix a handful of small memory leaks that valgrind found.
2011-03-25 17:42:47 +00:00
b0379147d9
(trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5
2011-03-25 07:32:30 +00:00
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
c7006ed8b3
(trunk gtk) remove the TrTorrent GObject subclass.
2011-03-03 01:59:25 +00:00
287d61197a
(trunk gtk) set GtkLabel's "single-line-mode" flag to TRUE in the toolbar, in the stats dialog, and in the details dialog's info tab.
...
According to the GTK+ documentation, this "can be an advantage in situations where resizing the label because of text changes would be distracting, e.g. in a statusbar." It doesn't seem to prevent relayout in GTK+ 2.20.1, but maybe other versions of GTK+ will make better use of the flag.
2011-01-21 17:31:35 +00:00
acd941f17a
(trunk gtk) companion commit to r11738 to reduce unnecessary re-rendering in the main window
...
The main window called gtk_tree_model_filter_refilter() once per second to refresh the torrent list's filtering. This is not an efficient approach: gtk_tree_model_filter_refilter() emits a "row changed" event for every row, causing unnecessary re-rendering.
I've removed the call to gtk_tree_model_filter_refilter() and expanded the model to includes all the fields necessary for filtering. That way we only fire "row changed" events for rows that actually change.
By reducing the number of renders in steady state, this might ameliorate https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/655024
However it will *not* help the related "CPU spikes to 100% on scrolling" ticket at https://trac.transmissionbt.com/ticket/3887 because rendering paused torrents is still exceptionally expensive in the murrine theme.
2011-01-21 17:07:23 +00:00
aea77bc9f6
(trunk gtk) make "gtr_label_set_text" public and use it everywhere instead of gtk_label_set_text()
...
Some of the refresh events to the main window's torrent list are caused by main window relayout caused by the toolbar's GtkLabels recalculating their size after being updated once per second. To prevent relayout in some trivial cases, I'm replacing the gtk_label_set_text() calls with gtr_label_set_text() because the latter doesn't update the label widget if the old and new text strings are the same.
There are other changes that can handle more important cases -- I'll test those out next.
2011-01-21 16:32:27 +00:00
131afcc3a4
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- text changed.
2011-01-20 19:48:13 +00:00
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
f5b13c46dc
(trunk gtk) #3847 "GTK+ 3 transition: Use accessor functions instead direct access" -- don't directly access GtkCellRenderer.xpad, GtkCellRenderer.ypad, or GtkWidget.window.
2010-12-24 09:04:52 +00:00
057487d18e
(trunk gtk) more gtr_ naming cleanup
2010-12-22 06:25:30 +00:00
5eafe91824
(trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately.
2010-12-21 19:20:58 +00:00
27a1b2dc33
(trunk) one of the periodic, banal "remove-trailing-spaces from lines of source code" cleanup commits
2010-12-12 16:43:19 +00:00
5d72e8b7f7
(trunk gtk) futz with the preferences dialog layout & terminology a little bit. steal a little back from qBittorrent.
2010-12-11 18:49:59 +00:00
0a64fd4b40
(trunk gtk) #3701 "Unblur statusbar icons" -- fixed.
2010-11-27 19:30:20 +00:00
d57ba48775
(trunk) #3577 -- replace gear icon for GTK+, Qt clients
2010-09-24 15:22:53 +00:00
c75c2c13e9
(trunk gtk) fix label clipping issue in the statusbar
2010-08-06 23:50:35 +00:00
e934290980
(trunk gtk) portability: use g_dngettext() instead of ngettext()
2010-08-06 14:38:54 +00:00
92e989f553
(trunk gtk) experimentally remove sexy-icon-entry from the GTK+ client... GtkEntry can handle it now
2010-08-06 06:54:42 +00:00
83bdedec8e
(trunk gtk) Remove the `PREF_KEY_MAIN_WINDOW_LAYOUT_ORDER' preferences key. This feature seemed like a good idea once upon a time, but I've never heard a report of anyone actually using it...
2010-08-06 06:22:05 +00:00
344e4bedc5
(trunk) set minimum widths for the upload/download labels in the statusbar
2010-07-31 06:20:17 +00:00
65176f2b83
(trunk gtk) remove dead code
2010-07-30 22:21:14 +00:00
52c04a0d06
(trunk) some units formatter cleanup.
2010-07-09 20:53:38 +00:00
42104d9a9b
(trunk gtk) ensure that the space allocated the up/down speed labels in the statusbar are wide enough to show all speeds without truncating the label
2010-07-08 21:24:26 +00:00
6e5af03d78
(trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings
2010-07-04 06:07:21 +00:00
cdcc4705aa
(trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while.
2010-07-03 00:25:22 +00:00
f097e05d7b
(trunk gtk) add portability wrapper for gtk_widget_get_realized() in gtk+ < 2.20
2010-06-26 16:07:15 +00:00
01a10a2b6e
(trunk gtk) #3346 "busy icon needed while processing request" -- added.
2010-06-26 15:55:19 +00:00
e2b4933777
(trunk gtk) #3344 "statusbar needs better grouping of speeds and their icons" -- fixed
2010-06-25 20:15:05 +00:00
06f044680a
(trunk) #3174 "Use IEC standard units (KiB, MiB, GiB) instead of (KB, MB, GB)" -- implemented for gtk, qt, daemon, cli, and web client
2010-04-28 01:26:46 +00:00
41d090b735
(trunk, gtk) rename the slightly-pejorative "minimal view" as "compact view"
2010-03-15 14:42:43 +00:00
824182df54
(trunk gtk) add favicon support to the new filterbar
2010-03-15 02:53:31 +00:00
2aa1e69f98
(trunk gtk) first draft of a filterbar experiment
2010-03-14 05:13:02 +00:00
40adcb5491
(trunk gtk) don't dereference a NULL pointer if a torrent has no "name"
2010-02-06 05:21:25 +00:00
fa94830df1
(trunk gtk) remove a few very minor memory leaks in the GTK+ client
2010-01-11 21:54:54 +00:00
7af6abcee1
(trunk gtk) remove debugging message I accidentally left in the last commit
2010-01-10 02:19:08 +00:00
719446516d
(trunk gtk) #2739 "the status bar oscillates ostensibly" -- implemented for 1.80
2010-01-10 01:43:04 +00:00
ae6bdbae6e
(trunk gtk) #2708 "missing tooltips" -- add previously-missing tooltips to two of the statusbar buttons
2010-01-03 17:38:24 +00:00
6b98510841
(trunk gtk) #2668 "minor memory leaks in gtk client" -- fix two GtkImages that were being leaked in the main window
2009-12-14 19:24:05 +00:00
4e252aa106
(trunk) fix warnings found by the clang static analyzer, reported & patched by wereHamster
2009-12-07 04:06:14 +00:00
a8e11d9e3a
(trunk gtk) #2616 : "for the ratio mode button, use the yin/yang icon submitted by jimmac"
2009-11-27 14:55:52 +00:00
5e3949f37c
(trunk gtk) #2110 "allow adding torrents with no trackers" - don't crash when sorting or filtering by tracker. (Reported by Rolcol and jch)
2009-11-26 04:06:49 +00:00
c7741230af
(trunk gtk) increase the temporary buffer size to avoid string truncations
2009-09-12 07:26:13 +00:00
7800e163f1
(trunk T) possible fix for gtk crash reported by Michael Stoykov
2009-09-11 23:43:42 +00:00
bc6343f577
(trunk, gtk ) #2361 : Turtle toggle button is not visible using old GTK 2.6.x library
2009-08-29 14:07:51 +00:00
9101f64684
(trunk gtk) #2339 : set "is-important" property of some toolbar actions in preparation for gnome 2.28 < http://blogs.gnome.org/thos/2009/07/29/toolbar-styles/ >
2009-08-16 03:09:06 +00:00
e339aab7c7
(trunk gtk) fix r8900 oops
2009-08-15 22:11:54 +00:00
be3f3a617e
(trunk gtk) fix minor regression in #2292 that limited the gtk client's speed display to not count fractions-of-a-KiB/s
2009-08-12 13:42:49 +00:00
cb79214854
(trunk) remove trailing spaces
2009-08-10 20:04:08 +00:00
1083535d9b
(trunk gtk) fix #2292 : wrong speed in bottom bar
2009-08-07 20:49:06 +00:00
58ba65f55b
(trunk, gtk/qt) use Monsoon's strings for encryption preferences and Deluge's system tray tooltip.
2009-06-30 18:08:50 +00:00
bd5c9cf3a8
(trunk gtk) #2251 : gtk client should use GDK-safe versions of g_idle_add() and g_timeout_add*()
2009-06-29 17:22:35 +00:00
0861ca3908
(trunk gtk,qt) more o/c simplification of the prefs dialog
2009-06-27 05:23:13 +00:00
36eac9e36a
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
4d46cc5f7a
(trunk gtk) #2233 : Replace SexyIconEntry by GtkEntry icon functionality if GTK+ >= 2.16.0
2009-06-21 17:18:02 +00:00
859c1b6fff
(trunk gtk) #2201 : transmission doesn't remember maximized state
2009-06-11 22:36:45 +00:00
dcdb76fa9e
(trunk gtk) #1451 : fix r8402 oops
2009-05-16 19:27:14 +00:00
135f0ec673
(trunk gtk) silence a couple more compiler warnings
2009-05-15 15:15:52 +00:00
79f17a374a
(trunk gtk) #1451 : make it clearer that the statusbar's ratio mode button is a button
2009-05-14 18:34:44 +00:00
039c5a0a29
(trunk gtk) swap statusbar ul & dl as suggested by Rolcol
2009-05-02 13:53:49 +00:00
4973d95cd3
(trunk gtk) #2019 : HiG: "When there is no interesting status to report, leave a status bar panel blank"
2009-05-01 19:39:34 +00:00
05db7dd246
(gtk) fix new filtering bug in gtk client
2009-04-25 15:41:10 +00:00
10478de20b
(trunk gtk) clean up yesterday's option menu code a bit
2009-04-15 15:10:22 +00:00
abc59ddf6c
(trunk gtk) #1522 : Lack of fast bw limit settings and display
2009-04-15 04:28:04 +00:00
245108e7ec
(trunk gtk) remember filtering mode between sessions
2009-04-10 04:22:57 +00:00
f6672e8911
(trunk qt,gtk) include torrents-being-verified in the "active torrents" filter.
2009-04-09 22:42:55 +00:00
391e1245ee
(gtk) don't stretch the turtle icon in the prefs dialog.
2009-04-07 04:42:50 +00:00
2290c49898
(trunk) add a did-the-user-do-this flag to the "alt speed toggled" callback
2009-03-30 17:25:35 +00:00
a19910b886
(trunk gtk) maybe stop the turtle from stretching?
2009-03-29 02:10:55 +00:00
f1d92708e7
(trunk) more speedlimit work
2009-03-28 16:47:01 +00:00
4b7a1ca61d
(trunk gtk) #1886 : faster main window renderering in gtk client
2009-03-02 23:29:14 +00:00
25550f03e4
(trunk gtk) #996 : make status location configurable; default to bottom of window as per Gnome HiG
2008-12-25 16:17:08 +00:00
2c88e0b3d1
(trunk gtk) #1447 : Launchpad translations need comment for strings with non-standard context
2008-12-22 05:47:05 +00:00
8d459f06b9
(gtk) undo r7271 damage: I checked in an extra file I didn't intend to.
2008-12-04 17:05:34 +00:00
a0943ae56f
(gtk) #1560 : tr_strlsize() type conflict
2008-12-04 17:02:37 +00:00
2213b42203
(gtk) #1544 : case insensitivity search does not work with non-ascii alphabets
2008-12-03 15:59:53 +00:00
8b69cacc99
(gtk) I hate, hate, hate having the speed display at the bottom.
2008-11-17 01:22:48 +00:00
57b2ad5a28
(gtk) #996 : the Gnome HIG requires the statusbar to be at the bottom of the main window.
2008-11-16 07:26:35 +00:00
5b96ba110c
(gtk) #1453 : follow Gnome HIG; the "details" dialog should be a "properties" dialog
2008-11-13 04:10:04 +00:00
42fe27c067
more fucking around with the speed measurements.
2008-11-08 02:49:04 +00:00
d698ff7510
(gtk) don't use code marked as deprecated in gtk 2.14
2008-10-31 18:25:21 +00:00
91ac2ec337
janitorial: tr_handle -> tr_session
2008-10-28 19:49:33 +00:00
0c4f300f1b
#1369 : clarify the different torrent status & callbacks' APIs and typenames
2008-10-20 17:54:56 +00:00
ee635d9af5
(gtk) #1314 : gtk client crashes sometimes when updating the tooltip for the "Ask Tracker for More Peers" button
2008-10-02 02:13:26 +00:00
4bf3577fba
(gtk) #1306 : clicking in a blank area in a list clears the selection.
2008-09-27 18:01:31 +00:00
cc89872dd4
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
839cfe9155
(gtk) #1193 : add a shadow to the torrent list
2008-08-16 06:17:42 +00:00
51aff87443
lots of C correctness tweaks suggested by sparse/cgcc
2008-08-11 19:05:02 +00:00
bb6b471e8b
fix some minor errors reported by clang's "scan-build" tool
2008-07-18 18:14:29 +00:00
effb78d674
unify the daemon and gtk client's config files so that you can easily swap back and forth between clients and keep the same torrents and preferences.
2008-06-12 16:25:36 +00:00
468a883f23
API cleanup: s/tr_torrentRates/tr_sessionGetSpeed/
2008-05-30 15:19:07 +00:00
26b5a16630
(libt) more janitorial work on cleaning up tr_session*() and tr_torrent*() functions: session stats, torrent count, and manual update.
2008-05-22 20:44:41 +00:00
7ef2511ca8
#377 : preliminary https support. this commit probably breaks mac and cli and is not for the faint of heart.
2008-04-24 01:42:53 +00:00
29b0b33663
(gtk) remember window size & location between sessions
2008-04-21 20:58:39 +00:00
85c57c00cb
(gtk) avoid a tr_torrentStat() call when filtering by all, downloading, seeding, or paused
2008-04-01 11:53:50 +00:00
51a82e70c1
remove `TR_STATUS_DONE' from libtransmission's public API. It's useful as an internal state but not for code calling libtransmission.
2008-03-31 17:59:16 +00:00
c63b548195
fix bug that caused very large torrents to crash Transmission
2008-03-22 18:10:59 +00:00
531dd851ad
more string work before the freeze. (1) use %'d to get thousands' grouping in end-user strings (2) follow HiG capitalization, quotation guidelines (3) fold a few more strings
2008-03-19 20:07:27 +00:00
1268a06337
(gtk) minor HIG: use "Toolbar" and "Statusbar" instead of "Tool Bar" and "Status Bar"
2008-03-19 19:30:03 +00:00
Jordan Lee