Charles Kerr
ed897f93f2
refactor: remove evbuffer_free_to_str() ( #2967 )
2022-04-22 13:05:49 -05:00
Charles Kerr
32facb50d7
refactor: prefer tr_pathbuf over tr_strvPath() ( #2966 )
2022-04-22 11:35:56 -05:00
Charles Kerr
7918113e0b
refactor: partially c++ifiy tr_rpc_server ( #2965 )
...
Replace the older C-style API methods to be class methods.
2022-04-22 09:19:20 -05:00
Charles Kerr
3643a8aee5
refactor: prefer std::vector as the default container ( #2964 )
2022-04-22 08:08:02 -05:00
goldsteinn
f823df364e
Refactor: use popcnt in bitfield and cleanup warnings ( #2950 )
...
Co-authored-by: Noah Goldstein <goldstein.w.n@gmail.com>
2022-04-22 06:54:35 -05:00
Charles Kerr
4d7d35ad57
fix: heap-buffer-overflow in variant-json ( #2963 )
...
Fixes #2953 .
2022-04-22 01:28:02 -05:00
Charles Kerr
41cb8cbc91
refactor: add tr_address.readable ( #2962 )
2022-04-21 18:37:02 -05:00
Charles Kerr
a25da4f376
refactor: add tr_address::fromCompact() ( #2961 )
2022-04-21 17:06:00 -05:00
Charles Kerr
a52edbcbbe
refactor: remove tr_announce_list.tiers ( #2960 )
2022-04-21 15:48:30 -05:00
Charles Kerr
68a43c1684
fix: when loading resume state, load filenames before mtimes ( #2958 )
2022-04-21 12:07:09 -05:00
Charles Kerr
32f854a7cf
refactor: add a tr_port safety class ( #2952 )
2022-04-21 10:58:13 -05:00
Antoine Cœur
bdac708762
docs: fix various typos and misspellings ( #2955 )
2022-04-21 09:28:38 -05:00
Charles Kerr
0eb1857c6c
build: re-enable cert str34 c clang tidy ( #2946 )
...
* build: add clang-analyzer-deadcode.* to clang-tidy
* build: do not disable cert-str34-c checks in libtransmission
2022-04-19 09:51:25 -05:00
Charles Kerr
345b71ffda
refactor: use std::vector for tr_torrents.removed_ ( #2943 )
2022-04-18 14:24:20 -05:00
Antoine Cœur
9c0038ac8e
Pause magnet download when "Start when added" is unchecked ( #2902 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-04-18 01:03:44 -05:00
Charles Kerr
18da7eb125
refactor: use std::vector<tr_quark> for torrent labels ( #2942 )
2022-04-18 00:53:48 -05:00
Charles Kerr
3a8cac3914
fix: uninintialized field tr_torrent_files.total_size_ ( #2941 )
2022-04-17 23:21:18 -05:00
Charles Kerr
af49e0f1af
fix: do not load magnet file resume files ( #2940 )
2022-04-17 21:55:20 -05:00
Luukas Pörtfors
1f17ab64be
remote: Implement rename command ( #2905 )
...
* remote: Implement rename command
* use tr_strlcpy
2022-04-17 20:52:58 -05:00
Charles Kerr
fc2f6e9725
refactor: make tr_peerMgr.webseeds a std::vector ( #2937 )
2022-04-17 17:29:06 -05:00
goldsteinn
9c84e85432
Refactor: Cleanup misc inefficiencies throughout the file ( #2933 )
...
Co-authored-by: Noah Goldstein <goldstein.w.n@gmail.com>
2022-04-17 10:54:38 -05:00
Charles Kerr
c1faebca6e
fix: new MSVC warning in file-piece-map-test.cc ( #2936 )
2022-04-16 23:36:05 -05:00
Charles Kerr
3ec7e1933e
build: try clang-format-12 in code_style ( #2935 )
2022-04-16 22:23:20 -05:00
Charles Kerr
d765b7ee3b
build: pass cmake compiler values to submodules ( #2934 )
...
This is needed for consistent building when using compiler-specific
tooling such as address sanitizer flags.
2022-04-16 21:17:28 -05:00
Charles Kerr
6cdc7e3828
refactor: remove tr_announce_list::tracker info.announce ( #2931 )
2022-04-16 15:41:51 -05:00
Charles Kerr
ef4fcf7ffd
refactor: remove tr_announce_list.tracker_info.scrape ( #2930 )
2022-04-16 14:14:18 -05:00
Charles Kerr
2f97655981
refactor: remove tr_url_parsed_t.portstr ( #2929 )
2022-04-16 13:13:42 -05:00
Charles Kerr
4a2a6b2985
test: use uniform naming scheme for fuzz tests. ( #2928 )
...
Use case: libtransmission-test --gtest_filter='*Fuzz' --gtest_repeat N
2022-04-16 11:47:51 -05:00
Charles Kerr
881860ac6f
refactor: remove tr_torrent.magicNumber ( #2927 )
2022-04-16 10:48:51 -05:00
Antoine Cœur
bafb8d6495
Trim spaces when using cmd+u sheet ( #2915 )
2022-04-15 23:02:25 -05:00
Charles Kerr
f4bb09428b
fixup: more libfmt usage regressions ( #2924 )
2022-04-15 19:56:16 -05:00
Charles Kerr
2866638e1b
refactor: add tr_torrent_files::move() and remove() ( #2919 )
2022-04-15 18:39:04 -05:00
Antoine Cœur
4590d172de
meta info piece_size should be maximum UINT32_MAX ( #2914 )
2022-04-15 00:38:59 -05:00
Antoine Cœur
6266533546
Addressing read links in the Xcode project ( #2903 )
2022-04-14 09:24:10 -05:00
Charles Kerr
5b6f0a52fd
fixup: minor log string formatting changes ( #2913 )
...
* fixup! fix: sonarcloud (#2865 )
fix: log time format string
* fix: formatting changes
* fixup! refactor: remove tr_strvJoin() (#2896 )
fix: daemon logging
Co-authored-by: Catadropa <catadropa@users.noreply.github.com>
2022-04-13 23:19:18 -05:00
Charles Kerr
ec57d10954
refactor: tr_files::hasAnyLocalData() ( #2911 )
2022-04-13 21:41:06 -05:00
Charles Kerr
9f9f60f1e3
refactor: tr_block_info ( #2908 )
2022-04-13 20:22:59 -05:00
Charles Kerr
4a65956cc9
refactor: extract some file management into tr_files class ( #2906 )
2022-04-12 10:00:02 -05:00
Charles Kerr
8c51c48472
fix: recent FTBFS in msvc ( #2907 )
...
* fix: recent FTBFS in msvc
It's happening a line in qt/WatchDir.cc where an enum named `ERROR` is
declared, so it's probably conflicting with a new `ERROR` name in some
header file. Rename ours and make at an `enum class` for good measure.
* build: fix cmake msvc warning
D9025 : overriding /W3 with /W4
2022-04-12 01:56:09 -05:00
maxz
7c76d40a4d
Improve the documentation ( #2900 )
...
* Unify the line endings to the Unix style (LF only).
* Fix (where possible) or remove broken links.
* Improve the documentation.
Fix or remove broken links (depending on whether I could find a
working version of the resource).
Change all links to use HTTPS instead of HTTP.
Unify the capitalizations (e.g. uppercase abbreviations, capitalize
proper names and downcase other words).
Fix or improve some parts of the text, clarifying what is meant.
Improve some parts of the program examples (e.g. only use root
privileges where really required).
2022-04-11 12:38:32 -05:00
Charles Kerr
70fbce71ec
refactor: convert watchdir to C++ ( #2899 )
...
* refactor: use new/delete instead of malloc/free
* refactor: use std::string instead of raw c strings
2022-04-09 09:58:02 -05:00
Charles Kerr
205abbbcce
refactor: iwyu string, vector, cstdint ( #2898 )
...
* refactor: use cstdint for intX_t types
* refactor: iwyu sstring_view
* refactor: iwyu <cstring>
* refactor: iwyu <vector>
2022-04-07 20:50:26 -05:00
Charles Kerr
b256da02e3
refactor: remove unused macros ( #2897 )
...
* refactor: remove unused fu nction tr_lowerBound()
* refactor: tr_timerAdd() takes a reference, not a pointer
* refactor: tr_timerAddMsec() takes a reference, not a pointer
* refactor: tr_moveFile() takes a reference, not a pointer
* refactor: tr_wildmat() takes std::string_views
* refactor: remove unused macro TR_GNUC_NONNULL
* refactor: remove unused macro TR_GNUC_PRINTF
* refactor: remove unused macro TR_GNUC_NULL_TERMINATED
* refactor: remove unused macro TR_GNUC_HOT
* refactor: remove unused macro __has_feature
* refactor: remove unused macro __has_attribute
* refactor: remove unused macro TR_DEPRECATED
* refactor: remove unused macro TR_DISABLE_COPY_MOVE
2022-04-07 19:20:29 -05:00
Charles Kerr
31c65eec1f
refactor: remove tr_strvJoin() ( #2896 )
2022-04-07 17:26:59 -05:00
Charles Kerr
ffda5bb68a
refactor: remove tr_strip_positional_args() ( #2881 )
...
* refactor: use fmt in gtk/SystemIconTray
* refactor: use fmt in gtk/MakeDialog
* refactor: remove unused tr_strip_positional_args()
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-04-07 08:23:04 -05:00
maxz
8d11f0bc22
Fix typographical errors in the documentation. ( #2889 )
2022-04-06 17:20:38 -05:00
Charles Kerr
f79a75cb21
test: fuzz test tr_variantFromBuf() ( #2892 )
...
* test: fuzz test tr_torrent_metainfo.parseBenc()
* fix: better error-checking in benc string parsing
* fix: return benc failure if the parse stack is unbalanced
* fix: stack range error when logging json parse errors
* test: fuzz test tr_variantFromBuf()
2022-04-06 16:39:39 -05:00
Charles Kerr
a134445caa
test: fuzz test tr_torrent_metainfo.parseBenc() ( #2891 )
...
* test: fuzz test tr_urlParse()
* fix: stack error checking in benc parser
* test: fuzz test tr_torrent_metainfo.parseBenc()
2022-04-06 15:26:13 -05:00
Charles Kerr
e88ebbc3e5
test: fuzz test tr_magnet_metainfo.parseMagnet() ( #2890 )
2022-04-06 13:22:08 -05:00
Charles Kerr
eb33b2faf5
fix: tr_clientForId() ( #2887 )
...
* fix: memory corruption when parsing negative numbers
* fix: stack-buffer-overflow on escape chars in tr_clientForId
* test: add tr_clientForId() fuzz tests
2022-04-06 12:06:11 -05:00
