fbd8d4c79f
Fix a number of other style inconsistencies met along the way
2017-04-30 19:33:55 +03:00
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
727b9671f7
Update all website links to canonical HTTPS version.
2016-10-31 10:00:11 +01:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
88983c1ac1
Use tr_sys_path_remove instead of remove
2015-10-23 04:09:40 +00:00
cdf3cf62f9
Fix some issues revealed by coverity
2015-05-09 11:56:35 +00:00
2321bc3fad
Fix some issues revealed by coverity
2015-05-09 08:37:55 +00:00
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
4904b923fb
(trunk) restore copyright year as suggested in email by rms
2014-01-18 20:56:57 +00:00
28fe36f1f8
#include limits.h where we use it, and don't where we don't
2013-08-24 17:53:45 +00:00
16ab373503
(trunk gtk) #5320 'can't opena folder with '#' in its name': in gtr_open_file(), use g_file_new_for_path().
2013-07-24 17:11:21 +00:00
cc1b1cd430
since Transmission supports older versions of glib, add a portability wrapper for G_DEFINE_QUARK
2013-07-24 00:13:31 +00:00
6a47b4a5d3
don't use a '-' character in the QN argument to G_DEFINE_QUARK. https://forum.transmissionbt.com/viewtopic.php?p=65548#p65548
2013-07-22 23:00:10 +00:00
d244545979
use G_DEFINE_QUARK instead of rolling our own quark getters
2013-07-09 22:44:24 +00:00
027e3f3066
(trunk, libT) #4682 'Add return id from duplicate torrent torrent-add rpc' -- added.
2013-05-22 20:35:38 +00:00
d1571bda02
(gtk) use replace strcmp() with g_strcmp0() everywhere
2013-02-14 15:17:42 +00:00
cd09204a6e
(trunk) first draft of changing the FreeSpace API to behave as https://trac.transmissionbt.com/ticket/4076#comment:25 -- libT, rpc, qt, and gtk implementations.
2013-02-09 04:05:03 +00:00
445609f690
(trunk) prefer tr_remove() to unlink() or rmdir()
2013-02-04 21:53:19 +00:00
20fe66bccf
more experimentation with the shortTransferString
2013-01-30 00:22:52 +00:00
10b96f0f12
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
6755e4e24f
(trunk, gtk) #5089 'Open-by-URL doesn't automatically paste URLs/magnet links from the clipboard if they contain leading whitespace' -- fixed.
2012-10-13 16:47:26 +00:00
b8ef3a9acd
(trunk, gtk) #5088 'gtr_is_supported_url(), gtr_is_magnet_link() aren't NULL-safe' -- fixed.
2012-10-13 16:45:20 +00:00
33c4d25f19
fix a handful of console warnings that were generated by trying to trash a NULL .torrent file b/c the torrent had been added from a URL
2012-09-23 15:38:07 +00:00
cdd71c6427
(trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2
2012-07-14 19:26:55 +00:00
fbc7f3dc3c
(trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
...
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)
Flame away.
2012-02-03 21:21:52 +00:00
7e83c406d4
(trunk gtk) fix a minor memory leak in gtr_open_file(). reported by clang static analyzer.
2012-01-24 18:09:12 +00:00
76cf0520ba
(trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fix About dialog issue when hiding and then re-showing Transmission.
2011-10-13 00:36:19 +00:00
f9388714b7
(trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2
2011-10-11 04:11:08 +00:00
a7a9c2b12e
(trunk gtk) #4399 "Add option to disable 'trash can' feature" -- done.
2011-08-13 22:58:49 +00:00
38a1df9344
(trunk gtk) remove some unnecessary #includes
2011-08-13 14:19:40 +00:00
4d4eeae682
(trunk gtk) first cut at using GApplication. This lets glib replace hundreds of lines of homegrown code. Whee!
2011-08-09 02:30:31 +00:00
8d89a16f4f
remove the gtr_idle_add() portability wrapper around gdk_threads_add_idle() -- it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:10:55 +00:00
6d1869c33b
remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:06:46 +00:00
0e48418f26
(trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010).
2011-08-07 18:41:13 +00:00
270126820a
(trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency
2011-08-07 16:42:38 +00:00
9448bc5e88
(trunk gtk) #1477 "Launchpad translations need comment for strings with non-standard context" -- apply patch from okram.
2011-07-26 01:09:39 +00:00
45bdc18210
(trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761
2011-05-02 17:58:27 +00:00
b93bef2712
(trunk gtk) gtr_get_host_from_url(): avoid a couple of malloc() + free() calls.
2011-04-28 18:37:27 +00:00
d233ea82e7
(trunk gtk) more heap pruning: avoid unnecessary malloc() + free() calls in gtr_get_host_from_url()
2011-04-04 16:54:09 +00:00
bd88521332
(trunk) yet more "#include" tweaks
2011-03-25 15:03:42 +00:00
4a1a4ebcc0
(trunk gtk) gtk_open_uri(): use gtk_show_uri() as the default implementation for GTK+ > 2.14.0.
...
gtk_show_uri() was added in 2.14.0
2011-03-25 06:40:46 +00:00
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
433da8df9a
(trunk gtk) gtr_compare_double() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-24 18:32:05 +00:00
Mike Gelfand