Commit Graph

12995 Commits

Author SHA1 Message Date
Mike Gelfand fbd8d4c79f Fix a number of other style inconsistencies met along the way 2017-04-30 19:33:55 +03:00
Mike Gelfand a762c770f2 Make conditional expressions explicitly boolean 2017-04-30 19:26:01 +03:00
Mike Gelfand 6da99c05e2 Use nullptr consistencty instead of 0 and NULL (Qt client) 2017-04-30 19:26:01 +03:00
Mike Gelfand 7bfd7f5863 Avoid declaring variables inside conditional expressions (Qt client) 2017-04-30 19:25:57 +03:00
Mike Gelfand 6a15bc6742 Fix mount points enumeration (platform quota) on Solaris
Per documentation, `getmntent` returns 0 on success and -1 on error.
2017-04-22 21:42:44 +03:00
Mike Gelfand 4f9d9ad92b Code style change leftovers
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand dadffa2c0f Align type qualifiers to the right (code style)
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand d7930984ef Adjust uncrustify config, reformat all but Mac client
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand fdfbe225da Merge pull request #215 from transmission/fix-xenial-glib-error
Work around "error: m4_copy: won't overwrite defined macro: glib_DEFUN"
2017-03-12 12:05:37 +03:00
Eric Petit 860d9e977d Work around "error: m4_copy: won't overwrite defined macro: glib_DEFUN" on
Xenial, copied from https://github.com/Alexpux/MINGW-packages/issues/1351
2017-03-12 06:20:14 +01:00
Mike Gelfand e4ee96c30d Fail installation on Windows if UCRT is not installed 2017-02-25 10:07:58 +03:00
Mike Gelfand 8fce4173dc Fix CMake check for missing crypto backend
Fixes: #191
2017-02-23 23:18:45 +03:00
Mike Gelfand 0f75e64d71 Detach the thread from within itself to avoid race condition
Fixes: #188
2017-02-23 00:07:39 +03:00
Mike Gelfand d5d9b61212 Merge branch 'gh37-update-icon-on-rename'
Fixes: #37
2017-02-22 00:00:07 +03:00
Mike Gelfand 63b6c11602 Update file icon when its name changes (Mac client) 2017-02-21 23:52:41 +03:00
Mike Gelfand ecd1eb7914 Update file icon when its name changes in details dialog (GTK+ client)
Additionally, make main window redraw the torrent so that new name and icon
are visible right away.
2017-02-21 23:21:25 +03:00
Mike Gelfand a26b4ec7bf Merge pull request #184 from neheb/patch-1
Add TCP_FASTOPEN support
2017-02-19 14:53:51 +03:00
neheb 944382a62e Add TCP_FASTOPEN support
Should make transmission slightly faster.
2017-02-19 12:54:01 +03:00
Mike Gelfand c77946e49a Set icon for "Open URL" action (Qt client) 2017-02-18 21:22:34 +03:00
Mike Gelfand bbc0d8c5e4 Merge pull request #180 from lisenenkov/master
Update inspector.js
2017-02-12 18:45:27 +03:00
lisenenkov b4068e39f0 Merge branch 'master' into master 2017-02-12 18:44:06 +03:00
lisenenkov 076535e3d3 Update inspector.js
https info not showed
2017-02-12 18:41:50 +03:00
Mike Gelfand c6bfe9de15 Use QtWinExtras instead of importing private Qt function to get QPixmap from HICON 2017-02-11 20:48:13 +03:00
Mike Gelfand 4b397ebfc0 Switch from deprecated QStyleOptionViewItemV* to QStyleOptionViewItem 2017-02-11 14:04:26 +03:00
Mike Gelfand 03034b5015 Remove supporting code for Qt < 5.2 2017-02-11 13:44:34 +03:00
Mike Gelfand 8dc6fb48b1 Bump minimum required Qt version to 5.2 2017-02-11 13:24:42 +03:00
Mike Gelfand caf3b7653c Improve Qt client look on hi-dpi displays 2017-02-08 01:06:28 +03:00
Mike Gelfand 13e111a89a Use default (instead of system) locale to be more flexible (Qt client) 2017-02-07 02:24:47 +03:00
Mike Gelfand 6c9fa2913b Use alternative method of loading translations (Qt client)
Fixes: #130
2017-02-07 00:58:51 +03:00
Mike Gelfand 5e18ddbca8 Remove NSApp isOnMountainLionOrBetter helper 2017-02-05 22:29:20 +03:00
Mike Gelfand fa504fb27f Bump Mac client deployment target to 10.9, fix deprecation errors 2017-02-05 18:41:47 +03:00
Mike Gelfand 788f1e31f1 Update Xcode project format to 8.0 2017-02-05 11:52:39 +03:00
Mike Gelfand dcc9a4308b Fix up creation of third-party include directories symlinks 2017-02-05 10:23:23 +03:00
Mike Gelfand 3aa25a6d80 Merge pull request #169 from slokhorst/patch-2
Correct name of qt client in desktop file
2017-02-04 21:49:08 +03:00
Sebastiaan Lokhorst 532246778b Correct Qt client desktop file name and add keywords 2017-02-04 15:03:49 +01:00
Mike Gelfand 1f6b7df401 Merge pull request #162 from piotrdrag/desktop-gtk
Modernize the .desktop file a bit
2017-02-03 02:30:45 +03:00
Mike Gelfand 6c17c400bf Merge pull request #168 from EdwardBetts/patch-1
fix spelling mistake
2017-02-01 13:38:25 +03:00
Edward Betts 9e1c76a50f fix spelling mistake 2017-02-01 10:14:11 +00:00
Piotr Drąg 297c734c0b Add Keywords to the .desktop file
It's a part of the Desktop Entry Specification [1] and it's used by,
among others, the search system in GNOME 3.

The comment is there to hopefully minimize the chance of translators
making a mistake that could potentially break build.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
2017-01-29 01:13:53 +01:00
Piotr Drąg 5cefddeaee Remove X-GNOME-FullName from the .desktop file
It's a GNOME-specific hack for the 2.x era menu system that was never
standardized in [1] and is now unused in GNOME 3.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
2017-01-28 23:52:32 +01:00
Mike Gelfand ab7ea2c5fd Downsync Mac QuickLook plugin translations from Transifex as well 2017-01-28 15:02:40 +03:00
Mike Gelfand 4ddaa58287 Fix closing </i> in translatable phrase (Qt client) 2017-01-28 13:51:03 +03:00
Mike Gelfand ff062b875c Add Mac client translations to and downsync from Transifex 2017-01-28 13:44:15 +03:00
Mike Gelfand 565fc67c85 Merge branch 'sync-translations'
Fixes: #25
Fixes: #100
2017-01-27 05:01:41 +03:00
Mike Gelfand 95ee9b9419 Sync .po files with Transifex and current source code
This required some editing re. number of plural forms. Not exactly sure why
Kazakh still has one plural form there (contacted them for clarification).
Also, Manx (gv), Shan (shn), and Central Kurdish (ckb) languages aren't
supported by Transifex at the moment (contacted as well)...

Remove Belarusian (be@latin) as it was no longer present on Launchpad.
Add Welsh (cy).
2017-01-27 04:50:14 +03:00
Mike Gelfand d40d69702b Sync .ts files with Transifex and current source code
Add 4 new languages: Georgian, Dutch, Swedish, and Turkish (Turkey).
2017-01-27 04:50:14 +03:00
Mike Gelfand 1cc67b31dd Use PRIdMAX instead of TR_PRI_SOCK to accomodate intltool 2017-01-27 04:50:14 +03:00
Mike Gelfand 4160743738 Convert tabs to spaces, remove trailing whitespace (Mac client) 2017-01-24 20:53:16 +03:00
Mike Gelfand cd4b0dc69d Pass CMAKE_USER_MAKE_RULES_OVERRIDE on to third-party dependencies 2017-01-22 14:16:51 +03:00
Mike Gelfand c199eef8ae When building with Xcode, link against 'libcrypto.dylib' instead of 'libcrypto.0.9.8.dylib'
Fix up 'miniupnpc' directory name along the way, using missing 'miniupnp'
was failing the build.

Fixes: #71
2017-01-18 21:56:02 +03:00