Ștefan Talpalaru
b0eaec47cd
fix: re-enable port forwarding ( #4343 )
2022-12-14 01:31:48 -06:00
Charles Kerr
6f1153cae4
refactor: tr_handshake ( #4362 )
2022-12-13 19:58:39 -06:00
Cœur
4a80f800a6
Fixed crash on exit in tr_utpPacket ( #4348 )
2022-12-13 16:51:54 -06:00
Charles Kerr
2f6315b649
refactor: tr_handshake lifecycle ( #4358 )
2022-12-13 11:59:21 -06:00
Cœur
9e0b42a61d
Fixed logic in tr_wildmat ( #4353 )
2022-12-12 16:35:40 -06:00
Cœur
7814e0736e
Fixed tr_bitfield::operator|= range ( #4351 )
2022-12-12 02:23:59 +00:00
Charles Kerr
5bd4f007ac
fix: remove invalid assertion from bitfield code ( #4346 )
2022-12-10 14:54:22 -06:00
Charles Kerr
0a69685a4e
refactor: tr_address cleanup ( #4338 )
...
* refactor: move tr_tracker_http_announce() helper funcs into their own namespace
* refactor: move tr_globalIPv6() helper funcs into their own namespace
* refactor: move tr_address_is_valid_for_peers() helper funcs into their own namespace
* refactor: make tr_address_compare() a private method
* refactor: rename tr_address::isIPv4() to is_ipv4()
* refactor: use snake_case for tr_address methods
* refactor: make tr_address_is_valid_for_peers() a member function
2022-12-08 20:27:52 -06:00
Charles Kerr
0061e4f9a9
refactor: tr_address::display_name() ( #4335 )
2022-12-08 16:44:19 -06:00
Charles Kerr
f176bb299a
fix: broken detection of peer udp port ( #4334 )
2022-12-08 14:44:39 -06:00
Charles Kerr
e06e304cc8
refactor: fix shutdown order of utp ( #4331 )
2022-12-06 14:28:48 -06:00
Charles Kerr
22a3a5db25
refactor: peer-socket pt 2 ( #4326 )
...
* refactor: tr_netOpenPeerSocket() now takes a tr_address reference
* refactor: disable copy assignment, copy constructor
* refactor: move log statements to peer_socket constructor
2022-12-06 10:28:28 -06:00
Charles Kerr
9a5d9a0ba2
refactor: tr_peer_socket ( #4325 )
...
* refactor: make tr_peer_socket.type private
* refactor: reimplement tr_peerIo::address() as a wrapper around tr_peer_socket::address()
* refactor: remove tr_address, tr_port from tr_peerIo
* refactor: replace tr_netClosePeerSocket() with tr_peer_socket::close()
2022-12-05 18:53:31 -06:00
Charles Kerr
468310300c
refactor: only need a single handshake mediator ( #4322 )
2022-12-05 11:47:11 -06:00
Charles Kerr
728e5b8350
refactor: stop tracking peerIo creation time ( #4300 )
2022-12-02 10:39:46 -06:00
Dmitry Antipov
bf6c80ae35
refactor, ci: switch clang-format to LLVM 15 ( #4297 )
...
Bump required clang-format version to 15
2022-12-02 09:57:50 -06:00
A Cœur
a656b3b8c9
fix: tr_rand_int modulo bias and fixed tr_rand_int for values larger than INT_MAX. ( #4235 )
2022-11-30 22:58:14 -06:00
Charles Kerr
a7261526ac
fix: shut down utp sooner during session shutdown ( #4287 )
2022-11-30 16:35:10 -06:00
A Cœur
e038121857
refactor: second log of UTP errors as 'trace' messages ( #4283 )
2022-11-30 14:06:08 -06:00
Charles Kerr
f03fc9270b
Fix/long shutdown crash on shutdown ( #4285 )
2022-11-30 13:00:34 -06:00
Charles Kerr
595d0ac14a
refactor: add tr_announcer.startShutdown() ( #4280 )
2022-11-29 21:05:11 -06:00
Charles Kerr
eeaefca6f3
refactor: UDP and TCP announces use same timeout interval ( #4279 )
...
* refactor: move announce, scrape timeout intervals into announcer-common.h
* refactor: udp and http announces, scrapes use same timeout vals
2022-11-29 19:38:53 -06:00
Charles Kerr
22d12aedc5
refactor: GTK favicon lookup improvements ( #4278 )
2022-11-29 18:09:32 -06:00
Charles Kerr
8900a1646e
refactor: do not report peer EOF as an error ( #4275 )
2022-11-29 10:48:20 -06:00
Charles Kerr
59335eac03
fix: sonarcloud cpp:S6004 ( #4270 )
...
reduce scope of variables by using if-based initializer
2022-11-28 21:03:28 -06:00
Charles Kerr
4adda4dc1e
fix: sonarcloud cpp:S6005 ( #4268 )
2022-11-28 18:26:03 -06:00
Charles Kerr
af9f1b4e42
fix: potentially incorrect error message in rpc-server whitelist ( #4264 )
...
Fixes #928 .
2022-11-28 15:46:30 -06:00
Charles Kerr
f27c5fa0fa
refactor: make some local pointer vars pointer-to-const ( #4262 )
2022-11-28 09:45:39 -06:00
Charles Kerr
14dfafde32
refactor: add std::unique_ptr<evhttp> handler to utils-ev ( #4261 )
2022-11-28 08:07:04 -06:00
Charles Kerr
0ee93068bb
fix: TR_TORRENT_LABELS env var in scripts ( #4260 )
2022-11-27 21:59:45 -06:00
Charles Kerr
0efb96124b
perf: remove cpu bottleneck in tr_peerIo::write() ( #4258 )
2022-11-27 20:46:03 -06:00
Charles Kerr
49393daf01
refactor: use std::optional.value_or() ( #4255 )
2022-11-27 14:56:34 -06:00
Charles Kerr
33c1098ea0
refactor: reduce scope of TR_NATIVE_EOL_STR, TR_NATIVE_EOL_STR_SIZE ( #4254 )
2022-11-27 12:11:25 -06:00
Charles Kerr
3dd5cb439d
chore: updsate mime-types ( #4246 )
...
just running mime-types.js
2022-11-26 09:03:39 -06:00
Charles Kerr
ec6cb67c5c
fix GTK client message log window does not restore level selection ( #4242 )
...
* fix: save log level, encryption mod, preallocation mode as ints
* fix: ensure log level is saved in tr_sessionGetSettings()
* fix: ensure the right verbosity row is selected
2022-11-26 07:32:51 -06:00
Charles Kerr
feeea2649e
refactor: make tr_announcer.key a uint32_t ( #4241 )
2022-11-25 19:11:55 -06:00
Charles Kerr
8a35aa0903
refactor: add tr_rand_obj() ( #4238 )
...
* refactor: add tr_rand_obj()
There are a lot of places in the codebase where we need to populate
an integral type or a fixed-size array with random data. To do this,
we instantiate a local on the stack, fill it with tr_rand_buffer(),
and then use it.
This PR creates a helper function to make this a one-liner.
2022-11-25 15:04:37 -06:00
A Cœur
342484d14a
refactor: log UTP_ETIMEDOUT errors to 'trace' messages ( #4237 )
2022-11-25 14:44:49 -06:00
Charles Kerr
554ba06ae2
fix: coverity warnings, sonarcloud code smells ( #4232 )
2022-11-24 10:17:02 -06:00
Charles Kerr
19bc15523f
fix: new sonarcloud, coverity, gcc warnings ( #4229 )
2022-11-23 13:47:04 -06:00
Charles Kerr
046ba32d33
fixup: heap-use-after-free in announce, scrape response on shutdown ( #4228 )
...
fixes #4222 .
2022-11-23 01:38:31 -06:00
Charles Kerr
a8f2b840f7
perf: improve tr_peerMgrGetDesiredAvailable() ( #4226 )
2022-11-22 23:26:10 -06:00
Charles Kerr
40c7f5bceb
perf: constexpr and move work outside of loops ( #4224 )
2022-11-22 14:00:09 -06:00
Charles Kerr
43c57fb02a
perf: buffer iterators ( #4220 )
2022-11-21 23:54:28 -06:00
Charles Kerr
a3772dc1fa
refactor: aggregate dh in peer io ( #4218 )
2022-11-21 18:08:06 -06:00
A Cœur
d26db72d7e
Fix "Implicit conversion loses integer precision" ( #4194 )
2022-11-21 10:19:45 -06:00
Charles Kerr
76bea25f6e
perf: minor perf wins ( #4216 )
...
* perf: faster tr_buffer::toString()
* perf: faster tr_buffer::Iterator
* perf: get mutex lock in reconnectPulse() instead of closeBadPeers()
2022-11-21 09:28:46 -06:00
Herman Semenov
ffd5e6bf50
refactor: remove unused vars, code simplify and minor optimize ( #4172 )
2022-11-19 09:46:03 -06:00
Charles Kerr
d27c4c59ce
refactor: incremental announcer refactor pt. 2 ( #4214 )
2022-11-18 23:00:25 -06:00
A Cœur
a187529f93
typo ICP -> TCP ( #4213 )
2022-11-18 21:53:16 -06:00