This puts Vorta on PyQt6 and starts a new main branch 0.9.
---------
Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com>
Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com>
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
Use one size unit for all archives. The unit is selected by a simple algorithm that picks the largest unit that can represent the smallest size with a given precision. Align all sizes in archive and source tab to the left.
* src/vorta/utils.py : Implement `find_best_size_formatting`. Add missing sizes to `sort_sizes`. Simplify `pretty_bytes` and add `fixed_unit` option for use with `find_best_size_formatting`. Implement `clamp` utility function. Add type hints and docstrings.
* src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Use `find_best_sizes_formatting`.
* src/vorta/views/source_tab.py (SizeItem.__init__): Set alignment to left.
* tests/test_utils.py : Add comprehensive tests for `pretty_bytes` and `find_best_sizes_formatting`.
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
* src/vorta/views/archive_tab.py : Move all command building logic into `mount.py`.
* src/vorta/borg/mount.py (BorgMountJob.prepare): Add command building logic previously in other places.
* src/vorta/borg/mount.py (BorgMountJob.prepare): Use `-a` command line option to select a single archive.
* src/vorta/utils.py (SHELL_PATTERN_ELEMENT): A pattern that can be used to detect shell pattern syntax.
* src/vorta/utils.py (get_mount_points): Implement parsing a borg v2 cmd.
* src/vorta/borg/umount.py (BorgUmountJob.prepare): Add parameters `mount_point` and optional `archive_name`.
Handle them correctly.
* src/vorta/views/archive_tab.py : Remove code that can now be found in `umount.py`.
Translate error messages returned by `BorgUmountJob.prepare`.
Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com>
* src/vorta/views/extract_dialog.py: Add `ParseThread`, `ExtractTree` and `parse_json_lines`.
* src/vorta/views/extract_dialog.py (ExtractTree.__init__): Adjust signature.
* src/vorta/borg/list_archive.py (BorgListArchiveJob.prepare): Adjust format to
include additional attributes.
* src/vorta/views/archive_tab.py (ArchiveTab): Parse extract data using `ParseThread` and
open `ExtractDialog` afterwards.
* tests/test_archives.py (test_archive_extract): Update tests.
* src/vorta/borg/extract.py (BorgExtractJob.prepare): Adjust signature.
Handling of the data isn't implemented yet.
* tests/test_extract.py
* src/vorta/views/archive_tab.py (ArchiveTab.list_diff_result): Start `ParseThread` that does the processing and creates the dialog.
* src/vorta/views/archive_tab.py (ArchiveTab.show_diff_result): Implement method showing `DiffResultDialog`.
* src/vorta/views/diff_result.py (ParseThread): Move processing of diff results to this thread.
* src/vorta/assets/UI/diffresult.ui : Replace `okButton` with `QDialogButtonBox`
that has a `close` button.
* src/vorta/views/diff_result.py : Connect `buttonBox` instead of `okButton` to Dialog.
* src/vorta/assets/UI/diffresult.ui : Add title to `DiffResult` dialog and simplify file name display.
* src/vorta/assets/UI/diffresult.ui : Add comboBox to change display mode of tree view.
* src/vorta/views/diff_result.py : Connect comboBox to `DiffTree`.
* src/vorta/application.py : Remove `eventFilter` setup for palette changes.
* src/vorta/tray_menu.py : Connect directly to `app.paletteChanged`.
* src/vorta/views/archive_tab.py
* src/vorta/views/repo_tab.py
* src/vorta/views/schedule_tab.py
* src/vorta/views/source_tab.py
* src/vorta/assets/UI/diffresult.ui : Add buttons to keep folders on top when sorting and
to expand and collapse all items.
* src/vorta/views/diff_result.py : Connect the added buttons.
* src/vorta/assets/icons/angle-up-solid.svg : Add icon for `bCollapseAll`.
* src/vorta/views/diff_result.py : Add context menu to `treeView` that allows expanding
and copying of an item.
* src/vorta/views/diff_result.py : Add copy shortcut to `treeView`.
Subclass `treemodel.FileTreeModel` for the purposes of the diff dialog.
Rewrite diff output parsing.
Add sorting through `QSortFilterProxyModel`.
* src/vorta/views/diff_result.py (DiffResult.__init__): Remove doubled if statement.
* src/vorta/views/diff_result.py : Rename `DiffResult` to `DiffResultDialog`.
* src/vorta/views/diff_result.py (DiffTree.__init__): Remove the use of `QVariant`.
Since python has no type enforcement `QVariant` is not needed.
* src/vorta/views/diff_result.py (DiffTree): Subclass `treemodel.FileTreeModel` and add additional info tooltip.
* src/vorta/views/diff_result.py (parse_diff_json): Some changes for use with new model.
* src/vorta/views/diff_result.py (parse_diff_lines): Full regex based line parsing and
other modifications to go with the new model.
* src/vorta/views/diff_result.py (FileType): Enum of possible file types.
* src/vorta/views/diff_result.py (ChangeType): Enum of possible change types.
Currently all are mapped to `ADDED`, `MODIFIED` and `REMOVED`.
* src/vorta/views/diff_result.py (calc_size): Rename to `size_to_byte`.
* src/vorta/assets/UI/diffresult.ui : Move `alternatingRowColours` to the .ui file.
* src/vorta/views/diff_result.py (DiffResultDialog): Move `alternatingRowColours` to the .ui file.
* tests/test_diff.py : Fix tests for diff parser.
* src/vorta/views/diff_result.py : Connect to `sorted` of `DiffSortProxyModel`
to reveal selected items in view.
* src/vorta/views/partials/treemodel.py : Add `FileTreeSortProxyModel` with abstract code.
* src/vorta/views/diff_result.py (DiffSortProxyModel): Implement `FileTreeSortProxyModel`.
* src/vorta/views/diff_result.py (DiffItem): This variable holds the type `FileSystemItem[DiffData]`.
* Remove fullstops in the labels of the settings.
* src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting.
* Fix *Add Profile*-Dialog.
* src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`.
* src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms.
* src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog.
* src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal.
* src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode.
* src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`.
* src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`.
* Add colon after entry label in `Add Profile`-Dialog.
* src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label.
* Fix capitalization in schedule tab.
* src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`.
* Fix tooltips.
Ensure sentence capitalization.
Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.)
Remove fullstop from tooltips that aren't a sentence.
Add fullstop to tooltips that are a sentence.
* src/vorta/assets/UI/archivetab.ui
* src/vorta/assets/UI/mainwindow.ui
* src/vorta/assets/UI/repoadd.ui
* src/vorta/assets/UI/repotab.ui
* src/vorta/assets/UI/sourcetab.ui
* src/vorta/views/export_window.py
* src/vorta/views/import_window.py
* src/vorta/views/source_tab.py
* Replace `n't` by `not` in GUI strings.
* src/vorta/application.py
* src/vorta/assets/UI/repotab.ui
* src/vorta/assets/UI/scheduletab.ui
* src/vorta/assets/UI/sshadd.ui
* src/vorta/notifications.py
* src/vorta/views/main_window.py
* src/vorta/views/main_window.py
* src/vorta/views/repo_tab.py
* Shorten unlink button tooltip.
* src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature.
* Fix entry being embedded in label text.
Sentences should not be constructed from text in several controls.
Sentences that run from one control to another will often not make sense when translated into other languages.
* src/vorta/assets/UI/archivetab.ui
* src/vorta/assets/UI/scheduletab.ui
* Rewrite tooltips to make them HIG conform.
The KDE HIG was used.
* src/vorta/assets/UI/exportwindow.ui
* src/vorta/assets/UI/importwindow.ui
* src/vorta/assets/UI/mainwindow.ui
* src/vorta/assets/UI/repoadd.ui
* src/vorta/assets/UI/repotab.ui
* src/vorta/assets/UI/sourcetab.ui
* src/vorta/views/export_window.py
* src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests.
* src/vorta/views/main_window.py
* Replace `...` with unicode ellipses `…` (U+2028) in GUI text.
* src/vorta/borg/break_lock.py
* src/vorta/borg/check.py
* src/vorta/borg/create.py
* src/vorta/borg/delete.py
* src/vorta/borg/diff.py
* src/vorta/borg/extract.py
* src/vorta/borg/info_archive.py
* src/vorta/borg/info_repo.py
* src/vorta/borg/init.py
* src/vorta/borg/list_archive.py
* src/vorta/borg/list_archive.py
* src/vorta/borg/list_repo.py
* Clean prune tab in `archivetab.ui`.
* src/vorta/assets/UI/archivetab.ui
* Prettify `repotab`.
* src/vorta/assets/UI/repotab.ui
* Fix tooltips for pruning in `archivetab.ui`.
* src/vorta/assets/UI/archivetab.ui
* Use affirmative phrase in checkbox for metered networks.
* src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`.
* src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase.
* src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`.
* Add label in shell commands pane in `scheduletab` and fix placeholders.
Placeholders shouldn't be a replacement for a label.
* src/vorta/assets/UI/scheduletab.ui
* Group settings widgets in `misctab`.
* src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout.
* src/vorta/utils.py (search): Added. Searches for a key inside an iterable
applying a given function before comparison.
* src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group.
* src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and
implement migration adding the `group` field.
* src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`.
* src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups.
* src/vorta/store/connection.py (init_db): Update group and type of settings if needed.
* src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`.
* src/vorta/views/misc_tab.py : Instanciate logger.
* src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`.
* src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between.
* Fix tests for `misctab`.
* tests/test_misc.py
* Fix margins.
* src/vorta/assets/UI/archivetab.ui
* src/vorta/assets/UI/misctab.ui
* src/vorta/assets/UI/repotab.ui
* src/vorta/assets/UI/scheduletab.ui
* src/vorta/assets/UI/sourcetab.ui
* Morph buttons in `sourcetab` into toolbuttons with icons.
Adds gradient buttons along the way. Fixes#933.
* src/vorta/assets/UI/sourcetab.ui : Change layout and buttons.
Merge buttons with adding capabilities into one toolbutton (with menu).
* src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`.
Rename `sourceUpdate` to `updateButton`.
Add `addButton`.
* src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0.
* src/vorta/views/source_tab.py (SourceTab.set_icons): Added.
* src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with
actions to add files and folders and to paste.
* src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well.
* Fix tests for `sourcetab`.
* tests/test_source.py
* Add paste icon to paste action in `sourcetab`.
* src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0)
* src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`.
* src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`.
* Add icons to open actions in `sourcetab`.
* src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0
* src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0
* src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action
to `addFilesAction` and `addFoldersAction`.
* src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`.
* Fix icon size of `file.svg`.
* src/vorta/assets/icons/file.svg
* Set fill of added svgs to `#000000`.
* src/vorta/assets/icons/file.svg
* src/vorta/assets/icons/folder.svg
* src/vorta/assets/icons/minus.svg
* src/vorta/assets/icons/paste.svg
* Improve UX and consistency within the app for `scheduletab`.
* src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout.
* src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries
to radiobuttons and checkboxes.
* Workaround scheduletab tests being broken in github actions.
For some unknown reason clicking the `scheduleFixedRadio` won't work
when running using github action on ubuntu.
* tests/test_schedule.py
* Fix labels and spacing in `scheduletab`.
* src/vorta/assets/UI/scheduletab.ui
* Make archive operations more accessible and rename actions of `ArchiveTab`.
* src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`.
Rename `refresh_archive_action` to `refresh_archive_info`.
Rename `refresh_archive_result` to `info_result`.
Rename `list_archive_action` to `extract_action`.
Rename `list_archive_result` to `extract_list_result`.
* src/vorta/views/main_window.py : Apply renaming.
* src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions.
Remove `archiveActionButton`. And some other layout changes.
* src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`.
Rename `checkButton` to `bCheck`.
Rename `diffButton` to `bDiff`.
Rename `listButton` to `bList`.
* tests/test_archives.py : Apply renaming.
* src/vorta/views/archive_tab.py : Connect new action buttons.
* src/vorta/views/archive_tab.py : Remove `archiveActionButton`.
* tests/test_archives.py : Fix tests.
* Enable and disable archive actions depending on selection.
* src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame.
* src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that
enables/disables the frame depending on the selection count.
* src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection.
* src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`.
Call `on_selection_change` at the end.
* Fix tests for `archivetab`.
* tests/test_archives.py
* Replace line by spacer in repotab.
* src/vorta/assets/UI/repotab.ui
* Show labels for archive action buttons.
* src/vorta/assets/UI/archivetab.ui
* Add tooltips and ellipses to archivetab.
* src/vorta/assets/UI/archivetab.ui
* src/vorta/views/archive_tab.py
* Fix tooltips.
* src/vorta/assets/UI/sourcetab.ui : Add tooltips.
* src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons.
* Add context menu to source view.
* src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`.
Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`.
* src/vorta/assets/UI/sourcetab.ui: Change size hints.
* Add context menu to archive view.
* src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`.
Implement `archiveitem_contextmenu`.
* Replace `Type` column in sources view by icon.
* src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column.
* src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view.
* src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column.
* src/vorta/assets/UI/sourcetab.ui : Remove `Type` column.
* Fix initial sort indicator of source view.
* src/vorta/views/source_tab.py
* Fix adding items while sorting enabled.
* src/vorta/views/source_tab.py
* Remove status bar and remove fix size hint for log text label.
* src/vorta/assets/UI/mainwindow.ui
* src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to
two times the height of a line calculated by `QFontMetrics`.
* Resize main window height to `670`.
* src/vorta/assets/UI/mainwindow.ui
* Replace `QToolbutton` by `QPushbutton`.
* src/vorta/assets/UI/archivetab.ui
* src/vorta/assets/UI/repotab.ui
* src/vorta/assets/UI/sourcetab.ui
* src/vorta/views/source_tab.py
* Fix flake8
* Improve label of entry for `borg create` extra arguments.
* src/vorta/assets/UI/scheduletab.ui
* Unify label font size in `repotab`.
* src/vorta/assets/UI/repotab.ui
* Morph `QPushButton`s into `QToolButton`s.
Some exceptions were made, especially in the dialog windows.
* src/vorta/assets/UI/archivetab.ui
* src/vorta/assets/UI/mainwindow.ui
* src/vorta/assets/UI/repotab.ui
* src/vorta/assets/UI/sourcetab.ui
* Add copy capabilities to archive view and a copy shortcut to it and to source tab.
* src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying.
* src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action.
* src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying.
* Move actions in comboBoxes to buttons.
* src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`.
* src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`.
* src/vorta/views/repo_tab.py
* Make tooltip of `storePassword` checkbox more fluent.
* src/vorta/assets/UI/exportwindow.ui
* Introduce `QDialogButtonBox` to modal dialogs in vorta.
* src/vorta/assets/UI/extractdialog.ui
* src/vorta/views/extract_dialog.py
* src/vorta/assets/UI/repoadd.ui
* src/vorta/views/repo_add_dialog.py
* src/vorta/assets/UI/sshadd.ui
* src/vorta/views/ssh_dialog.py
* Move some options in scheduletab to the side.
This results in two columns of options and fixes vertical scrolling.
* src/vorta/assets/UI/scheduletab.ui
* Changes for macOS layout
* Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`.
* src/vorta/assets/UI/mainwindow.ui
* src/vorta/assets/UI/repotab.ui
* Fix some icons, translations strings and link
* Lint
Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com>
Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com>
Co-authored-by: Manu <manu@snapdragon.cc>
Scheduler now has the ability to run jobs on multiple repositories concurrently and run multiple jobs on one repo (by queuing them).
For each repository, there is one queue. I have represented a queue by a 'site'. Between sites (ie repository), tasks run concurrently. On one site, tasks run one by one. The user also run tasks by adding them to the queue but he can't run multiple backups because start backup button is disabled when a job is running.
* add support for 'diff --json-lines' available in borg 1.1.16.
* fixes issue #901 (diff not handling CR/LF in filenames)
* improve `pretty_bytes()` formatting function
* Remove qtdarkstyle and custom fusion style.
* Support instant changes from light to dark style
* Adjust SVG icon colors on-the-fly, adjust to dark theme in real time (macOS)
* Add OS-independent dark mode detection. Fix QToolbox style after theme changes.
* Remove some unnecessary style options, like `uses_light_icon` and `use_dark_style`.
- It now heavily relies on regex. This was done in order to make the code more stable and easier to maintain.
- Share common code for file tree view between extract and diff.
This enables column sorting for the table on the archive list page.
However, all columns are sorted by lexical string order. For example,
this means that archives with "52 MB" are ranked greater than "332 MB".
Completes: https://github.com/borgbase/vorta/issues/349
Showing the last 5 characters of the mount points doesn't give much
information, so we now allow the user to resize the mount_point column
and allow Qt to draw an ellipsis and the number of characters that
fit in the column (or the whole mount point if it fits).
real-yfprojects