* refactor: save length of PadA and PadB sent
* refactor: log outgoing `len(PadA)` and `len(PadB)`
* refactor: set `ia_len_` as the MSE handshake initiator
* fix: abort handshake if torrent isn't running
* fix: check if torrent is running in all cases
* fix: don't penalise peer if handshake failed because of us
* fix: tests
* perf: ensure copy-elision in `HandshakeMediator::torrent()`
* code review: more accurate log wording
Uses `fmt::print` to log failure messages. Results in a connection
failure being printed as:
Unable to send request to 'http://localhost:9091/transmission/rpc/': Couldn't connect to server
Fixes#7010
* Revert "feat: save queue order between sessions (#6753)"
This reverts commit 4db50dae10.
* refactor: new torrent queue class
* refactor: replace queue code with new class
* test: new tests for new class
* feat: store and load queue order across sessions
* build: xcode
* refactor: use set_difference instead of unordered_set
* code review: use `tr_torrent_id_t` as key
* fix: don't overflow when moving up/down
---------
Co-authored-by: Dzmitry Neviadomski <nevack.d@gmail.com>
* Fix: disconnect blocklisted peer on blocklist update.
Mark peer to be disconnected upon blocklist update.
Tested on my torrent, seems to be working.
Fix#732 .
* Add debug message when blocking peers
Add debug message each time a peer gets blocked during blocklist update.
* Change log api
Co-authored-by: Yat Ho <lagoho7@gmail.com>
---------
Co-authored-by: Yat Ho <lagoho7@gmail.com>
* Sync translations with code
* Sync translations with Transifex
* Fix order of plurals for Slovenian
* Add new Mac translations
* Afrikaans (af)
* Greek (el)
* refactor: add `tr_pex::to/from_variant()`
* refactor: store peers as benc in resume
* fix: discard invalid pex in `tr_pex::from_variant()`
* fix: limit number of peers loaded from resume
* refactor: use metadata id to check for ut metadata support
* refactor: use pex id to check for ut pex support
* refactor: start pex timer after ltep handshake
* refactor: harden metadata xfer sanity checks
* code review: constexpr
* code review: don't save peer ut_pex_id and ut_metadata_id if on private torrent
* properly consume PadA in MSE handshake, check for invalid Ya+PadA
* refactor: make handshake constants public (needed for test coverage)
* test: split test MSE handshakes by blocking steps
* test: use `ASSERT_TRUE` instead of `assert`
* test: fix windows crash by using `recv` and `send`
Co-authored-by: Yat Ho <46261767+tearfur@users.noreply.github.com>
* refactor: use `TR_IF_WIN32` for `LOCAL_SOCKETPAIR_AF`
Co-authored-by: Yat Ho <46261767+tearfur@users.noreply.github.com>
---------
Co-authored-by: Yat Ho <lagoho7@gmail.com>
Co-authored-by: reardonia <reardonia@github.com>
Co-authored-by: Yat Ho <46261767+tearfur@users.noreply.github.com>
* refactor: calculate raw speed by OS buffer instead of application buffer
* refactor: limit transfer speed by raw speed
* refactor: early return write if no bytes
* refactor: remove code for guessing TCP/IP overhead
* refactor: remove code for uTP overhead
* In the small view, show the action buttons when hovering anywhere over the cell
This matches the previous behavior.
* Explicitly hide/show the priority icon in the stack view
* Restore right padding on the compact view's stack view
* style fixes
* refactor: move path checking methods to base
* refactor: differentiate "empty string key" and "no key"
* fix: check full path when parsing http announce response
* fix: check full path when parsing http scrape response
* refactor: avoid copying when checking scrape info hash
* fixup! fix: check full path when parsing http scrape response
