Commit Graph

115 Commits

Author SHA1 Message Date
Charles Kerr 073ae6c206
chore: fix deprecation warnings of GTK_STOCK_ use. (#1370)
* chore: fix deprecation warnings of GTK_STOCK_ use.

This is just a tiny step towards getting all of the GTK code up-to-date,
but GTK_STOCK warnings are the lowest-hanging fruit of the warnings, so
let's fix them.
2020-07-27 12:49:45 -05:00
Charles Kerr b0e33117c5
Fix some gtk warnings (#1038)
* fix gtk deprecation warning: gtk_misc_set_alignment

* fix gtk deprecation warning: gtk_alignment_new

* fix gtk deprecation warning: gtk_tree_view_set_rules_hint

* fix gtk deprecation warning: gtk_image_new_from_stock

* fixup! fix gtk deprecation warning: gtk_alignment_new

* fix gtk deprecation warning: gtk_dialog_set_alternative_button_order

* fix gtk deprecation warning: gtk_show_uri

* fix gtk deprecation warning: gtk_widget_set_margin_left

* fix gtk deprecation warning: gtk_button_set_alignment

* fix gtk deprecation warning: g_type_class_add_private

* fix gtk deprecation warning: gtk_menu_popup

* fix gtk deprecation warning: gtk_misc_set_padding

* chore: uncrustify

* fix: silence G_TYPE_INSTANCE_GET_PRIVATE warning

Deprecaed starting in glib 2.58

* chore: uncrustify
2019-11-06 13:09:27 -06:00
Mike Gelfand 1e3d20422a Reduce for loop variables scope 2017-05-14 01:38:31 +03:00
Mike Gelfand a762c770f2 Make conditional expressions explicitly boolean 2017-04-30 19:26:01 +03:00
Mike Gelfand 4f9d9ad92b Code style change leftovers
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand dadffa2c0f Align type qualifiers to the right (code style)
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand d7930984ef Adjust uncrustify config, reformat all but Mac client
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand 2248d3670f Get rid of $Id$ SVN keywords in source files 2016-09-02 23:10:15 +03:00
Jordan Lee 3d38723ad9 Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk). 2012-12-05 17:29:46 +00:00
Jordan Lee 45bdc18210 (trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761 2011-05-02 17:58:27 +00:00
Jordan Lee c7006ed8b3 (trunk gtk) remove the TrTorrent GObject subclass. 2011-03-03 01:59:25 +00:00
Jordan Lee 879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr 6627aade08 (trunk gtk) don't use the GSEAL'ed variable vbox GtkDialog directly... use gtk_dialog_get_content_area() instead 2010-12-22 03:12:47 +00:00
Charles Kerr 5eafe91824 (trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately. 2010-12-21 19:20:58 +00:00
Charles Kerr e934290980 (trunk gtk) portability: use g_dngettext() instead of ngettext() 2010-08-06 14:38:54 +00:00
Charles Kerr 68cc4d902f (trunk gtk) #3416 "clicking close on the transmission window causes new "Quit Transmission?" dialog even if one already exists" -- fixed 2010-07-11 06:46:46 +00:00
Daniel Lee 4342a7a01b (gtk) Port qt remove dialog changes to gtk 2010-05-18 23:49:41 +00:00
Charles Kerr 06f044680a (trunk) #3174 "Use IEC standard units (KiB, MiB, GiB) instead of (KB, MB, GB)" -- implemented for gtk, qt, daemon, cli, and web client 2010-04-28 01:26:46 +00:00
Charles Kerr cb79214854 (trunk) remove trailing spaces 2009-08-10 20:04:08 +00:00
Charles Kerr a2d67ffb40 (trunk gtk) #2186: Focus should not be on "Don't ask me again" when I quit Transmission 2009-06-09 04:52:22 +00:00
Charles Kerr 79e546fe9c (gtk) #1472: More detailed warning on removing active torrents 2008-11-16 07:11:34 +00:00
Charles Kerr 0c4f300f1b #1369: clarify the different torrent status & callbacks' APIs and typenames 2008-10-20 17:54:56 +00:00
Charles Kerr 1415b72017 #1336: fix some compiler warnings when building with -Wformat-security 2008-10-09 20:03:34 +00:00
Charles Kerr cc89872dd4 run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened 2008-09-23 19:11:04 +00:00
Charles Kerr 126609cded (gtk) fix crash reported by Lacrocivious 2008-04-29 22:56:44 +00:00
Charles Kerr 101307ddff fix a couple more minor leaks 2008-04-17 19:54:22 +00:00
Charles Kerr 5d195e00f3 (gtk) #869: Minor HIG fixes for Exit/Remove/Delete alerts 2008-04-12 15:01:43 +00:00
Charles Kerr e40987fdc3 (gtk) more string folding 2008-03-19 02:05:55 +00:00
Charles Kerr 0437c5f33e (gtk) try to iron out the remaining "add torrent" issues reported by wereHamster and Lacrocivous 2008-03-18 01:22:11 +00:00
Charles Kerr e4562bcd7b (gtk) #772, #753: added `watch dir' for automatically adding torrents. delete files to trashcan, rather than unlinking them. These features require 2.15.5 or higher. 2008-03-09 15:27:08 +00:00
Charles Kerr 6ef6ac0928 the last i18n-centric commit for awhile, I hope. 2008-03-08 04:53:11 +00:00
Charles Kerr 909cb89b43 even more i18n string work, w/more feedback and reading through the transmission.pot file. 2008-03-08 01:43:20 +00:00
Charles Kerr 7200b27a18 lots more i18n string work -- making strings more consistent, folding redundant strings together, etc. 2008-03-07 20:48:36 +00:00
Charles Kerr 414b8168d9 (gtk) minor r5216 cleanup 2008-03-07 19:05:00 +00:00
Charles Kerr 0cebab1247 (gtk) #769: when removing a torrent, prompt for confirmation if (a) the torrent is incomplete, (b) the torrent is connected to peers, (c) the user is also deleting the downloaded files. 2008-03-07 17:47:42 +00:00
Charles Kerr 76891225b9 more i18n work. 2008-03-07 03:26:59 +00:00
Charles Kerr 777c0de53a more i18n strings work 2008-03-06 21:59:00 +00:00
Charles Kerr a11071e661 (gtk) minor: use "Folder" instead of "Directory", as per the GNOME Desktop Terms list 2008-03-06 20:55:07 +00:00
Charles Kerr fb81f0adf5 (gtk) grammar tweak as suggested by wereHamster 2008-03-02 19:34:18 +00:00
Charles Kerr f71665e166 (gtk) #748: hig improvements to the `remove torrent' confirmation dialog. 2008-03-02 15:54:58 +00:00
Charles Kerr 1df83e3a2e (gtk) #742: gtk dialog buttons need to support `alternative button order' for KDE users 2008-02-28 14:48:23 +00:00
Charles Kerr 851e6ce008 (gtk) make the filename naming scheme a little more consistent. 2008-02-26 19:58:03 +00:00
Charles Kerr bcecbbba99 (gtk) #312: Attention notification when using "Open with" 2008-02-19 05:52:37 +00:00
Charles Kerr c421bc0266 (gtk) add ability to delete downloaded files when deleting a torrent 2008-02-19 03:57:03 +00:00
Charles Kerr b353ae4b43 (gtk) same Lacrocivous-inspired tweaks, in the multifile open dialog 2008-02-13 04:40:34 +00:00
Charles Kerr 31790f031c (gtk) add some safety assertions 2008-02-13 03:57:48 +00:00
Charles Kerr 85c49dbbee (gtk) new "add torrent" popup to let users choose which files to download, file priority, add paused, delete source .torrent, etc 2008-02-13 03:00:21 +00:00
Charles Kerr f72d7052c7 (gtk) #649: don't ask for confirmation on close when there are no active torrents. 2008-01-27 20:12:10 +00:00
Charles Kerr 02332c43a9 (gtk) #649 don't ask for confirmation on close when there are no active torrents. 2008-01-21 15:51:53 +00:00
Charles Kerr 9423e89aec (gtk) SHUTUP cleanup 2008-01-19 05:04:38 +00:00