Charles Kerr
1f28470cf4
chore: prefer QStringLiteral ( #1284 )
...
Further reading:
* https://forum.qt.io/topic/78540/qstringliteral-vs-qlatin1string/2
* https://woboq.com/blog/qstringliteral.html
* https://www.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral
tl;dr: QLatin1Literal uses less memory than QStringLiteral; however,
since most Qt APIs require a QString argument, there's extra runtime
cost of converting QLatin1Strings to QStrings. QStringLiteral uses a
little more memory but constructs its QStrings at compile time.
ok, the `prefer-qstringliteral` branch is getting out of control: the
secondary goal of fixing a .clang-tidy issue is causing more diffs
than the primary goal. So, I'm breaking it into two separate PRs.
2020-05-29 12:40:07 -05:00
Charles Kerr
070a7f2ffc
refactor: use snake_case field naming in qt client ( #1262 )
...
* refactor: use snake_case field naming in qt client
* fix: some missed symbols
* chore: make uncrustify happy
* fixup! refactor: use snake_case field naming in qt client
2020-05-27 16:53:12 -05:00
Mitchell Livingston
4893771a04
Merge branch 'master' of https://github.com/transmission/transmission
2020-05-25 09:37:24 -04:00
Mitchell Livingston
6d2164ec47
Remove mention of Growl, which has been removed.
2020-05-25 09:37:19 -04:00
Pavel Borzenkov
34137ae324
fix(rpc-spec): fix typo in editDate
arg description ( #1251 )
...
The argument is actually valid for `torrent-get` only.
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
2020-05-24 11:13:17 -05:00
Mike Gelfand
0c10308e06
Add missing files that fail build from tarball ( #1247 )
...
Fixes : #1246 , #1138
2020-05-23 02:13:59 +03:00
Charles Kerr
d43aeb6a5c
chore: add clang-tidy checks to Qt client ( #1236 )
...
* chore: add clang-tidy integration for Qt client
2020-05-19 20:32:51 -05:00
Charles Kerr
6aa559f12f
refactor: remove QVariants from torrent ( #1234 )
...
* chore: remove qvariants from torrent class
* chore: remove unused Q_DECLARE macro calls
* refactor: remove unused includes from Torrent.h
* chore: make clang-tidy and linter happy
* refactor: rename 'setValue()' to 'change()'
* refactor: make tr_variant function paramters const
* chore: remove devel scaffolding
* refactor: rename peer_limit_ to peerLimit_
* refactor: do not use bitwise logic on booleans
2020-05-19 18:42:17 -05:00
Charles Kerr
e7c099b8d8
chore: bump version to '3.00+'
2020-05-15 19:38:43 -05:00
Charles Kerr
bb6b5a062e
chore: bump version to '3.00'
...
If at first you don't succeed, bang your fingers on the keyboard until something works
2020-05-15 19:36:16 -05:00
Charles Kerr
f4489c982e
chore: bump version to '3.00+'
2020-05-15 18:53:16 -05:00
Charles Kerr
8a65b32b48
chore: bump version to '3.00'
2020-05-15 18:51:31 -05:00
Charles Kerr
82020d2e8c
fix: fix console warning when adding magnet links ( #1229 )
2020-05-15 12:22:06 -05:00
Mike Gelfand
87ca3529b7
Use release code signing certificate on Windows
2020-05-14 19:20:07 +03:00
Mike Gelfand
7db1c848ed
Add new translations from Transifex (95% and higher)
...
GTK client: none.
Qt client: Finnish.
Mac client: none (there're suitable languages, but they're lacking XIB files
and we haven't switched to base localization yet).
2020-05-14 19:17:11 +03:00
Mike Gelfand
4aa60bad52
Sync existing translations with Transifex
2020-05-14 19:16:15 +03:00
qu1ck
2fab317040
Add TR_TORRENT_LABELS to env variables available to scripts ( #868 )
...
* Add TR_TORRENT_LABELS to env variables available to scripts
* Add unit test for tr_strjoin
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-05-13 18:54:44 -05:00
Mingye Wang
d7f2dee4e0
crypto-utils: do tr_rand_int without abs ( #1198 )
...
* crypto-utils: do tr_rand_int without abs
There is really not much point in trying to abs a random int when you can just interpret it as unsigned in the first place.
* fixup! trailing space
how did this get in here?
* fixup! unsigned int
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-05-11 20:34:03 -05:00
Tom Richards
a82e728ad5
fix: memory leak in magnet parsing ( #1222 )
...
* Fix memory leak in magnet parsing
* Update libtransmission/magnet.c
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* Lint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-05-11 19:57:06 -05:00
Charles Kerr
fa6df52d58
chore: remove unused methods ( #1207 )
...
* chore: remove unused methods in qt client
* chore: remove unused libtransmission methods
* chore: remove unused gtk methods
* chore: remove more unused libtransmission methods
* chore: remove more unused code found by @reardonia
2020-05-11 17:20:46 -05:00
Noobsai
79d3133ebc
Fixed showing popup menu on RMB at tray icon ( #1210 )
2020-05-11 16:19:33 -05:00
Mike Gelfand
01368932b0
Add AppVeyor configuration for Windows release builds
2020-05-05 13:56:48 +03:00
Charles Kerr
5844284f58
chore: bump version to '3.00+'
2020-05-03 18:36:40 -05:00
Charles Kerr
3ef10de6d9
chore: bump version to '3.00'
2020-05-03 18:35:18 -05:00
Charles Kerr
6925be34b5
docs: make 'news' a markdown file ( #1208 )
...
* chore: fix markdown headers in NEWS.md
* chore: turn closed pulls/issues into links
* chore: linkify the release headers
* chore: fill in the 3.00 release date
* chore: use 'NEWS.md' in build scripts
* chore: tweak date format to YYYY-MM-DD
2020-05-03 18:33:57 -05:00
Mitch Livingston
af51141cdf
Update NEWS for 3.00 ( #1201 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-05-03 16:43:41 -05:00
Mike Gelfand
2d940e5caf
Bump copyright to 2020 (some more places) ( #1206 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-05-02 12:26:42 -05:00
Charles Kerr
8739cb9c88
fixup! (trunk) update credits ( #1205 )
2020-05-02 11:42:18 -05:00
Mike Gelfand
d1d27ae35f
Add new translations from Transifex (95% and higher)
...
GTK client: none.
Qt client: Japanese.
Mac client: none (there're suitable languages, but they're lacking XIB files
and we haven't switched to base localization yet).
2020-05-02 13:26:24 +03:00
Mike Gelfand
a79dbe4436
Sync existing translations with Transifex
2020-05-02 13:25:56 +03:00
Charles Kerr
797700e63f
perf: lazy-update actions enabled on change events ( #1187 )
...
* perf: lazy-update actions enabled on change events
Actions' sensitivity was being lazy-updated in response to other events
but accidentally were doing immediate updates in response to torrentsChanged
signals being emitted from TorrentModel. This commit makes that path a
lazy-update as well.
* chore: uncrustify
* refactor: make the idle updater a lambda again
2020-05-01 23:23:47 -05:00
Charles Kerr
87c9287b6a
refactor: in tr_truncd(), use DBL_DIG in printf() ( #1186 )
...
Previously it was calculated from `log10(1.0 / DBL_EPISILON) - 1`;
however, there's no need to calculate it out when there's an ANSI
standard that already spells it out consisely.
2020-05-01 22:11:45 -05:00
Mike Gelfand
2123adf8e5
CVE-2018-10756: Fix heap-use-after-free in tr_variantWalk
...
In libtransmission/variant.c, function tr_variantWalk, when the variant
stack is reallocated, a pointer to the previously allocated memory
region is kept. This address is later accessed (heap use-after-free)
while walking back down the stack, causing the application to crash.
The application can be any application which uses libtransmission, such
as transmission-daemon, transmission-gtk, transmission-show, etc.
Reported-by: Tom Richards <tom@tomrichards.net>
2020-04-29 17:29:38 +03:00
Bogdan Vasiliev
a6482b0061
GTK: behavior improvements of the torrent details window ( #892 )
...
* gtk: torrent details file-list default sort
* gtk: save torrent details window size
* gtk: torrent details window size & sort, code style
* gtk: torrent details window, conf.c dict fix
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 16:34:02 -05:00
RobCrowston
6bb8b2e78a
Refactor tr_torrentFindFile2 ( #921 )
...
* Factor-out file seek in tr_torrentFindFile2.
* Update libtransmission/torrent.c
Co-Authored-By: RobCrowston <crowston@protonmail.com>
* Fix code style.
Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 15:07:01 -05:00
andreaskern
def7634f18
fix availability not showing 100% in gtk details view ( #1181 )
...
#1180
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-26 00:07:40 -05:00
Jakub Steiner
7b53f4238d
icon: update application icon ( #1141 )
...
Fixes https://github.com/transmission/transmission/issues/1140
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-25 20:01:49 -05:00
Mitch Livingston
ac3ba03775
Merge pull request #1185 from transmission/revert-fileSystemRepresentation
...
Revert "Merge pull request #1039 from MaddTheSane/patch-4"
2020-04-25 10:44:08 -04:00
Mitchell Livingston
470ee010f2
Revert "Merge pull request #1039 from MaddTheSane/patch-4"
...
This reverts commit c0c463d660
, reversing
changes made to cd2587a435
.
2020-04-25 10:35:15 -04:00
Akatsuki
f6030b1d79
gtk: fix window width ( #1069 )
...
GTK window width cannot be smaller than the longest torrent title
Source: https://trac.transmissionbt.com/ticket/6128
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-24 15:15:57 -05:00
Mitch Livingston
c0c463d660
Merge pull request #1039 from MaddTheSane/patch-4
...
Replace some instances of -UTF8String with -fileSystemRepresentation
2020-04-20 09:01:01 -04:00
Mitch Livingston
3c56953dac
Merge branch 'master' into patch-4
2020-04-20 08:21:23 -04:00
Mitch Livingston
cd2587a435
Merge pull request #885 from DevilDimon/dock_string_crash_fix
...
Ignore non-URL strings when opening URLs
2020-04-20 08:20:59 -04:00
Mitch Livingston
05c67c8a27
Merge branch 'master' into dock_string_crash_fix
2020-04-20 07:59:47 -04:00
Mitch Livingston
8a28db8c1f
Merge branch 'master' into patch-4
2020-04-20 07:55:12 -04:00
Charles Kerr
4daefce2e3
chore: set User-Agent and Peer-Id to version 3.00+
2020-04-19 16:57:58 -05:00
Charles Kerr
6716bb160e
chore: set User Agent and Peer Id for version 3.00
2020-04-19 16:57:36 -05:00
Mitch Livingston
36fba96f1f
Merge pull request #1177 from transmission/Progress-bar-colors
...
Update the progress bar colors in dark mode
2020-04-19 10:56:44 -04:00
Mitch Livingston
d8e8d89545
Merge branch 'master' into Progress-bar-colors
2020-04-19 10:18:08 -04:00
Mitch Livingston
7bfdf3854e
Merge pull request #1176 from transmission/progress-color
...
Fix the peer progress number in dark mode.
2020-04-19 09:58:04 -04:00