Commit Graph

1648 Commits

Author SHA1 Message Date
Jordan Lee cdd71c6427 (trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2 2012-07-14 19:26:55 +00:00
Jordan Lee b6e0e48927 (trunk gtk) #4892 "support Startup Notification in the GTK interface" -- fixed. 2012-07-13 19:53:59 +00:00
Jordan Lee 3398a48e57 (trunk libT) #4402 "Transmission Bandwidth allocation getting overflows" -- use gvdl's patch '4402-uint-bpsoverflow.patch' 2012-07-01 02:17:35 +00:00
Jordan Lee 5ad842b6a8 (trunk, gtk) fix #4871 'appindicator does not set its title' w/patch from seb128 2012-04-16 18:42:26 +00:00
Jordan Lee 53ea28bdf6 (trunk, gtk) fix #4867 'Some strings are not translated in Transmission in Ubuntu 12.04' 2012-04-13 14:49:34 +00:00
Jordan Lee cf716904f9 (trunk, gtk) #4573 'fix crash when opening a torrent file on systems that don't define G_USER_DIRECTORY_DOWNLOAD'. Thanks to Felipe Contreras for the initial patch. 2012-04-08 16:02:48 +00:00
Jordan Lee 01535743a0 (trunk) improved & translatable .desktop files patch from jbicha for ticket #4804 2012-04-07 15:45:12 +00:00
Jordan Lee fd5014aef5 (trunk gtk) fix ticket #4827 'clicking cancel in Open URL dialog does nothing' 2012-04-07 00:41:21 +00:00
Jordan Lee 32f3186f84 (trunk gtk) fix #4849 'Transmission-gtk Ignores Notification Sound Setting' with a patch from Jan Varho 2012-04-07 00:30:37 +00:00
Jordan Lee 4c8c5f578d (trunk gtk) #4764 "filenames should have a tooltip" -- fixed with patch from gulyan 2012-03-04 13:12:42 +00:00
Jordan Lee a3039d444d #4804 "Add quicklist to gnome-shell and unity" -- patch applied. 2012-03-04 12:58:46 +00:00
Jordan Lee 252560ddd9 (trunk gtk) #4791 "Should catch SIGTERM instead of SIGKILL" -- fixed with patch by Matt Krai 2012-02-24 19:52:50 +00:00
Jordan Lee e110757013 (trunk gtk) when processing log messages for the Message Log window and we encounter an error messages, pass it to g_warning() as well 2012-02-04 23:59:42 +00:00
Jordan Lee 6d4858d8dd (trunk) #4732 "allow switching between internal and system libnatpmp" -- fixed with patch scarabeus and applied by me, so any patch breakage is probably mine... ;) 2012-02-04 01:28:15 +00:00
Jordan Lee fbc7f3dc3c (trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)

Flame away.
2012-02-03 21:21:52 +00:00
Jordan Lee e599b3a738 (trunk gtk) To improve translations, help gettext to differentiate between the gerund and verb forms of some -ing words like "Seeding" and "Downloading" -- fixed.
I wasn't sure how to do this, so for the benefit of my future self or anyone else who's interested, here are some breadcrumbs I found: https://trac.transmissionbt.com/ticket/4717#comment:6
2012-02-03 17:12:17 +00:00
Jordan Lee 631a77287d (trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…). 2012-02-03 15:51:36 +00:00
Jordan Lee 7e83c406d4 (trunk gtk) fix a minor memory leak in gtr_open_file(). reported by clang static analyzer. 2012-01-24 18:09:12 +00:00
Jordan Lee 300f070104 Silence a minor compiler warning.
We used to pass no button text + response_id pairs when creating the dialog because only gtk_dialog_add_button() would return back the actual button widget s.t. we could use a grab on it. However as of GTK+ 2.20 we can use gtk_dialog_get_widget_for_response() to get the button, so we can create dialogs in the more common way (which also fixes the gcc warning)
2012-01-13 22:10:26 +00:00
Jordan Lee d524deecb0 (trunk libT) #4372 "make notification and system sounds configurable" -- instead of using notify-send, use GDBus on the org.freedesktop.Notifications API. Patch by fmuellner. 2011-12-10 19:00:50 +00:00
Jordan Lee 00757d8d33 (trunk gtk) remove dead assignment 2011-11-03 04:57:45 +00:00
Jordan Lee 8e74ccb7a1 (trunk gtk) #4605 "'--minimized' switch not working any more" -- fixed. 2011-10-30 18:27:45 +00:00
Jordan Lee 7c9fdfa8dd (trunk) run all our pngs through "pngout.exe" and "optipng -zc1-9 -zm1-9 -zs0-3 -f0-5" 2011-10-26 16:11:21 +00:00
Jordan Lee 76cf0520ba (trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fix About dialog issue when hiding and then re-showing Transmission. 2011-10-13 00:36:19 +00:00
Jordan Lee 6ec4aec13a (trunk gtk) #5204 "Transmission GTK client crashes on start" -- another possible fix ;) 2011-10-11 20:32:15 +00:00
Jordan Lee b645959eea (trunk gtk) #4554 "Transmission GTK client crashes on start" -- possible fix. 2011-10-11 15:30:33 +00:00
Jordan Lee 55c84fa9ea (trunk gtk) #4552 "mark primary toolbars" -- applied patch from fmuellner 2011-10-11 15:27:32 +00:00
Jordan Lee 72a021a9f3 (trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fixed. 2011-10-11 14:36:03 +00:00
Jordan Lee f9388714b7 (trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2 2011-10-11 04:11:08 +00:00
Jordan Lee 01f68ca846 (trunk libT) #4323 "Allow usage of system miniupnpc" -- fixed. 2011-10-09 02:05:52 +00:00
Jordan Lee cc237aa713 #4479 'magnet links are not included in filter results' -- fixed. 2011-09-14 17:22:54 +00:00
Jordan Lee 8bbc4c7b83 (trunk gtk) #4470 "Search in torrent list is broken" -- fixed. 2011-09-12 06:11:04 +00:00
Jordan Lee 84afa05662 (trunk) Roll back the right-to-left progressbar behavior added in #4281 -- it confused too many people. 2011-09-01 22:49:35 +00:00
Jordan Lee a7a9c2b12e (trunk gtk) #4399 "Add option to disable 'trash can' feature" -- done. 2011-08-13 22:58:49 +00:00
Jordan Lee 6315db10f2 (trunk libT) when building unordered lists, use g_slist_prepend() instead of g_slist_append() for efficiency's sake. 2011-08-13 22:37:25 +00:00
Jordan Lee bb41777ac7 (trunk gtk) sync the gtk+ client's watchdir behavior with the daemon's wrt r12668 2011-08-13 22:24:31 +00:00
Jordan Lee b5de483362 (trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places. 2011-08-13 21:08:53 +00:00
Jordan Lee c00b97169c use a gulong when remembering the return value of g_signal_connect(). we were using a guint in some places. 2011-08-13 21:03:38 +00:00
Jordan Lee 2487f455ef silence a warning on 64-bit machines introduced in r12669 2011-08-13 20:18:10 +00:00
Jordan Lee 38a1df9344 (trunk gtk) remove some unnecessary #includes 2011-08-13 14:19:40 +00:00
Jordan Lee b3eb4be9b3 rename 'torrent_idle_data' as 'rpc_idle_data' 2011-08-13 14:00:33 +00:00
Jordan Lee 5adcf5d32d (trunk gtk) minor tweak to signal_handler() 2011-08-13 13:59:50 +00:00
Jordan Lee 6f850a3d87 (trunk gtk) simplify the gtk+ client's watchdir code 2011-08-13 13:58:35 +00:00
Jordan Lee b795aae049 (trunk gtk) move function declarations to where they're needed 2011-08-13 05:52:36 +00:00
Jordan Lee 1564405655 (trunk gtk) simplify the details dialog manager 2011-08-13 05:47:32 +00:00
Jordan Lee 825c8bf083 (trunk gtk) remove unnecessary #includes 2011-08-13 05:04:06 +00:00
Jordan Lee 0e8b5612ed (trunk gtk) simplify the implementation of get_details_dialog_key() 2011-08-13 05:03:18 +00:00
Jordan Lee 028cfcca5a (trunk, gtk) remove the file "marshal.list"; it's unused after r12656 / r12638 2011-08-09 15:19:11 +00:00
Jordan Lee 7ab14ad4b1 (trunk gtk) in torrent-cell-renderer and tr-core, use the _parent_class field generated by G_DEFINE_TYPE. 2011-08-09 06:31:33 +00:00
Jordan Lee 6290169099 (trunk gtk) use G_DEFINE_TYPE when implementing the tr-core and torent-cell-renderer classes 2011-08-09 05:47:24 +00:00
Jordan Lee ee706baa7f (trunk gtk) fix minor memory leak introduced in r12657 2011-08-09 05:22:11 +00:00
Jordan Lee 4d4eeae682 (trunk gtk) first cut at using GApplication. This lets glib replace hundreds of lines of homegrown code. Whee! 2011-08-09 02:30:31 +00:00
Jordan Lee 8d89a16f4f remove the gtr_idle_add() portability wrapper around gdk_threads_add_idle() -- it's unnecessary now that the minimum gtk version's been bumped. 2011-08-08 17:10:55 +00:00
Jordan Lee 6d1869c33b remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped. 2011-08-08 17:06:46 +00:00
Jordan Lee b7371264fb fix r12638 regression caused by the difference in return values from gtr_mkdir_with_parents() and g_mkdir_with_parents() 2011-08-08 16:56:36 +00:00
Jordan Lee 7554955eb8 queuing: fix false "Error" message reported by rb07 2011-08-08 16:38:22 +00:00
Jordan Lee abea9d306f queuing: tweak the status messages for queued torrents 2011-08-08 16:31:52 +00:00
Jordan Lee 10aa77490a (trunk gtk) remove an unnecessary GTK_CHECK_VERSION(2,10,0) check now that the minimum gtk+ version's been bumped 2011-08-08 16:02:37 +00:00
Jordan Lee 0e48418f26 (trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010). 2011-08-07 18:41:13 +00:00
Jordan Lee 270126820a (trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency 2011-08-07 16:42:38 +00:00
Jordan Lee 79cb75e57d Tweak the phrasing of the queue preferences in the Qt and GTK+ preferences dialogs 2011-08-06 16:47:14 +00:00
Jordan Lee 307754e807 #671 "torrent queuing" -- modify the queue implementation s.t. every torrent has a queuePosition, even if it's not currently in the queue. 2011-08-02 03:59:54 +00:00
Jordan Lee 2e9d419bd4 #671 "torrent queuing" -- add a tr_stat.isStalled flag. 2011-08-01 23:27:11 +00:00
Jordan Lee 61174b007e (trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support. 2011-08-01 22:24:24 +00:00
Jordan Lee 0faddf054b (trunk gtk) when N torrents change their state at the same time, use an idle timer so that the UI refreshes once instead of N times. 2011-07-30 13:28:03 +00:00
Jordan Lee 9448bc5e88 (trunk gtk) #1477 "Launchpad translations need comment for strings with non-standard context" -- apply patch from okram. 2011-07-26 01:09:39 +00:00
Jordan Lee ee20cc2b24 (trunk gtk) #4320 "Port GTK client to GTK 3." -- transmission-gtk now compiles cleanly & runs on GTK 3. 2011-07-26 01:02:32 +00:00
Jordan Lee d6f9e85850 (trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- fix build issue in r12562 2011-07-24 16:01:14 +00:00
Jordan Lee bb57ac3c50 (trunk gtk) #4372 "make notification and system sounds configurable" -- fixed. 2011-07-23 17:23:12 +00:00
Jordan Lee 1bf6b884b5 (trunk gtk) #4366 -- wrap register_magnet_link_handler()'s body in #if HAVE_GIO ... #endif 2011-07-20 23:33:38 +00:00
Jordan Lee e495a579d3 (trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- done. 2011-07-20 23:31:39 +00:00
Jordan Lee 2863ee49c9 (trunk gtk, qt) "It is unobvious if test port feature tests UDP port status as well" -- fixed. 2011-07-17 14:12:00 +00:00
Jordan Lee d634396f98 (trunk gtk, qt) #4165 "__FD_SETSIZE impact on open-file-limit and peer-limit-global" -- cap the per-torrent and per-session peer limits at FD_SETSIZE. 2011-07-13 19:22:10 +00:00
Jordan Lee caeeb7e94c (trunk gtk) #4308 "Open with Transmission from Firefox doesn't work since Transmission 2.31" -- added support for uri-formmatted filenames being passed in via the command line 2011-06-24 18:16:12 +00:00
Jordan Lee d3e427cfd8 (trunk gtk) #4306 "Bogus <b> and </b> in popup hints" -- fixed. 2011-06-02 20:04:23 +00:00
Jordan Lee 9331a3cdac (trunk gtk) #4014 "409 error when opening .../transmission/web without trailing '/'" -- use suggestion from Mezz to have the "open web client" button in the GTK+ client follow the same URL as the Qt client 2011-05-28 01:34:07 +00:00
Jordan Lee a2432f17e4 (trunk gtk) #4254 "can't see description about Flags" -- fixed. 2011-05-28 00:12:59 +00:00
Jordan Lee c1d5b4a7e6 (trunk, GTK+/Qt) #4281 "Visualize seed progress like the web client does" -- done, with a modified patch & suggestion from mag 2011-05-28 00:09:15 +00:00
Jordan Lee 33eb6d3f9e (trunk) #3817 remove OS proxy integration from the GTK+ client 2011-05-27 13:36:53 +00:00
Jordan Lee 45bdc18210 (trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761 2011-05-02 17:58:27 +00:00
Jordan Lee 7069534abf (trunk, gtk) #4218 "open url should set focus on the open button by default" -- fix r12409 oops 2011-05-01 05:04:09 +00:00
Jordan Lee a9b379777f (trunk gtk) #4218 "open url should set focus on the open button by default" -- done. 2011-05-01 04:14:50 +00:00
Jordan Lee 0cff181c09 (trunk gtk) #4203 "gnome-network-properties doesn't exist in GNOME 3" -- fixed with patch from lesnoland 2011-04-30 16:22:03 +00:00
Jordan Lee 9753aa6183 (trunk gtk) in the details dialog, use the GQuark versions of g_object_{get,set}_data() 2011-04-29 21:36:44 +00:00
Jordan Lee c1273a03a4 (trunk gtk) tweak to r12398: because most of the strings in category_filter_model_update() will be duplicates of each other, use g_string_chunk_insert_const() instead of g_string_insert(). 2011-04-29 20:22:11 +00:00
Jordan Lee 53fede89f6 (trunk gtk) in filter.c's category_filter_model_update(), use a string chunk for all those temporary strings that are allocated in a looop 2011-04-28 23:13:14 +00:00
Jordan Lee b93bef2712 (trunk gtk) gtr_get_host_from_url(): avoid a couple of malloc() + free() calls. 2011-04-28 18:37:27 +00:00
Jordan Lee 6326003e73 (trunk gtk) very minor tweak in deciding which rows to update in the torrent model.
Since we only display speed to two decimal places, we don't need to compare previous and current torrent speed with more precision than that.
2011-04-20 01:16:16 +00:00
Jordan Lee fdbe7dc2da (trunk gtk) more heap pruning, in tr_core
Tweak how we loop through the torrents in the model, again to avoid unnecessary GtkTreePath temporaries.
2011-04-13 22:16:50 +00:00
Jordan Lee 6cd1dcb574 (trunk gtk) Avoid unnecessary GtkComboBox queries.
Instead of calling gtk_combo_box_get_active_iter() on the filterbar's two comboboxes in every periodic update, keep the state information in a local struct and update it when the selection changes. That way the filter code doesn't even need to know about the GtkComboBox or the GtkTreeModel.
2011-04-13 22:04:31 +00:00
Jordan Lee 1d7a4eb528 (trunk gtk) more heap pruning: minor GtkTreeModel changes
Use gtk_tree_model_iter_nth_child() instead of gtk_tree_model_get_iter_first() to avoid an unnecessary gtk_tree_path object being created and destroyed. This is a very minor change and I'm not sure how useful it really is, but it doesn't hurt.
2011-04-13 22:00:55 +00:00
Jordan Lee 01461d0b4a (trunk gtk) more heap pruning:
querying gconf2 each time the curl callack function is called is expensive, so query it once -- then again later, if the proxy settings change -- and remember the values in a local struct.
2011-04-13 06:18:30 +00:00
Jordan Lee 4a15899499 (trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer. 2011-04-12 11:13:41 +00:00
Jordan Lee b1459c5d3b (trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings 2011-04-12 10:51:52 +00:00
Jordan Lee b797f51144 (trunk gtk) more heap pruning: give torrent-cell-renderer an internal GString buffer so that we don't have to create & free so many short-term strings 2011-04-12 10:04:05 +00:00
Jordan Lee 4ce3555786 (trunk gtk) minor janitorial: const correctness in tr-core's compare_by_name() 2011-04-11 16:27:41 +00:00
Jordan Lee 07e60d1fc0 (trunk gtk) more heap pruning: use a GStringChunk for the collated torrent names in tr-core.c 2011-04-07 04:29:37 +00:00
Jordan Lee e02ce61d3e (trunk gtk) removed the unused MC_NAME column from the torrent GtkListStore. 2011-04-05 17:00:38 +00:00
Jordan Lee fb2ffbc542 (trunk gtk) use GQuarks instead of strings for keys in tr-icon and tr-window 2011-04-05 16:16:06 +00:00
Jordan Lee c213d91ffd (trunk gtk) use GQuarks instead of strings for keys in the filterbar's key/value pairs 2011-04-05 15:59:41 +00:00
Jordan Lee 708838b146 (trunk gtk) more heap pruning: in the main window's torrent list, only update the case-insensitive "collated name" of a torrent when the torrent's metadata changes (such as when a magnet link's metadata finishes downloading). 2011-04-05 15:41:51 +00:00
Jordan Lee afa016704f (trunk libT) more heap pruning: use a hash, rather than an allocated string in tr-core when watching for a torrent's tracker list to change 2011-04-05 01:36:37 +00:00
Jordan Lee d233ea82e7 (trunk gtk) more heap pruning: avoid unnecessary malloc() + free() calls in gtr_get_host_from_url() 2011-04-04 16:54:09 +00:00
Jordan Lee c16406bf7c (trunk gtk) remove "dead nested assignment" wart detected by clang static analyzer 2011-03-31 04:58:38 +00:00
Jordan Lee eb06d81fb9 (trunk) fix a handful of small memory leaks that valgrind found. 2011-03-25 17:42:47 +00:00
Jordan Lee bd88521332 (trunk) yet more "#include" tweaks 2011-03-25 15:03:42 +00:00
Jordan Lee b0379147d9 (trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5 2011-03-25 07:32:30 +00:00
Jordan Lee 4a1a4ebcc0 (trunk gtk) gtk_open_uri(): use gtk_show_uri() as the default implementation for GTK+ > 2.14.0.
gtk_show_uri() was added in 2.14.0
2011-03-25 06:40:46 +00:00
Jordan Lee 375694eda9 (trunk) copyediting: remove some unneeded #includes, and annotate some needed ones 2011-03-24 21:49:42 +00:00
Jordan Lee 433da8df9a (trunk gtk) gtr_compare_double() is only used in one place, so make it a private function there instead of leaving it public in utils.h 2011-03-24 18:32:05 +00:00
Jordan Lee a891136602 (trunk gtk) gtr_localtime() is only used in one place, so make it a private function there instead of leaving it public in util.h 2011-03-24 18:29:07 +00:00
Jordan Lee e46d0a72ba (trunk gtk) gtr_cell_renderer_get_padding() is only used in one place, so make it a private function there instead of leaving it public in util.h 2011-03-24 18:24:21 +00:00
Jordan Lee 5417711cd4 (trunk gtk) remove function gtr_strcmp0, which is redundant due to tr_strcmp0 2011-03-24 18:20:47 +00:00
Jordan Lee 0a1df687bb still trying to make hudson happy 2011-03-22 16:07:49 +00:00
Jordan Lee 034a65aaf1 (trunk gtk) revert r12201 to try & make hudson happy 2011-03-22 16:03:10 +00:00
Jordan Lee b4d36aeb54 (trunk) #4138 "use stdbool.h instead of tr_bool" -- done. 2011-03-22 15:19:54 +00:00
Jordan Lee e259d0abbe (trunk gtk) tweak Makefile.am 2011-03-21 20:45:50 +00:00
Jordan Lee 2544b4b228 (trunk gtk) dbus tweaks in Makefile.am based on examples from http://live.gnome.org/DBusGlibBindings .
1. tweak the way dbus-binding-tool is invoked... use --output=$@ $^

2. add the file generated by dbus-binding-tool to BUILT_SOURCES
2011-03-21 20:26:15 +00:00
Jordan Lee 374ed10f3b (trunk) it's bad form to #include so many system headers in libtransmission/utils.h... 2011-03-16 18:04:23 +00:00
Jordan Lee 591b95286f Show whether a tracker is http or udp. Without that context, it could be confusing to see the same tracker twice in a tier 2011-03-15 17:03:09 +00:00
Jordan Lee fee784f1d8 (trunk) #4081 "Add 'cookieString' argument 'torrent-add' method in RPC" -- done. 2011-03-15 04:22:47 +00:00
Jordan Lee 018585d3b0 (trunk gtk) fix condition that could crash in some cases when right-clicking in the file list menu. 2011-03-13 16:45:32 +00:00
Jordan Lee 55381159f6 (trunk gtk) #4075 "add x-scheme-handler/magnet to desktop file" -- fixed.
Thanks to ampelbein for the patch :)
2011-03-13 15:56:12 +00:00
Jordan Lee afe6d42ac1 (trunk gtk) when a tracker is manually added to a torrent, check the tracker's validity with tr_urlIsValidTracker() 2011-03-13 07:49:32 +00:00
Jordan Lee e45a6dabc9 (trunk gtk) fix 2.22+ time display regression in the GTK+ client. 2011-03-11 04:10:28 +00:00
Jordan Lee 9145bce9cd (trunk gtk) fix time display oops 2011-03-06 15:06:38 +00:00
Jordan Lee 05c39eaa3e add a missing icon 2011-03-06 05:41:41 +00:00
Jordan Lee 411b0bbd1a (trunk gtk) #4088 "Transmission needs 256x256 icon too" -- added large Tango icon by Andreas Nilsson. Thanks Andreas!
This larger icon is apparently needed for GNOME 3.
2011-03-05 19:15:37 +00:00
Jordan Lee 0a62f69f1c (trunk gtk) copyediting. 2011-03-04 15:49:51 +00:00
Jordan Lee ae20b67f16 (trunk gtk) remove unused code: gtr_warn_if_fail() 2011-03-04 15:21:00 +00:00
Jordan Lee 9c7caec13f (trunk gtk) minor copyediting for clarity/readability 2011-03-04 14:31:23 +00:00
Jordan Lee 9283ef2ebb (trunk gtk) #4080 "Toggling speed limit mode from the web interface doesn't affect GUI" -- fixed. 2011-03-04 05:58:32 +00:00
Jordan Lee c6dd0b0ed4 (trunk libT) fix tr_ctorFree() crash reported by Rolcol 2011-03-04 04:45:34 +00:00
Jordan Lee dcc070c86c (trunk gtk) some tr-core cleanup
Variable and function name cleanup; regrouping related functions together, etc.
2011-03-03 07:17:57 +00:00
Jordan Lee c7006ed8b3 (trunk gtk) remove the TrTorrent GObject subclass. 2011-03-03 01:59:25 +00:00
Jordan Lee 0a8535d9a5 (trunk gtk) #4040 "Show the torrent name in the Peers Tab's tooltips" -- done. 2011-02-19 13:04:09 +00:00
Jordan Lee db8b83854e (trunk gtk) Don't display uTP checkbox in non-uTP builds.
Tweak to r11976 s.t. the "Edit GNOME Proxy Settings" button doesn't get grouped in the "Peer Limits" section when uTP is disabled. :)
2011-02-19 09:30:06 +00:00
Jordan Lee 88a61d3b62 (trunk gtk) #4038 "Prefs dialog's blocklist section allows the 'update' button to be clicked when no blocklist is specified" -- fixed. 2011-02-19 09:02:39 +00:00
Juliusz Chroboczek ee86584263 Don't display uTP checkbox in non-uTP builds (gtk).
Reported by Rolcol.
2011-02-18 22:22:02 +00:00
Jordan Lee 3f1b060241 (trunk T) add preliminary enable/disable toggles in daemon, gtk, and qt clients. 'preliminary' because this may be widened to a tri-state of inabled, disabled, and incoming only 2011-02-18 00:33:29 +00:00
Jordan Lee 7df7d34f6d automake/autoconf; #includes in libtransmission 2011-02-18 00:32:19 +00:00
Juliusz Chroboczek bd0ea13701 (gtk) Add tooltip for uTP peers. 2011-02-18 00:24:33 +00:00
Jordan Lee 716a3c90c2 (trunk) #4032 "Better error detection / reporting in http announces" -- added to trunk.
This patch adds two new flags to the callback function -- did_connect and did_timeout -- that are calculated inside of web.c using information from libcurl. This allows the announcer to detect timeouts more accurately and also to distinguish between unresponsive peers (which get the preexisting "Tracker did not respond" error message) and unconnectable peers (which get a new error message, "Could not connect to tracker").
2011-02-17 02:26:24 +00:00
Jordan Lee dede299e04 (trunk gtk) #3866 "popup menu for file list manipulation" -- remove unused code in file-list.c
This code can be pulled back out of svn and readded if it's needed in the future.
2011-02-15 15:21:22 +00:00
Jordan Lee 72f9ab91fa (trunk) make tr_torrentName() a public function.
This has been a private function in libtransmission for awhile now but it makes more sense as a public function.
2011-02-15 15:18:51 +00:00
Jordan Lee 59e8348b15 (trunk gtk) #4012 "Cannot set individual seeding time in GTK+ client" -- fixed.
The code in gtk/details.c was still using the pre-release RPC key "seedInactiveLimit" when it should have been using "seedIdleLimit" instead.
2011-02-12 23:54:33 +00:00
Jordan Lee 62b732708a (trunk gtk) msgwin.c: silence compiler warning "warning: ‘pinned_to_new’ may be used uninitialized in this function" 2011-02-09 05:10:29 +00:00
Jordan Lee 24b9dc7dc2 (trunk gtk) #3866 "Popup menu for file list manipulation" -- removing from the 2.20 milestone
Looking over the 2.20 tickets, this one keeps sticking out. A popup menu may be useful if the "delete files" ticket is accepted in 2.30, but for this release (2.20) it doesn't really add anything new. One lesson from the 2.1x cycle was that features are a harder to remove than to add. So I'm going to hold off on adding this feature until it has a clear raison d'être.
2011-02-06 18:50:35 +00:00
Jordan Lee 1fabb9b9ea (trunk) #3675 "Not all .part files are removed" -- handle trashing files via RPC.
When libtransmission gets a "remove torrent" request from RPC, it tries to delegate the work. This is because the GTK+ and Mac clients don't want torrents disappearing in a different thread and causing possible thread issues. So the GTK+ and Mac clients get notification about this via libtransmission's RPC callback and remove the torrents themselves. Unfortunately, that notification doesn't include information about whether or not to delete local data.

This commit adds that information to the RPC callback so that the Mac and GTK+ clients will know whether or not to trash the local files when a third-party RPC client requests that at torrent and its files be deleted.
2011-02-06 17:30:46 +00:00
Jordan Lee c90ddfa1c3 (trunk libT) #3980 "segfault when adding many torrents remotely" -- possible fix.
gtk/main.c's onRPCChanged() is called from inside the libtransmission thread, yet it still made GTK+ calls to modify the GTK+ client's tr-core object when a torrent was added. This caused a race condition inside of the GTK+ internals. onRPCChanged() already knows to delegate work back to the GTK+ thread when a torrent is removed via RPC. This commit uses the same kind of mechanism to delegate work back to the GTK+ thread when a torrent is added via RPC.
2011-02-05 05:03:00 +00:00