Commit Graph

14457 Commits

Author SHA1 Message Date
Charles Kerr 50cb57784e
build: use GitHub actions to check code-style (#3138) 2022-05-26 07:38:20 -05:00
Charles Kerr 46eb379205
fix: ESPIPE "illegal seek" error while seeding (#3137)
* fix: ESPIPE "illegal seek" error while seeding

The root cause is createSocket returning `{}` instead of `TR_BAD_SOCKET`
when we have too many peers in use. This defaulted to fd 0, which wound
up closing stdin.

Commit also includes some const-correctness changes made while tracking
the problem down.
2022-05-25 18:16:15 -05:00
orbital-mango b4624cc775
fix: GTK file list size and progress % regression (#3127) 2022-05-25 13:27:33 -05:00
Gary Elshaw 0ce8777d1f
MacOS Transmission icons for Web (#3130) 2022-05-25 10:46:13 -05:00
Gary Elshaw d6a5f1462c
MacOS Transmission icons for QT (#3128) 2022-05-24 21:18:08 -05:00
Gary Elshaw de4148a697
chore: update GTK client icon to match Big Sur icon 2022-05-24 19:04:56 -05:00
Charles Kerr 79cd776f37
deps: use libdeflate 1.11 (#3134) 2022-05-24 17:50:09 -05:00
Charles Kerr 26b1a9154e
fix: silence unexpected key warnings in torrent file parser (#3133) 2022-05-24 15:28:02 -05:00
Isabella Skořepová 1cae467acd
add magnet link support to transmission web (#2874) 2022-05-23 23:55:33 -05:00
Charles Kerr fe288b45e5
perf: do not use tr_variant when parsing .torrent files 2022-05-23 23:05:16 -05:00
Charles Kerr 19db28c04d
perf: faster detection of invalid filenames (#3126)
* refactor: move file_info into tr_torrent_files

* chore: rename files-test as torrent-files-test.cc

* test: add tests for tr_torrent_files::isSubpathPortable()
2022-05-23 17:53:26 -05:00
orbital-mango 0f29958751
Show torrent added date/time in details dialog (GTK). (#3124)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-23 11:09:21 -05:00
sewe2000 4617776253
Add new information about when torrent was added to transmission in the Information Tab in transmission-qt (#3121) 2022-05-23 00:02:46 -05:00
Charles Kerr 67a078402d
fix: compiler warnings (#3123)
* fix: unused function warning tr_rpc_address_is_valid

* fix: unused variable warning old_byte_pop

* fix: method-can-be-made-static warning assertValidRules

* fix: signed-unsigned comparison warning

* fix: invalid case style warning for KBps

* chore: disable warning for static class member varaible
2022-05-22 21:22:34 -05:00
Charles Kerr c0bb2d40f1
refactor: add pathbuf and std::string-friendly helpers to tr_sys file and path funcs (#3118)
* refactor: add sv-friendly tr_sys_dir_create() variant

* refactor: add sv-friendly tr_sys_path_get_info() variant

* refactor: add sv-friendly tr_sys_path_exists() variant

* refactor: add sv-friendly tr_sys_path_remove() variant

* refactor: add sv-friendly tr_sys_path_rename() variant

* fixup! refactor: add sv-friendly tr_sys_path_rename() variant
2022-05-21 20:17:00 -05:00
Charles Kerr 690cf50e53
perf: tr_sys_path_dirname() returns a std::string_view (#2990)
* refactor: use nodejs impl of path.win32.dirname()

* refactor: use nodejs impl of path.posix.dirname()
2022-05-21 11:10:58 -05:00
A Cœur 2e25370cc5
Fix QuickLook (#3001)
* Fix QuickLook symbol not found; add file sort and filesize
2022-05-19 23:07:17 -05:00
Charles Kerr f71ace588f
fix: assertion failed: task->loc.byte <= task->end_byte (#3109) 2022-05-18 15:49:40 -05:00
Antoine Cœur 3c056001b1
support pasting multiple magnet links (#3087) 2022-05-16 23:48:39 -05:00
Charles Kerr a28b07b390
Revert "refactor: move tr_torrent callbacks to tr_session (#3003)" (#3104)
This reverts commit 27fbfd8da6.

Fixes #3088.
2022-05-16 13:48:43 -05:00
Antoine Cœur e23a4b3589
refactor copyMagnetLinks (#3086) 2022-05-16 12:08:20 -05:00
Charles Kerr e286e45ac8
fixup! refactor: use smaller integral types in some structs (#3005) (#3096)
fix GTK client file progress % regression

Fixes #3063.
2022-05-16 09:06:18 -05:00
Charles Kerr 2293f4336a
perf: use fast_float to parse floating-point numbers (#3092) 2022-05-16 00:06:17 -05:00
Charles Kerr ebd1a0b7bf
deps: update web client build deps (#3095)
* deps: change web build-dep from node-sass to sass

https://sass-lang.com/blog/libsass-is-deprecated and dart sass is the
recommended replacement.

* deps: yarn upgrade-interactive

* deps: update babel dep to 7.17

* deps: update eslint

* deps: update prettier

* deps: update svgo

* deps: update webpack to 5.72.1

* deps: update webpack-bundle-analyzer to 4.5.0

* deps: update webpack-cli to 4.9.2

* deps: update webpack-dev-server from 3.11.3 to 4.9.0

* deps: replace svgo, svgo-loader, url-loader with webpack asset/inline

* chore: rename "style" dir as "assets"

* deps: update stylelint from 13.13.1 to 14.8.2

* deps: bump terser-webpack-plugin from 5.1.4 to 5.3.1

* deps: bump css-loader from 5.2.7 to 6.7.1

* deps: bump css-minimizer-webpack-plugin from 3.0.2 to 3.4.1

* deps: bump mini-css-extract-plugin from 1.6.2 to 2.6.0
2022-05-15 20:49:25 -05:00
Dmytro Lytovchenko aa502f9312
Modernize blocklist.cc: Rename, move members inside struct (#2010)
* Modernize blocklist.cc to C++

* Modernize blocklist.cc: Renamed BlocklistFile struct and moved IPv4 range struct inside it

 Modernize bandwidth.cc: Review notes; Promote container of blocklists in session to vec of unique_ptrs
2022-05-15 11:32:22 -05:00
Antoine Cœur 25ef121d71
Add "Verify Local Data" to context menu (#3025) 2022-05-14 21:14:54 -05:00
Antoine Cœur 60254710b8
Rename sortTorrentsAndIncludeQueueOrder and nonEmptyComponentsSeparatedByCharactersInSet (#3051)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-14 14:00:55 -05:00
SweetPPro 82bede40d1
fix for macOS "Stay within the global bandwith limits" always displaying true (#3079) 2022-05-14 12:57:22 -05:00
Charles Kerr 36e6d4ed07
chore: remove unused header fdlimit.h (#3084) 2022-05-14 11:17:55 -05:00
Charles Kerr 27fbfd8da6
refactor: move tr_torrent callbacks to tr_session (#3003)
* refactor: move tr_torrent callbacks to tr_session

* Support tr_sessionSet* (#3044)

Co-authored-by: Antoine Cœur <coeur@gmx.fr>
2022-05-14 10:00:13 -05:00
Antoine Cœur c1f5911fc7
'beginSheet:modalForWindow:modalDelegate:didEndSelector:contextInfo:' is deprecated: (#3031)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-14 08:20:56 -05:00
Antoine Cœur 340f88bc12
Fix "The left operand of '<' is a garbage value" (#3042) 2022-05-14 02:53:30 -05:00
wiz78 79274bb335
macOS: disable App Nap. Fixes #577 (#874)
* disable App Nap

* Update Controller.m

merged with upstream changes

* Delete Controller.m

* chore: code-style.sh

Co-authored-by: Simone Tellini <wiz78>
Co-authored-by: Simone Tellini <simone@Argon.local>
Co-authored-by: Simone Tellini <simone@tellini.info>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-14 01:57:20 -05:00
Antoine Cœur 5d52da8726
Address format conversion warnings in localizations (#3059) 2022-05-14 00:31:24 -05:00
Antoine Cœur 659969a436
Fix Display window option incorrectly enabled on start (#3056) 2022-05-13 21:27:31 -05:00
Antoine Cœur 67f6562ae4
Updating group icon style for newer macOS (#3065) 2022-05-13 19:54:10 -05:00
Antoine Cœur 7ab2fbfbd6
Adopting .clang-format-include and .clang-format-ignore (#3047) 2022-05-13 18:48:33 -05:00
Antoine Cœur 5026d43920
Add ⌘C support (#3072) 2022-05-13 16:03:07 -05:00
ewtoombs 7b34c09f26
Wrote a guide on headless usage. (#3049)
The guide uses `transmission-daemon` and `transmission-remote`. It makes some
basic security recommendations, but it does not include instructions for system
integration, i.e. systemd, etc.
2022-05-13 10:20:57 -05:00
Antoine Cœur d5533ee648
Fix "Port checker returned invalid status: 0" (#3064)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-10 09:54:39 -05:00
Antoine Cœur e7312eba14
Rename "Remove Data File" to "Trash Data File" (#3057) 2022-05-08 20:47:56 -05:00
Mitch Livingston 53b3a6517a
Merge pull request #3053 from Coeur/coeur/customGroups 2022-05-06 07:21:41 -04:00
Cœur 1f419a3a6f Fix retrieving groups with predicates 2022-05-05 16:14:06 +08:00
Antoine Cœur d3e1c83c9b
Address build warnings (#3052) 2022-05-04 18:54:41 -05:00
Antoine Cœur a57d265968
Set recommended CODE_SIGN_IDENTITY and PRODUCT_BUNDLE_IDENTIFIER (#3043) 2022-05-01 16:55:09 -05:00
Antoine Cœur 9069e4c910
Fix TeamCity Code Style (#3045) 2022-05-01 13:06:32 -05:00
Antoine Cœur d498aa1ae1
The left operand of '+' is a garbage value (#3041) 2022-05-01 07:26:45 -05:00
Charles Kerr 88a0b292d9
fixup: fix fd regression in tr_open_files (#3036)
Fixes #3032.
2022-04-30 23:30:49 -05:00
Charles Kerr 4cc952f0ca
fixup! fixup! fix: ensure all bytes read / written to file (#2682) (#2780) (#3035)
fix spurious tr_error being set when reading up to eof

Fix error introduced in the previous fixup :P
2022-04-30 18:43:32 -05:00
Charles Kerr c8f5cff564
fixup! fixup! fix: ensure all bytes read / written to file (#2682) (#2780) (#3033)
fix spurious tr_error being set when reading up to EOF.

This regression generated invalid error messages when no error occurred.
2022-04-30 16:57:11 -05:00