Charles Kerr
8a35aa0903
refactor: add tr_rand_obj() ( #4238 )
...
* refactor: add tr_rand_obj()
There are a lot of places in the codebase where we need to populate
an integral type or a fixed-size array with random data. To do this,
we instantiate a local on the stack, fill it with tr_rand_buffer(),
and then use it.
This PR creates a helper function to make this a one-liner.
2022-11-25 15:04:37 -06:00
A Cœur
342484d14a
refactor: log UTP_ETIMEDOUT errors to 'trace' messages ( #4237 )
2022-11-25 14:44:49 -06:00
A Cœur
6b861806a6
Fix building with cmake on macOS Mojave ( #4234 )
2022-11-24 11:20:48 -06:00
Charles Kerr
554ba06ae2
fix: coverity warnings, sonarcloud code smells ( #4232 )
2022-11-24 10:17:02 -06:00
A Cœur
ead71e8fd3
Fix building on macOS Mojave ( #4231 )
2022-11-24 01:14:20 -06:00
Charles Kerr
29090d6590
fixup! refactor: remove unused vars, code simplify and minor optimize ( #4172 ) ( #4230 )
...
set the converter state in isValidUtf8()
2022-11-24 01:12:01 -06:00
A Cœur
3ecf0dfccd
Fix "NSFilenamesPboardType is deprecated" ( #4221 )
2022-11-23 17:09:32 -06:00
A Cœur
b612020576
Support UserNotifications framework ( #3040 )
2022-11-23 13:47:56 -06:00
Charles Kerr
19bc15523f
fix: new sonarcloud, coverity, gcc warnings ( #4229 )
2022-11-23 13:47:04 -06:00
Charles Kerr
6cd6f78a9f
fix: eta display in GTK client details dialog ( #4227 )
2022-11-23 09:14:05 -06:00
Charles Kerr
046ba32d33
fixup: heap-use-after-free in announce, scrape response on shutdown ( #4228 )
...
fixes #4222 .
2022-11-23 01:38:31 -06:00
Charles Kerr
a8f2b840f7
perf: improve tr_peerMgrGetDesiredAvailable() ( #4226 )
2022-11-22 23:26:10 -06:00
Charles Kerr
40c7f5bceb
perf: constexpr and move work outside of loops ( #4224 )
2022-11-22 14:00:09 -06:00
Charles Kerr
43c57fb02a
perf: buffer iterators ( #4220 )
2022-11-21 23:54:28 -06:00
A Cœur
191c6d1402
fix: SecKeychain is deprecated ( #4190 )
2022-11-21 23:14:10 -06:00
Charles Kerr
a3772dc1fa
refactor: aggregate dh in peer io ( #4218 )
2022-11-21 18:08:06 -06:00
A Cœur
d26db72d7e
Fix "Implicit conversion loses integer precision" ( #4194 )
2022-11-21 10:19:45 -06:00
Charles Kerr
76bea25f6e
perf: minor perf wins ( #4216 )
...
* perf: faster tr_buffer::toString()
* perf: faster tr_buffer::Iterator
* perf: get mutex lock in reconnectPulse() instead of closeBadPeers()
2022-11-21 09:28:46 -06:00
Herman Semenov
ffd5e6bf50
refactor: remove unused vars, code simplify and minor optimize ( #4172 )
2022-11-19 09:46:03 -06:00
A Cœur
292b092f54
Fix hang in CSBackupSetItemExcluded ( #4208 )
2022-11-19 08:50:13 -06:00
Charles Kerr
d27c4c59ce
refactor: incremental announcer refactor pt. 2 ( #4214 )
2022-11-18 23:00:25 -06:00
dependabot[bot]
62cad53df8
build(deps): bump loader-utils from 2.0.3 to 2.0.4 in /web ( #4212 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v2.0.3...v2.0.4 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-18 22:32:38 -06:00
A Cœur
a187529f93
typo ICP -> TCP ( #4213 )
2022-11-18 21:53:16 -06:00
A Cœur
a152d0f6d8
Appropriate and improve VDKQueue ( #4202 )
2022-11-18 13:53:36 -06:00
A Cœur
6fcdb526c7
Fix crash on torrent filenames in non-UTF-8 encoding ( #4144 )
2022-11-18 10:03:25 -06:00
Charles Kerr
4cc0b77eec
refactor: incremental announcer improvements ( #4211 )
2022-11-17 20:23:54 -06:00
Charles Kerr
f17cee97e5
fix: nullptr crash in peer-io ( #4210 )
2022-11-17 14:53:08 -06:00
A Cœur
9035f2297a
Fix incorrect build hash when building with Xcode ( #4195 )
2022-11-17 09:17:16 -06:00
Charles Kerr
42f26aad0b
fix: ftbfs on Windows ( #4204 )
2022-11-16 18:03:48 -06:00
Charles Kerr
a45cc2a79d
refactor: try again to use getaddrinfo in announcer_udp ( #4201 )
2022-11-16 15:13:31 -06:00
A Cœur
7a2d2ff0cf
Fix cmake CFBundleVersion and LSMinimumSystemVersion ( #4185 )
...
* Fix cmake CFBundleVersion and LSMinimumSystemVersion
* code review: use CMAKE_OSX_DEPLOYMENT_TARGET
2022-11-16 13:40:19 +00:00
Mike Gelfand
812588100d
Calculate percent done in range 0..100 instead of 0..1 (GTK client) ( #4191 )
2022-11-16 10:14:09 +00:00
Mike Gelfand
ac6010557e
Fix issues reported by clang-tidy bugprone checks (GTK client) ( #4183 )
...
* Fix `bugprone-unchecked-optional-access` clang-tidy issues
* Fix `bugprone-easily-swappable-parameters` clang-tidy issues
* Extend clang-tidy configuration
2022-11-15 19:30:32 +00:00
Charles Kerr
d2125ee965
perf: revert e065565cd to restore async dns lookups ( #4182 )
2022-11-15 11:16:49 -06:00
A Cœur
befeafbcfe
hook action in the xib ( #4135 )
2022-11-15 10:50:16 -06:00
Charles Kerr
22c14c9266
fix: sonarcloud warnings ( #4180 )
2022-11-15 10:25:12 -06:00
Charles Kerr
d0639b5f0c
perf: tr_sys_path_basename() returns a std::string_view ( #4176 )
2022-11-15 08:29:00 -06:00
Charles Kerr
134363d83d
fixup! refactor: decouple session settings from the session class ( #4053 ) ( #4175 )
...
fixes #4134
2022-11-14 19:10:19 -06:00
Mike Gelfand
2bd6c8aff4
Fix issues reported by clang-tidy cert checks (GTK client) ( #4174 )
...
* Fix `cert-err33-c` clang-tidy issues
* Fix `cert-str34-c` clang-tidy issues
* Fold free-standing functions into `FilterBar::Impl`
This is in preparation to next commit fixing `cert-err58-cpp`.
* Fix `cert-err58-cpp` clang-tidy issues
* Extend clang-tidy configuration
2022-11-15 00:53:12 +00:00
Charles Kerr
5cb9e8c146
test: increase timer interval in TimerTest.repeatingThenSingleShot ( #4173 )
...
These 25ms timers are not repeatable enough on the CI boxes
2022-11-14 18:04:15 -06:00
Charles Kerr
6bec2f22c8
fix: 4.0.0-beta.1 wrong RPC response for group-get ( #4171 )
2022-11-14 16:31:41 -06:00
Charles Kerr
8df26dd2fc
refactor: re-enable some clang tidy warnings in tests ( #4170 )
2022-11-14 14:16:29 -06:00
A Cœur
bde1359d5d
Adopt localizedStringWithFormat for displayed quantities ( #4109 )
...
* Adopt localizedStringWithFormat for displayed quantities
* xib internationalization support is done
2022-11-14 18:30:03 +00:00
Mike Gelfand
1d9159fffc
Fix incorrect selection behavior when building against GTK 4 ( #4168 )
...
View-relative coordinates were treated as bin window-relative, leading to
incorrect selected item calculation.
Broken since the introduction of GTK 4 support in #3916 .
2022-11-14 18:27:15 +00:00
Mike Gelfand
f8d981349e
Fix issues reported by clang-tidy misc checks (GTK client) ( #4167 )
...
* Fix `misc-const-correctness` clang-tidy issues
* Fix `misc-no-recursion` clang-tidy issues
* Extend clang-tidy configuration
2022-11-14 16:22:38 +00:00
A Cœur
caefebd102
remove duplicate Portuguese ( #4141 )
2022-11-14 15:53:57 +00:00
Mike Gelfand
c9debcfd48
Sync translations ( #4161 )
...
* Sync translations with code
* Sync translations with Transifex
2022-11-14 09:48:42 +00:00
Charles Kerr
f9a6df6f41
refactor: use a condition_variable when removing a torrent from the verifier thread ( #4166 )
2022-11-13 23:11:48 -06:00
A Cœur
855b782604
Accessibility description for images ( #4149 )
2022-11-13 21:39:34 -06:00
Charles Kerr
67e992ddf0
refactor: better TR_CURL_SSL_NO_VERIFY ( #4159 )
...
clear CURLOPT_CAINFO, CURLOPT_CAPATH iff verification is disabled
2022-11-13 17:17:16 -06:00
