Commit Graph

1891 Commits

Author SHA1 Message Date
Mike Gelfand f701d501a8 Move generic macros to a separate tr-macros.h file 2017-06-18 17:11:20 +03:00
Fish2 b0e3d4c37d lossless compression of images saved 72KB 2017-06-03 23:52:34 +01:00
Mike Gelfand 8f3cb1c68d Wrap sizeof arguments in braces 2017-05-20 19:29:23 +03:00
Mike Gelfand 7a1a1acd22 Fix autotools build 2017-05-17 00:56:39 +03:00
Mike Gelfand ef8cb30f7c Merge pull request #224 from wjt/appdata
gtk: add AppData file
2017-05-16 23:13:25 +03:00
Mike Gelfand 1e3d20422a Reduce for loop variables scope 2017-05-14 01:38:31 +03:00
Will Thompson 23d61b6457
gtk: add AppData file
This file was originally written by Richard Hughes, for Fedora, who
proposed it on the Transmission forum here:
https://forum.transmissionbt.com/viewtopic.php?f=3&t=16443

It's used to display a nice description and screenshot in GNOME
Software. The format is documented here:
https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html

The <_name/> and <_summary/> fields match the Name= and Comment= fields
in the .desktop file so are already translated.

The screenshot is taken with Transmission 2.92 (14714) on Fedora 25.
It's at one of the sizes recommended by the GNOME Shell Screenshot
Window Sizer extension.

The <update_contact/> is based on the Git history.
2017-05-03 17:43:23 +01:00
Mike Gelfand b99fb6f07a Add queue up/down hotkeys (GTK+ client) 2017-05-01 18:58:27 +03:00
Mike Gelfand 14370e5353 Fix a number of other style inconsistencies met along the way (part 2) 2017-05-01 18:47:49 +03:00
Mike Gelfand e1d53855f4 Avoid declaring multiple variables on the same line 2017-05-01 18:46:41 +03:00
Mike Gelfand fbd8d4c79f Fix a number of other style inconsistencies met along the way 2017-04-30 19:33:55 +03:00
Mike Gelfand a762c770f2 Make conditional expressions explicitly boolean 2017-04-30 19:26:01 +03:00
Mike Gelfand 4f9d9ad92b Code style change leftovers
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand dadffa2c0f Align type qualifiers to the right (code style)
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand d7930984ef Adjust uncrustify config, reformat all but Mac client
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand ecd1eb7914 Update file icon when its name changes in details dialog (GTK+ client)
Additionally, make main window redraw the torrent so that new name and icon
are visible right away.
2017-02-21 23:21:25 +03:00
Piotr Drąg 297c734c0b Add Keywords to the .desktop file
It's a part of the Desktop Entry Specification [1] and it's used by,
among others, the search system in GNOME 3.

The comment is there to hopefully minimize the chance of translators
making a mistake that could potentially break build.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
2017-01-29 01:13:53 +01:00
Piotr Drąg 5cefddeaee Remove X-GNOME-FullName from the .desktop file
It's a GNOME-specific hack for the 2.x era menu system that was never
standardized in [1] and is now unused in GNOME 3.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
2017-01-28 23:52:32 +01:00
Mike Gelfand 5f3abbd6d8 Add myself to the list of Transmission authors 2017-01-15 01:38:45 +03:00
Markus Amalthea Magnuson 5b9ba3be0d HTTPS links for trac, forum, portcheck, and build subdomains. 2016-11-02 20:50:22 +01:00
Markus Amalthea Magnuson 727b9671f7 Update all website links to canonical HTTPS version. 2016-10-31 10:00:11 +01:00
Robert Vehse 13bae8179e Update all instances of the donation link. Fixes #26. 2016-09-23 04:36:41 +02:00
Mike Gelfand 2248d3670f Get rid of $Id$ SVN keywords in source files 2016-09-02 23:10:15 +03:00
Jordan Lee 1af60ad6ad use '#pragma once' instead of #ifndef..#define..#endif guards 2016-03-29 16:37:21 +00:00
Mike Gelfand c955c04d8f Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean 2016-03-13 22:11:01 +00:00
Mike Gelfand 197fc132b3 Update user-facing copyright years 2016-02-27 23:18:02 +00:00
Mike Gelfand 495e9b2fa0 Load icons with GResource, remove deprecated inline pixbufs 2016-02-23 04:34:57 +00:00
Mike Gelfand 939b31ae3d #6051: `transmission-gtk --version` shouldn't require display 2016-01-09 18:06:17 +00:00
Mike Gelfand 13a98a02b8 Use `TR_BAD_SIZE` instead of -1 in `tr_quark_new()` calls
Extend quark test to improve branch coverage.
2016-01-07 19:20:14 +00:00
Mike Gelfand 4f266a5b15 Optimize URL-parsing functions a bit; rewrite `tr_urlParse()` 2015-12-28 23:52:26 +00:00
Mike Gelfand 4a4badd4af Ongoing refactoring (use size_t instead of int) 2015-12-25 10:19:50 +00:00
Mike Gelfand bfc336614e Add libevent include directories to GTK+ client 2015-12-12 18:46:39 +00:00
Jordan Lee b559a20029 const correctness
silence some qual-cast warnings by sprinkling more consts throughout,
e.g. casting a const void* to a const struct foo * const *
2015-12-06 22:13:10 +00:00
Jordan Lee f3cebc6663 link transmission-gtk against libappindicator if necessary 2015-12-06 16:12:27 +00:00
Mike Gelfand 88983c1ac1 Use tr_sys_path_remove instead of remove 2015-10-23 04:09:40 +00:00
Mike Gelfand f89fab72f9 Remove unused session tag 2015-10-18 18:39:14 +00:00
Mike Gelfand 18ea8c429a Improve RPC performance for local sessions
Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Mike Gelfand 2e6d5c8bc9 Add more booleans to the picture 2015-05-31 22:13:31 +00:00
Mike Gelfand cdf3cf62f9 Fix some issues revealed by coverity 2015-05-09 11:56:35 +00:00
Mike Gelfand 2321bc3fad Fix some issues revealed by coverity 2015-05-09 08:37:55 +00:00
Mike Gelfand 363069ff97 #5930: Fix style of Gtk+3.16 overshoot and undershoot (patch by nagisa) 2015-05-03 10:30:35 +00:00
Mike Gelfand 06d73853b9 Even better (and unified) torrent origin logic for GTK+, Qt and web clients 2015-04-22 21:04:49 +00:00
Mike Gelfand 829cbffaf7 Add version info to executables (on Windows). Group projects into folders (CMake). 2015-04-14 22:46:40 +00:00
Mike Gelfand c7d2a7f959 #4400: Add CyaSSL support 2015-01-07 02:04:08 +00:00
Mike Gelfand c43a10ab9d Mark GTK and Qt clients as GUI programs on Windows (detach from console) 2015-01-04 10:57:09 +00:00
Mike Gelfand 440f482d01 Replace tabs with spaces; remove trailing spaces 2015-01-02 11:15:31 +00:00
Mike Gelfand b928ae1ba8 Use libb64 instead of OpenSSL to encode/decode BASE64
Some crypto libraries (like CyaSSL, MatrixSSL and CommonCrypto) either
don't have or expose this functionality at all, expose only part of it,
or (like OpenSSL) have heavyweight API for it. Also, for the task as
easy as BASE64 encoding and decoding it's much better to use small and
simple specialized library.
2015-01-01 21:16:36 +00:00
Mike Gelfand 83c4edb008 #5828: Initial CMake build system support 2014-12-01 19:55:22 +00:00
Jordan Lee b325bc0a16 (trunk) #5759 compilation error, undefined reference to sqrt 2014-08-20 17:14:17 +00:00
Jordan Lee ab24ef9fcb use pkg-config to get the zlib cflags/libs; remove obsolete zlib.m4 macro 2014-07-13 21:54:56 +00:00
Jordan Lee 0323639e57 (trunk, libT) #4160 'foreign character support' -- merge mike.dld's 4160-02b-path.patch, which updates the codebase to use the new tr_sys_path_*() portability wrappers introduced in 4160-02a 2014-07-08 00:08:43 +00:00
Jordan Lee d7368a58f5 Copyedit the license's revised text: (1) fix accidental word concatenations in the Qt and GTK+ clients' license popup text 2014-01-21 03:15:33 +00:00
Jordan Lee 02cff80c2d Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text 2014-01-21 03:10:30 +00:00
Jordan Lee 5f2daaafb3 (trunk, gtk/qt/web) #5581: 'Inconsistent ordering of Upload and Download speed limits' -- fixed. 2014-01-20 23:56:06 +00:00
Jordan Lee bf85441aab remove '-DGTK_DISABLE_DEPRECATED' for now; we'll migrate from GtkUIManager to GtkBuilder in transmission-gtk 2.90 2014-01-20 21:30:41 +00:00
Jordan Lee 4b9626bb83 Licensing changes:
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed

2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)

3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
Jordan Lee 4904b923fb (trunk) restore copyright year as suggested in email by rms 2014-01-18 20:56:57 +00:00
Jordan Lee 4c8bda8805 function pointer type correctness. mikedld 2013-09-08 17:08:18 +00:00
Jordan Lee 28fe36f1f8 #include limits.h where we use it, and don't where we don't 2013-08-24 17:53:45 +00:00
Jordan Lee 229f9e5ae6 (trunk, gtk) #5450: in transmission-gtk's main.c::on_app_exit(), check to see if shutdown's already been initiated so that we don't call tr_sessionClose() twice. 2013-08-05 02:39:30 +00:00
Jordan Lee 33795457b1 (trunk, gtk) #5032 'gobject warning' -- fix typo introduced in r14144 2013-07-27 18:20:32 +00:00
Jordan Lee 14c0256861 (trunk, gtk) #5032 'gobject warning when updating blocklist from URL' -- fixed with patch from fanatid 2013-07-24 17:20:21 +00:00
Jordan Lee 16ab373503 (trunk gtk) #5320 'can't opena folder with '#' in its name': in gtr_open_file(), use g_file_new_for_path(). 2013-07-24 17:11:21 +00:00
Jordan Lee cc1b1cd430 since Transmission supports older versions of glib, add a portability wrapper for G_DEFINE_QUARK 2013-07-24 00:13:31 +00:00
Jordan Lee 6a47b4a5d3 don't use a '-' character in the QN argument to G_DEFINE_QUARK. https://forum.transmissionbt.com/viewtopic.php?p=65548#p65548 2013-07-22 23:00:10 +00:00
Jordan Lee f83ff36cd5 (trunk gtk) use G_SOURCE_REMOVE where appropriate 2013-07-20 16:37:59 +00:00
Jordan Lee 7cbb20279b use consistent code indentation/whitespace in open dialog, file list, and set location dialog 2013-07-20 16:19:15 +00:00
Jordan Lee 2d6ace29ba (trunk, gtk) #5430: periodic update timer in 'Torrent > Set Location...' should be cleared immediately when dialog is closed. 2013-07-20 15:55:29 +00:00
Jordan Lee 94fd3b486b (trunk) slightly better image compression by passing them through pngwolf 2013-07-14 23:03:31 +00:00
Jordan Lee d244545979 use G_DEFINE_QUARK instead of rolling our own quark getters 2013-07-09 22:44:24 +00:00
Jordan Lee 7f9f86c55a fix a minor GAppInfo memory leak in transmission-gtk 2013-07-08 19:34:58 +00:00
Jordan Lee 59af132947 replace deprecated gtk_icon_info_free() calls with g_object_unref() in GTK+ >= 3.8.0 2013-07-08 16:25:18 +00:00
Jordan Lee 59f27cc1c6 remove the ShowOnlyIn=Unity desktop entries. These were from bug #4804 as an interim measure until XDG action groups were more widely supported, and can be removed. 2013-07-02 21:20:33 +00:00
Jordan Lee a95b6c1e6c (trunk) #5382: better compression of our bundled png files. recompressed by Mangix 2013-06-26 02:06:43 +00:00
Jordan Lee beeb4d3b77 (trunk, gtk) minor fix to tr_prefs_init_default() -- avoid redundant calls to g_get_user_special_dir 2013-06-12 00:22:41 +00:00
Jordan Lee 027e3f3066 (trunk, libT) #4682 'Add return id from duplicate torrent torrent-add rpc' -- added. 2013-05-22 20:35:38 +00:00
Jordan Lee 96786b7fa1 (trunk) update web.h's API s.t. there's an explicit function to use when downloading webseed content. 2013-04-13 20:25:28 +00:00
Jordan Lee c51132ad78 #5335: better compression of .png files by Mangix 2013-04-10 02:27:42 +00:00
Jordan Lee 0abb762ed5 segfault when opening prefs dialog in gtk+ 3.8.0 2013-04-10 02:12:19 +00:00
Jordan Lee d1571bda02 (gtk) use replace strcmp() with g_strcmp0() everywhere 2013-02-14 15:17:42 +00:00
Jordan Lee 76a3b116f0 use g_strcmp0() instead of strcmp() to guard against corrupt settings in the config file 2013-02-10 23:06:05 +00:00
Jordan Lee 90b95697e0 (gtk) #5284 'file tree should show the wanted size of the subtree, not the entire size': done. 2013-02-09 19:28:38 +00:00
Jordan Lee cd09204a6e (trunk) first draft of changing the FreeSpace API to behave as https://trac.transmissionbt.com/ticket/4076#comment:25 -- libT, rpc, qt, and gtk implementations. 2013-02-09 04:05:03 +00:00
Jordan Lee d76d2a34d9 (gtk) match transmission-qt's way of showing up & down speeds in the statusbar 2013-02-08 01:34:59 +00:00
Jordan Lee 445609f690 (trunk) prefer tr_remove() to unlink() or rmdir() 2013-02-04 21:53:19 +00:00
Jordan Lee 1a768ab06f (gtk) #5271 'once we start shutting down the application, stop updating the Action states': more safeguards 2013-02-04 18:34:39 +00:00
Jordan Lee 2e251f73cb (gtk) #5246 'problems when incomplete-dir is a subdirectory of download-dir': change the file chooser API calls, based on suggestion from kraai 2013-02-04 16:51:52 +00:00
Jordan Lee 0c8c2b5bdd (gtk) #5271 'once we start shutting down the application, stop updating the Action states': fixed 2013-02-04 16:11:08 +00:00
Jordan Lee 1c90e929d1 (gtk) #4076 'free space indicator': tweak the GTK+ client's visible count label's behavior as the previous commit did for the Qt client 2013-02-02 23:01:33 +00:00
Jordan Lee 085c37584e #4076 'free space indicator': in the Qt and GTK+ clients, add 'Free' to the freespace labels to give more context of what the number means 2013-02-01 21:02:40 +00:00
Jordan Lee 16d46a72a1 in the Qt and GTK+ clients, move the torrent count indicator from the statusbar to the filterbar 2013-02-01 20:58:55 +00:00
Jordan Lee 69f3e31230 (libT) change the API signature for tr_torrentVerify() s.t. client code can be notified when the verify is finished 2013-01-31 21:58:25 +00:00
Jordan Lee a4bbceb483 fix r13896 oops 2013-01-30 00:28:53 +00:00
Jordan Lee 20fe66bccf more experimentation with the shortTransferString 2013-01-30 00:22:52 +00:00
Jordan Lee 4a059b79b8 when sorting by activity and both torrents' upload and download speed is zero, use how many peers we're ready to upload to / download from as a secondary key. 2013-01-30 00:20:51 +00:00
Jordan Lee 1d3bf93618 synchronize the Qt and GTK+ client's statusbars, including the new freespace indicator. Make the up/down speed ordering consistent between statusbar and torrent list. 2013-01-27 23:05:47 +00:00
Jordan Lee f75027d5e9 make all the log functions/structs/enums use a single 'tr_log' namespace, such as tr_logGetQueue, tr_logAddInfo, tr_logIsLevelActive 2013-01-25 23:34:20 +00:00
Jordan Lee 29d6f5d934 (gtk) #5190 'Add borders instead of shadow on scrolled window': fixed, patch by nagisa 2013-01-21 17:05:55 +00:00
Jordan Lee dc42791380 (gtk) remember to clear out the error pointer 2013-01-21 03:18:44 +00:00
Jordan Lee 6002ffdc37 (gtk) #5235 'Plural wrong in torrent-cell-renderer' -- fix with patch by RamsesDeNorre 2013-01-21 00:15:21 +00:00
Jordan Lee 5093f99652 (gtk) silence a couple of potential GFileInfo console warnings 2013-01-20 04:10:47 +00:00
Jordan Lee 03ac81e7c7 (trunk) #1220 'change top folder names' -- add file-renaming to the GTK+ GUI 2013-01-19 08:44:23 +00:00
Jordan Lee bff4a98fa6 (gtk) silence a g_object_unref() warning when appending '.added' to a .torrent file fails 2013-01-17 00:45:31 +00:00
Jordan Lee c385a1559f re-sync the GTK+ and Qt clients' prefs dialogs. 2013-01-16 21:42:03 +00:00
Jordan Lee c4276d832e Tweak the text of the First Time User legal dialog. 2013-01-16 20:55:08 +00:00
Jordan Lee 63fb848f3e (gtk) in makemeta-ui.c, don't rely on g_clear_pointer()... our GLIB_MINIMUM is 2.32.0 2013-01-05 00:19:11 +00:00
Jordan Lee 5b1cd134ad (gtk) #5211 'Transmission main window does not get focus when toggling via AppIndicator applet' -- fixed. 2013-01-04 23:25:17 +00:00
Jordan Lee 10b96f0f12 (gtk) copyediting: update several files to be closer to the gtk+ indentation style. 2013-01-04 19:45:39 +00:00
Jordan Lee 2a52ebab20 (gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate 2013-01-04 16:36:52 +00:00
Jordan Lee 39dfe75cea (gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- remove unnecessary gdk_threads_enter() / gdk_threads_leave() pair in the TrCore prefs-changed callback 2013-01-04 07:08:25 +00:00
Jordan Lee 5877747ad6 (gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- on shutdown, destruct the TrCore GObject in the glib thread, and then call tr_sessionClose() from a worker thread. 2013-01-04 06:57:39 +00:00
Jordan Lee 4e0ffffbf0 (gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- when we get an RPC notification, delegate the work back to the gtk thread. 2013-01-04 06:35:08 +00:00
Jordan Lee fd61c3af0b (gtk) #5207 'Simplify GTK+ client's category filter to match Qt and Web clients' -- done. 2013-01-01 19:45:00 +00:00
Jordan Lee db721de837 (gtk) copyediting: indentation & whitespace 2013-01-01 18:43:41 +00:00
Jordan Lee 8f9e96d0ce (trunk gtk) #5205 'GTK+ client crashes in recent trunk' -- fixed. 2012-12-31 22:37:18 +00:00
Jordan Lee 3c9640bb8f make tr_info.webseedCount and tr_info.trackerCount unsigned. 2012-12-30 22:06:45 +00:00
Jordan Lee ff3a6df7a6 silence console warnings when fallback icons can't be found 2012-12-27 17:49:52 +00:00
Jordan Lee d4ab5d299f #5185 (trunk, gtk) fix sort-by-age with patch from elhana. 2012-12-26 23:36:23 +00:00
Jordan Lee c1559f3cc4 (trunk, libT) first drop of the tr_quark patch. 2012-12-22 20:35:19 +00:00
Jordan Lee e0a519fe8c (trunk, gtk) #5174 'the text field in Properties>Trackers>Edit won't resize when the dialog is resized' -- fixed. 2012-12-16 22:51:29 +00:00
Jordan Lee aea6d7cd6f (trunk, libT) #5168 'make libtransmission's public funcs nonblocking when possible' -- remove tr_torrentRef() and tr_torrentUnref() as discussed in https://trac.transmissionbt.com/ticket/5168#comment:8 2012-12-14 20:04:37 +00:00
Jordan Lee e96ed247fe refactor libtransmission's tr_benc class as tr_variant. 2012-12-14 04:34:42 +00:00
Jordan Lee 6429093cd0 copyediting: indentation 2012-12-13 03:37:55 +00:00
Jordan Lee 61bc1eabd6 fewer redundant gobject dynamic casts 2012-12-13 03:00:57 +00:00
Jordan Lee 079c78981c (trunk) #5168 'make libtransmission's public funcs nonblocking when possible' -- first attempt. 2012-12-12 20:22:57 +00:00
Jordan Lee 9ddd7e0166 preallocate a couple of dictionaries to the right size before using them. 2012-12-09 21:28:20 +00:00
Jordan Lee 317185750c copyediting: more whitespace reformatting 2012-12-05 21:26:40 +00:00
Jordan Lee 3d38723ad9 Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk). 2012-12-05 17:29:46 +00:00
Jordan Lee 6755e4e24f (trunk, gtk) #5089 'Open-by-URL doesn't automatically paste URLs/magnet links from the clipboard if they contain leading whitespace' -- fixed. 2012-10-13 16:47:26 +00:00
Jordan Lee b8ef3a9acd (trunk, gtk) #5088 'gtr_is_supported_url(), gtr_is_magnet_link() aren't NULL-safe' -- fixed. 2012-10-13 16:45:20 +00:00
Jordan Lee 7219f26dae (trunk, T) #5072 "In the torrent list, show how many web seeds we're downloading from" -- made the Qt, GTK+, and web client text consistent 2012-10-07 17:51:56 +00:00
Jordan Lee 33c4d25f19 fix a handful of console warnings that were generated by trying to trash a NULL .torrent file b/c the torrent had been added from a URL 2012-09-23 15:38:07 +00:00
Jordan Lee 7fe9042235 fix BUILT_SOURCES and CLEANFILES for the transmission-resource files 2012-09-22 22:36:05 +00:00
Jordan Lee 00b0678904 fix warnings generated by autoreconf -Wall 2012-09-22 22:23:04 +00:00
Jordan Lee 3946dd2452 minor plural fix for cell renderer downloading metadata, patch by ajf88 2012-09-20 03:39:00 +00:00
Jordan Lee 8096c12fe0 add UI_FILES to EXTRA_DIST to see if that fixes distcheck 2012-09-19 04:52:04 +00:00
Jordan Lee fadd8f704f fix the build by adding transmission.gresource.xml to EXTRA_DIST 2012-09-09 06:45:50 +00:00
Jordan Lee 1966ffe4f5 load the UI from a resource file rather than a string. Patch by fmuellner 2012-09-07 17:18:17 +00:00
Jordan Lee 357b160cde remove trailing spaces 2012-09-07 04:25:04 +00:00
Jordan Lee f4cfc0cf56 fix tab damage 2012-09-07 04:22:21 +00:00
Jordan Lee 2c15a957d8 (trunk gtk) #4997 "missing semicolon in the desktop file" -- reported & patched by kalev 2012-08-18 15:49:24 +00:00
Jordan Lee 6a3c7f34ec (trunk, gtk) use GtkApplication and GtkApplicationWindow 2012-07-14 22:44:41 +00:00
Jordan Lee dfbfdbc81b (trunk, gtk) remove the pointless TrWindow typedef 2012-07-14 22:41:33 +00:00
Jordan Lee cdd71c6427 (trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2 2012-07-14 19:26:55 +00:00
Jordan Lee b6e0e48927 (trunk gtk) #4892 "support Startup Notification in the GTK interface" -- fixed. 2012-07-13 19:53:59 +00:00
Jordan Lee 3398a48e57 (trunk libT) #4402 "Transmission Bandwidth allocation getting overflows" -- use gvdl's patch '4402-uint-bpsoverflow.patch' 2012-07-01 02:17:35 +00:00
Jordan Lee 5ad842b6a8 (trunk, gtk) fix #4871 'appindicator does not set its title' w/patch from seb128 2012-04-16 18:42:26 +00:00
Jordan Lee 53ea28bdf6 (trunk, gtk) fix #4867 'Some strings are not translated in Transmission in Ubuntu 12.04' 2012-04-13 14:49:34 +00:00
Jordan Lee cf716904f9 (trunk, gtk) #4573 'fix crash when opening a torrent file on systems that don't define G_USER_DIRECTORY_DOWNLOAD'. Thanks to Felipe Contreras for the initial patch. 2012-04-08 16:02:48 +00:00
Jordan Lee 01535743a0 (trunk) improved & translatable .desktop files patch from jbicha for ticket #4804 2012-04-07 15:45:12 +00:00
Jordan Lee fd5014aef5 (trunk gtk) fix ticket #4827 'clicking cancel in Open URL dialog does nothing' 2012-04-07 00:41:21 +00:00
Jordan Lee 32f3186f84 (trunk gtk) fix #4849 'Transmission-gtk Ignores Notification Sound Setting' with a patch from Jan Varho 2012-04-07 00:30:37 +00:00
Jordan Lee 4c8c5f578d (trunk gtk) #4764 "filenames should have a tooltip" -- fixed with patch from gulyan 2012-03-04 13:12:42 +00:00
Jordan Lee a3039d444d #4804 "Add quicklist to gnome-shell and unity" -- patch applied. 2012-03-04 12:58:46 +00:00
Jordan Lee 252560ddd9 (trunk gtk) #4791 "Should catch SIGTERM instead of SIGKILL" -- fixed with patch by Matt Krai 2012-02-24 19:52:50 +00:00
Jordan Lee e110757013 (trunk gtk) when processing log messages for the Message Log window and we encounter an error messages, pass it to g_warning() as well 2012-02-04 23:59:42 +00:00
Jordan Lee 6d4858d8dd (trunk) #4732 "allow switching between internal and system libnatpmp" -- fixed with patch scarabeus and applied by me, so any patch breakage is probably mine... ;) 2012-02-04 01:28:15 +00:00
Jordan Lee fbc7f3dc3c (trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)

Flame away.
2012-02-03 21:21:52 +00:00
Jordan Lee e599b3a738 (trunk gtk) To improve translations, help gettext to differentiate between the gerund and verb forms of some -ing words like "Seeding" and "Downloading" -- fixed.
I wasn't sure how to do this, so for the benefit of my future self or anyone else who's interested, here are some breadcrumbs I found: https://trac.transmissionbt.com/ticket/4717#comment:6
2012-02-03 17:12:17 +00:00
Jordan Lee 631a77287d (trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…). 2012-02-03 15:51:36 +00:00
Jordan Lee 7e83c406d4 (trunk gtk) fix a minor memory leak in gtr_open_file(). reported by clang static analyzer. 2012-01-24 18:09:12 +00:00
Jordan Lee 300f070104 Silence a minor compiler warning.
We used to pass no button text + response_id pairs when creating the dialog because only gtk_dialog_add_button() would return back the actual button widget s.t. we could use a grab on it. However as of GTK+ 2.20 we can use gtk_dialog_get_widget_for_response() to get the button, so we can create dialogs in the more common way (which also fixes the gcc warning)
2012-01-13 22:10:26 +00:00
Jordan Lee d524deecb0 (trunk libT) #4372 "make notification and system sounds configurable" -- instead of using notify-send, use GDBus on the org.freedesktop.Notifications API. Patch by fmuellner. 2011-12-10 19:00:50 +00:00
Jordan Lee 00757d8d33 (trunk gtk) remove dead assignment 2011-11-03 04:57:45 +00:00
Jordan Lee 8e74ccb7a1 (trunk gtk) #4605 "'--minimized' switch not working any more" -- fixed. 2011-10-30 18:27:45 +00:00
Jordan Lee 7c9fdfa8dd (trunk) run all our pngs through "pngout.exe" and "optipng -zc1-9 -zm1-9 -zs0-3 -f0-5" 2011-10-26 16:11:21 +00:00
Jordan Lee 76cf0520ba (trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fix About dialog issue when hiding and then re-showing Transmission. 2011-10-13 00:36:19 +00:00
Jordan Lee 6ec4aec13a (trunk gtk) #5204 "Transmission GTK client crashes on start" -- another possible fix ;) 2011-10-11 20:32:15 +00:00
Jordan Lee b645959eea (trunk gtk) #4554 "Transmission GTK client crashes on start" -- possible fix. 2011-10-11 15:30:33 +00:00
Jordan Lee 55c84fa9ea (trunk gtk) #4552 "mark primary toolbars" -- applied patch from fmuellner 2011-10-11 15:27:32 +00:00
Jordan Lee 72a021a9f3 (trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fixed. 2011-10-11 14:36:03 +00:00
Jordan Lee f9388714b7 (trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2 2011-10-11 04:11:08 +00:00
Jordan Lee 01f68ca846 (trunk libT) #4323 "Allow usage of system miniupnpc" -- fixed. 2011-10-09 02:05:52 +00:00
Jordan Lee cc237aa713 #4479 'magnet links are not included in filter results' -- fixed. 2011-09-14 17:22:54 +00:00
Jordan Lee 8bbc4c7b83 (trunk gtk) #4470 "Search in torrent list is broken" -- fixed. 2011-09-12 06:11:04 +00:00
Jordan Lee 84afa05662 (trunk) Roll back the right-to-left progressbar behavior added in #4281 -- it confused too many people. 2011-09-01 22:49:35 +00:00
Jordan Lee a7a9c2b12e (trunk gtk) #4399 "Add option to disable 'trash can' feature" -- done. 2011-08-13 22:58:49 +00:00
Jordan Lee 6315db10f2 (trunk libT) when building unordered lists, use g_slist_prepend() instead of g_slist_append() for efficiency's sake. 2011-08-13 22:37:25 +00:00
Jordan Lee bb41777ac7 (trunk gtk) sync the gtk+ client's watchdir behavior with the daemon's wrt r12668 2011-08-13 22:24:31 +00:00
Jordan Lee b5de483362 (trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places. 2011-08-13 21:08:53 +00:00
Jordan Lee c00b97169c use a gulong when remembering the return value of g_signal_connect(). we were using a guint in some places. 2011-08-13 21:03:38 +00:00
Jordan Lee 2487f455ef silence a warning on 64-bit machines introduced in r12669 2011-08-13 20:18:10 +00:00
Jordan Lee 38a1df9344 (trunk gtk) remove some unnecessary #includes 2011-08-13 14:19:40 +00:00
Jordan Lee b3eb4be9b3 rename 'torrent_idle_data' as 'rpc_idle_data' 2011-08-13 14:00:33 +00:00
Jordan Lee 5adcf5d32d (trunk gtk) minor tweak to signal_handler() 2011-08-13 13:59:50 +00:00
Jordan Lee 6f850a3d87 (trunk gtk) simplify the gtk+ client's watchdir code 2011-08-13 13:58:35 +00:00
Jordan Lee b795aae049 (trunk gtk) move function declarations to where they're needed 2011-08-13 05:52:36 +00:00
Jordan Lee 1564405655 (trunk gtk) simplify the details dialog manager 2011-08-13 05:47:32 +00:00
Jordan Lee 825c8bf083 (trunk gtk) remove unnecessary #includes 2011-08-13 05:04:06 +00:00
Jordan Lee 0e8b5612ed (trunk gtk) simplify the implementation of get_details_dialog_key() 2011-08-13 05:03:18 +00:00
Jordan Lee 028cfcca5a (trunk, gtk) remove the file "marshal.list"; it's unused after r12656 / r12638 2011-08-09 15:19:11 +00:00
Jordan Lee 7ab14ad4b1 (trunk gtk) in torrent-cell-renderer and tr-core, use the _parent_class field generated by G_DEFINE_TYPE. 2011-08-09 06:31:33 +00:00
Jordan Lee 6290169099 (trunk gtk) use G_DEFINE_TYPE when implementing the tr-core and torent-cell-renderer classes 2011-08-09 05:47:24 +00:00
Jordan Lee ee706baa7f (trunk gtk) fix minor memory leak introduced in r12657 2011-08-09 05:22:11 +00:00
Jordan Lee 4d4eeae682 (trunk gtk) first cut at using GApplication. This lets glib replace hundreds of lines of homegrown code. Whee! 2011-08-09 02:30:31 +00:00
Jordan Lee 8d89a16f4f remove the gtr_idle_add() portability wrapper around gdk_threads_add_idle() -- it's unnecessary now that the minimum gtk version's been bumped. 2011-08-08 17:10:55 +00:00
Jordan Lee 6d1869c33b remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped. 2011-08-08 17:06:46 +00:00
Jordan Lee b7371264fb fix r12638 regression caused by the difference in return values from gtr_mkdir_with_parents() and g_mkdir_with_parents() 2011-08-08 16:56:36 +00:00
Jordan Lee 7554955eb8 queuing: fix false "Error" message reported by rb07 2011-08-08 16:38:22 +00:00
Jordan Lee abea9d306f queuing: tweak the status messages for queued torrents 2011-08-08 16:31:52 +00:00
Jordan Lee 10aa77490a (trunk gtk) remove an unnecessary GTK_CHECK_VERSION(2,10,0) check now that the minimum gtk+ version's been bumped 2011-08-08 16:02:37 +00:00
Jordan Lee 0e48418f26 (trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010). 2011-08-07 18:41:13 +00:00
Jordan Lee 270126820a (trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency 2011-08-07 16:42:38 +00:00
Jordan Lee 79cb75e57d Tweak the phrasing of the queue preferences in the Qt and GTK+ preferences dialogs 2011-08-06 16:47:14 +00:00
Jordan Lee 307754e807 #671 "torrent queuing" -- modify the queue implementation s.t. every torrent has a queuePosition, even if it's not currently in the queue. 2011-08-02 03:59:54 +00:00
Jordan Lee 2e9d419bd4 #671 "torrent queuing" -- add a tr_stat.isStalled flag. 2011-08-01 23:27:11 +00:00
Jordan Lee 61174b007e (trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support. 2011-08-01 22:24:24 +00:00
Jordan Lee 0faddf054b (trunk gtk) when N torrents change their state at the same time, use an idle timer so that the UI refreshes once instead of N times. 2011-07-30 13:28:03 +00:00
Jordan Lee 9448bc5e88 (trunk gtk) #1477 "Launchpad translations need comment for strings with non-standard context" -- apply patch from okram. 2011-07-26 01:09:39 +00:00
Jordan Lee ee20cc2b24 (trunk gtk) #4320 "Port GTK client to GTK 3." -- transmission-gtk now compiles cleanly & runs on GTK 3. 2011-07-26 01:02:32 +00:00
Jordan Lee d6f9e85850 (trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- fix build issue in r12562 2011-07-24 16:01:14 +00:00
Jordan Lee bb57ac3c50 (trunk gtk) #4372 "make notification and system sounds configurable" -- fixed. 2011-07-23 17:23:12 +00:00
Jordan Lee 1bf6b884b5 (trunk gtk) #4366 -- wrap register_magnet_link_handler()'s body in #if HAVE_GIO ... #endif 2011-07-20 23:33:38 +00:00
Jordan Lee e495a579d3 (trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- done. 2011-07-20 23:31:39 +00:00
Jordan Lee 2863ee49c9 (trunk gtk, qt) "It is unobvious if test port feature tests UDP port status as well" -- fixed. 2011-07-17 14:12:00 +00:00
Jordan Lee d634396f98 (trunk gtk, qt) #4165 "__FD_SETSIZE impact on open-file-limit and peer-limit-global" -- cap the per-torrent and per-session peer limits at FD_SETSIZE. 2011-07-13 19:22:10 +00:00
Jordan Lee caeeb7e94c (trunk gtk) #4308 "Open with Transmission from Firefox doesn't work since Transmission 2.31" -- added support for uri-formmatted filenames being passed in via the command line 2011-06-24 18:16:12 +00:00
Jordan Lee d3e427cfd8 (trunk gtk) #4306 "Bogus <b> and </b> in popup hints" -- fixed. 2011-06-02 20:04:23 +00:00
Jordan Lee 9331a3cdac (trunk gtk) #4014 "409 error when opening .../transmission/web without trailing '/'" -- use suggestion from Mezz to have the "open web client" button in the GTK+ client follow the same URL as the Qt client 2011-05-28 01:34:07 +00:00
Jordan Lee a2432f17e4 (trunk gtk) #4254 "can't see description about Flags" -- fixed. 2011-05-28 00:12:59 +00:00
Jordan Lee c1d5b4a7e6 (trunk, GTK+/Qt) #4281 "Visualize seed progress like the web client does" -- done, with a modified patch & suggestion from mag 2011-05-28 00:09:15 +00:00
Jordan Lee 33eb6d3f9e (trunk) #3817 remove OS proxy integration from the GTK+ client 2011-05-27 13:36:53 +00:00
Jordan Lee 45bdc18210 (trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761 2011-05-02 17:58:27 +00:00
Jordan Lee 7069534abf (trunk, gtk) #4218 "open url should set focus on the open button by default" -- fix r12409 oops 2011-05-01 05:04:09 +00:00
Jordan Lee a9b379777f (trunk gtk) #4218 "open url should set focus on the open button by default" -- done. 2011-05-01 04:14:50 +00:00
Jordan Lee 0cff181c09 (trunk gtk) #4203 "gnome-network-properties doesn't exist in GNOME 3" -- fixed with patch from lesnoland 2011-04-30 16:22:03 +00:00
Jordan Lee 9753aa6183 (trunk gtk) in the details dialog, use the GQuark versions of g_object_{get,set}_data() 2011-04-29 21:36:44 +00:00
Jordan Lee c1273a03a4 (trunk gtk) tweak to r12398: because most of the strings in category_filter_model_update() will be duplicates of each other, use g_string_chunk_insert_const() instead of g_string_insert(). 2011-04-29 20:22:11 +00:00
Jordan Lee 53fede89f6 (trunk gtk) in filter.c's category_filter_model_update(), use a string chunk for all those temporary strings that are allocated in a looop 2011-04-28 23:13:14 +00:00
Jordan Lee b93bef2712 (trunk gtk) gtr_get_host_from_url(): avoid a couple of malloc() + free() calls. 2011-04-28 18:37:27 +00:00
Jordan Lee 6326003e73 (trunk gtk) very minor tweak in deciding which rows to update in the torrent model.
Since we only display speed to two decimal places, we don't need to compare previous and current torrent speed with more precision than that.
2011-04-20 01:16:16 +00:00
Jordan Lee fdbe7dc2da (trunk gtk) more heap pruning, in tr_core
Tweak how we loop through the torrents in the model, again to avoid unnecessary GtkTreePath temporaries.
2011-04-13 22:16:50 +00:00
Jordan Lee 6cd1dcb574 (trunk gtk) Avoid unnecessary GtkComboBox queries.
Instead of calling gtk_combo_box_get_active_iter() on the filterbar's two comboboxes in every periodic update, keep the state information in a local struct and update it when the selection changes. That way the filter code doesn't even need to know about the GtkComboBox or the GtkTreeModel.
2011-04-13 22:04:31 +00:00
Jordan Lee 1d7a4eb528 (trunk gtk) more heap pruning: minor GtkTreeModel changes
Use gtk_tree_model_iter_nth_child() instead of gtk_tree_model_get_iter_first() to avoid an unnecessary gtk_tree_path object being created and destroyed. This is a very minor change and I'm not sure how useful it really is, but it doesn't hurt.
2011-04-13 22:00:55 +00:00
Jordan Lee 01461d0b4a (trunk gtk) more heap pruning:
querying gconf2 each time the curl callack function is called is expensive, so query it once -- then again later, if the proxy settings change -- and remember the values in a local struct.
2011-04-13 06:18:30 +00:00
Jordan Lee 4a15899499 (trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer. 2011-04-12 11:13:41 +00:00
Jordan Lee b1459c5d3b (trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings 2011-04-12 10:51:52 +00:00
Jordan Lee b797f51144 (trunk gtk) more heap pruning: give torrent-cell-renderer an internal GString buffer so that we don't have to create & free so many short-term strings 2011-04-12 10:04:05 +00:00
Jordan Lee 4ce3555786 (trunk gtk) minor janitorial: const correctness in tr-core's compare_by_name() 2011-04-11 16:27:41 +00:00
Jordan Lee 07e60d1fc0 (trunk gtk) more heap pruning: use a GStringChunk for the collated torrent names in tr-core.c 2011-04-07 04:29:37 +00:00
Jordan Lee e02ce61d3e (trunk gtk) removed the unused MC_NAME column from the torrent GtkListStore. 2011-04-05 17:00:38 +00:00
Jordan Lee fb2ffbc542 (trunk gtk) use GQuarks instead of strings for keys in tr-icon and tr-window 2011-04-05 16:16:06 +00:00
Jordan Lee c213d91ffd (trunk gtk) use GQuarks instead of strings for keys in the filterbar's key/value pairs 2011-04-05 15:59:41 +00:00
Jordan Lee 708838b146 (trunk gtk) more heap pruning: in the main window's torrent list, only update the case-insensitive "collated name" of a torrent when the torrent's metadata changes (such as when a magnet link's metadata finishes downloading). 2011-04-05 15:41:51 +00:00
Jordan Lee afa016704f (trunk libT) more heap pruning: use a hash, rather than an allocated string in tr-core when watching for a torrent's tracker list to change 2011-04-05 01:36:37 +00:00
Jordan Lee d233ea82e7 (trunk gtk) more heap pruning: avoid unnecessary malloc() + free() calls in gtr_get_host_from_url() 2011-04-04 16:54:09 +00:00
Jordan Lee c16406bf7c (trunk gtk) remove "dead nested assignment" wart detected by clang static analyzer 2011-03-31 04:58:38 +00:00
Jordan Lee eb06d81fb9 (trunk) fix a handful of small memory leaks that valgrind found. 2011-03-25 17:42:47 +00:00
Jordan Lee bd88521332 (trunk) yet more "#include" tweaks 2011-03-25 15:03:42 +00:00
Jordan Lee b0379147d9 (trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5 2011-03-25 07:32:30 +00:00