Commit Graph

11359 Commits

Author SHA1 Message Date
Mitchell Livingston a43f649935 Fix a theoretical concurrency issue by generating an index set directly instead of enumerating objects and filling an index set. 2012-01-08 18:58:47 +00:00
Mitchell Livingston bb16b6b4e2 improve how we search the message window's message array 2012-01-08 17:05:12 +00:00
Mitchell Livingston 685d04fa56 dead code removal 2012-01-08 17:04:30 +00:00
Mitchell Livingston 7223a980f3 more array enumeration using blocks and the concurrent option 2012-01-08 05:37:18 +00:00
Mitchell Livingston bc344e6e74 update the file table node search to (possibly) use concurrent enumeration 2012-01-08 05:05:47 +00:00
Mitchell Livingston 9c75df7ddc remove the no-longer-necessary lock from the file table 2012-01-08 04:11:30 +00:00
Mitchell Livingston 3cb231283e store the list of newly-adding transfers in a set rather than an array 2012-01-08 04:11:07 +00:00
Mitchell Livingston 21ba5ced8c When adding torrents, slide them in from the left 2012-01-08 00:51:05 +00:00
Mitchell Livingston db9606d67a don't animate the main table on launch 2012-01-07 22:06:23 +00:00
Mitchell Livingston 3fd186f3f2 Animate rearranging the queue separately from the main filter animation. This allows us to ensure that the animation shows the dragged torrents being moved instead of the torrents around them. 2012-01-07 21:05:02 +00:00
Mitchell Livingston 88aa9cbe4a move tinkering with the main table's animations 2012-01-07 18:46:03 +00:00
Mitchell Livingston 568ca2eb8e more block usage when removing previous piece info 2012-01-07 17:40:18 +00:00
Mitchell Livingston 61bca9fa60 re-add code (removed in r13132) to remove previous piece information for no-longer-displayed torrents (in a fun new block way!) 2012-01-07 17:08:28 +00:00
Mitchell Livingston 351f574f08 when showing/hiding group rows, fade them in/out instead of sliding them left 2012-01-07 16:18:56 +00:00
Mitchell Livingston abc1852ff8 #4701 Table looks like it will accept drag-and-drop without a row 2012-01-07 16:01:28 +00:00
Mitchell Livingston b2f3bc7eaf #4696 Step one of getting the main table to animate for everything besides the already-added sorting. This also contains improvements to the sorting code by sorting in-place. 2012-01-07 15:46:42 +00:00
Mitchell Livingston 62cef8ea98 speed up for #4696 2012-01-04 23:40:23 +00:00
Mitchell Livingston 9eab42d613 #4696 (Lion) animate sorting the main table 2012-01-04 05:16:07 +00:00
Mitchell Livingston 9353eba3cd #4694 replace more reloadData table calls with setNeedsDisplay: 2012-01-04 00:36:21 +00:00
Mitchell Livingston 16e70167d0 update moveGroupAtRow:toRow to use NSMutableArrayAdditions's moveObjectAtIndex:toIndex: 2012-01-04 00:06:30 +00:00
Mitchell Livingston d024e6bf39 #4694 Don't call reloadData on the main table on each updateUI call (and each sort) if the order hasn't changed; instead call setNeedsDisplay:. Don't call reloadData when toggling the main window per-torrent status string 2012-01-03 01:53:53 +00:00
Mitchell Livingston 97c9f72cda revert r13121 for the time being 2012-01-02 23:55:10 +00:00
Mitchell Livingston 575a57525c don't create a NSColorPanel just to close it 2012-01-02 21:47:14 +00:00
Mitchell Livingston ff5510a3fc #4693 (Lion) animate adding/removing/dragging rows in the group pref table 2012-01-02 19:05:21 +00:00
Jordan Lee cac5c360f2 (trunk libT) #4690 "getPeerCandidates() uses more CPU than necessary" -- fixed.
Once we've scored all n candidates, we sort them by score so that we can pick out the k best candidates. If n is large, sorting them can be expensive. If we use the Selection Algorithm, we select in O(n) without having to sort.
2011-12-31 21:28:53 +00:00
Mitchell Livingston a03cad7132 remove accidental line removal in r13121 2011-12-29 18:42:45 +00:00
Mitchell Livingston 577b578f61 #4688 On Lion use new dragging functionality, allowing for the count of dragged files to appear under the mouse pointer 2011-12-29 18:40:17 +00:00
Mitchell Livingston ea33599308 display the priority images in the pulldown menus in the add windows 2011-12-28 03:25:48 +00:00
Mitchell Livingston 2a670d54a9 support pasting magnet links into the torrent table 2011-12-27 23:19:14 +00:00
Mitchell Livingston 22a5e885ba If we have a url and string in the clipboard, only use the url when trying to open as a torrent file. This way we avoid opening the same URL twice 2011-12-26 02:46:27 +00:00
Mitchell Livingston 5339d25dca run on Snow Leopard again 2011-12-26 02:39:30 +00:00
Mitchell Livingston aafb346abd #4686 Capture pasted strings that are URLs 2011-12-26 02:33:13 +00:00
Mitchell Livingston 01590dacf3 make sure there's a screen before attempting to constrain info window size 2011-12-25 22:15:13 +00:00
Mitchell Livingston 25a5834614 #4683 Info window swapped view heights not constrained to screen size 2011-12-25 22:05:18 +00:00
Jordan Lee a8468a7b09 (trunk libT) #4684 "tr_cpSizeWhenDone() is slow for huge torrents that we're only partially downloading" -- fixed.
There are actually two different implementations of the byte-counting in that function: a slower implementation was added prior to 2.40 in r12918 to double-check the standard implementation. This checking was added to help smoke out a bug that was fixed in r12920, but I forgot to remove that slower implementation.
2011-12-22 19:35:13 +00:00
Jordan Lee 9576dd16e2 (trunk libT) #4666 "webseed downloading never gets downloaded" -- fixed.
The webseed in question is downloading from an ubuntuone.com url. We ask for piece-sized ranges in a couple of different concurrent connections, and curl hints to the server that it's okay to gzip the response, or deflate it, or leave it raw. It looks like there's a bug in the server or in libcurl (or, somehow, Transmission) that's not compressing or decompressing these responses correctly -- we never get the right number of bytes in the response from libcurl. If we ask for the contents uncompressed, the download progresses towards completion.

As an aside, when testing this I noticed that deluge is a lot faster than Transmission on this torrent. In order for Transmission to reach parity here, webseed.c needs to know when it's appropriate to have more than 4 concurrent tasks and/or be able to request ranges > the torrent's piece size.
2011-12-14 05:58:23 +00:00
Jordan Lee f9cc51f0d3 (trunk libT) fix a minor memory leak in the bencode regression tests.
Found by llvm's static analyzer. This is a minor issue since the leak is in an automated test rather than in shipping code, but it's still better to fix it.
2011-12-14 05:44:15 +00:00
Jordan Lee 0d13057111 (trunk libT) fix warnings in fileset_get_empty_slot() found by llvm's static-build analyzer.
static-build found a potential NULL pointer dereference. The circumstances where this could get triggered don't seem very likely, but doesn't hurt to fix the warning.
2011-12-14 05:42:15 +00:00
Jordan Lee 206b1a9a5f (trunk web) fix warnings in tr_urlIsValidTracker() and tr_urlIsValid() found by llvm's scan-build.
scan-build found similar warnings in these two functions relating to allowing NULL pointers to be passed as arguments to functions that don't allow NULL. So now those NULL checks are made explicit before the function calls.
2011-12-14 05:40:21 +00:00
Mitchell Livingston 30f7fae5a5 eliminate all warnings by switching NSOpenPanel/NSSavePanels to use completion handler blocks 2011-12-11 22:31:01 +00:00
Jordan Lee d524deecb0 (trunk libT) #4372 "make notification and system sounds configurable" -- instead of using notify-send, use GDBus on the org.freedesktop.Notifications API. Patch by fmuellner. 2011-12-10 19:00:50 +00:00
Jordan Lee 4e2b6f6e9f #4664 "Use completeBaseName() instead of baseName() in the 'New Torrent' dialog" -- patch contributed by cantabile 2011-12-10 18:45:21 +00:00
Jordan Lee 1cfeb4debb (trunk libT) #4644 "Transmission can't download big files from webseed." -- fix overflow error with a patch based on one from and_cesbo. (Modified by Jordan to add random bugs.) 2011-12-10 18:42:52 +00:00
Jordan Lee 74b8552521 (trunk daemon) #4648 "Transmission-Remote With Full URL Specified Broken" -- fixed with patch from niol 2011-12-10 18:34:36 +00:00
Mitchell Livingston 7d14f9617b #4654 Make Mist notifications an optional setting configured through Preferences 2011-12-03 02:50:21 +00:00
Mitchell Livingston 89a35a880e alphabetize the sorting options. with "queue order" at the top 2011-11-28 12:37:14 +00:00
Jordan Lee 2d4d29793c (trunk web) #4637 "sorting by size in the web ui" -- patch added. 2011-11-28 03:35:33 +00:00
Mitchell Livingston 788b1f20a7 update Growl framework to 1.3.1 2011-11-27 14:40:00 +00:00
Mitchell Livingston 0a9b47da50 whoops typo 2011-11-22 03:30:37 +00:00
Mitchell Livingston 749c9a4c7d update jQuery to 1.7.1 2011-11-22 03:19:34 +00:00