c51132ad78
#5335 : better compression of .png files by Mangix
2013-04-10 02:27:42 +00:00
0abb762ed5
segfault when opening prefs dialog in gtk+ 3.8.0
2013-04-10 02:12:19 +00:00
d1571bda02
(gtk) use replace strcmp() with g_strcmp0() everywhere
2013-02-14 15:17:42 +00:00
76a3b116f0
use g_strcmp0() instead of strcmp() to guard against corrupt settings in the config file
2013-02-10 23:06:05 +00:00
90b95697e0
(gtk) #5284 'file tree should show the wanted size of the subtree, not the entire size': done.
2013-02-09 19:28:38 +00:00
cd09204a6e
(trunk) first draft of changing the FreeSpace API to behave as https://trac.transmissionbt.com/ticket/4076#comment:25 -- libT, rpc, qt, and gtk implementations.
2013-02-09 04:05:03 +00:00
d76d2a34d9
(gtk) match transmission-qt's way of showing up & down speeds in the statusbar
2013-02-08 01:34:59 +00:00
445609f690
(trunk) prefer tr_remove() to unlink() or rmdir()
2013-02-04 21:53:19 +00:00
1a768ab06f
(gtk) #5271 'once we start shutting down the application, stop updating the Action states': more safeguards
2013-02-04 18:34:39 +00:00
2e251f73cb
(gtk) #5246 'problems when incomplete-dir is a subdirectory of download-dir': change the file chooser API calls, based on suggestion from kraai
2013-02-04 16:51:52 +00:00
0c8c2b5bdd
(gtk) #5271 'once we start shutting down the application, stop updating the Action states': fixed
2013-02-04 16:11:08 +00:00
1c90e929d1
(gtk) #4076 'free space indicator': tweak the GTK+ client's visible count label's behavior as the previous commit did for the Qt client
2013-02-02 23:01:33 +00:00
085c37584e
#4076 'free space indicator': in the Qt and GTK+ clients, add 'Free' to the freespace labels to give more context of what the number means
2013-02-01 21:02:40 +00:00
16d46a72a1
in the Qt and GTK+ clients, move the torrent count indicator from the statusbar to the filterbar
2013-02-01 20:58:55 +00:00
69f3e31230
(libT) change the API signature for tr_torrentVerify() s.t. client code can be notified when the verify is finished
2013-01-31 21:58:25 +00:00
a4bbceb483
fix r13896 oops
2013-01-30 00:28:53 +00:00
20fe66bccf
more experimentation with the shortTransferString
2013-01-30 00:22:52 +00:00
4a059b79b8
when sorting by activity and both torrents' upload and download speed is zero, use how many peers we're ready to upload to / download from as a secondary key.
2013-01-30 00:20:51 +00:00
1d3bf93618
synchronize the Qt and GTK+ client's statusbars, including the new freespace indicator. Make the up/down speed ordering consistent between statusbar and torrent list.
2013-01-27 23:05:47 +00:00
f75027d5e9
make all the log functions/structs/enums use a single 'tr_log' namespace, such as tr_logGetQueue, tr_logAddInfo, tr_logIsLevelActive
2013-01-25 23:34:20 +00:00
29d6f5d934
(gtk) #5190 'Add borders instead of shadow on scrolled window': fixed, patch by nagisa
2013-01-21 17:05:55 +00:00
dc42791380
(gtk) remember to clear out the error pointer
2013-01-21 03:18:44 +00:00
6002ffdc37
(gtk) #5235 'Plural wrong in torrent-cell-renderer' -- fix with patch by RamsesDeNorre
2013-01-21 00:15:21 +00:00
5093f99652
(gtk) silence a couple of potential GFileInfo console warnings
2013-01-20 04:10:47 +00:00
03ac81e7c7
(trunk) #1220 'change top folder names' -- add file-renaming to the GTK+ GUI
2013-01-19 08:44:23 +00:00
bff4a98fa6
(gtk) silence a g_object_unref() warning when appending '.added' to a .torrent file fails
2013-01-17 00:45:31 +00:00
c385a1559f
re-sync the GTK+ and Qt clients' prefs dialogs.
2013-01-16 21:42:03 +00:00
c4276d832e
Tweak the text of the First Time User legal dialog.
2013-01-16 20:55:08 +00:00
63fb848f3e
(gtk) in makemeta-ui.c, don't rely on g_clear_pointer()... our GLIB_MINIMUM is 2.32.0
2013-01-05 00:19:11 +00:00
5b1cd134ad
(gtk) #5211 'Transmission main window does not get focus when toggling via AppIndicator applet' -- fixed.
2013-01-04 23:25:17 +00:00
10b96f0f12
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
2a52ebab20
(gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate
2013-01-04 16:36:52 +00:00
39dfe75cea
(gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- remove unnecessary gdk_threads_enter() / gdk_threads_leave() pair in the TrCore prefs-changed callback
2013-01-04 07:08:25 +00:00
5877747ad6
(gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- on shutdown, destruct the TrCore GObject in the glib thread, and then call tr_sessionClose() from a worker thread.
2013-01-04 06:57:39 +00:00
4e0ffffbf0
(gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- when we get an RPC notification, delegate the work back to the gtk thread.
2013-01-04 06:35:08 +00:00
fd61c3af0b
(gtk) #5207 'Simplify GTK+ client's category filter to match Qt and Web clients' -- done.
2013-01-01 19:45:00 +00:00
db721de837
(gtk) copyediting: indentation & whitespace
2013-01-01 18:43:41 +00:00
8f9e96d0ce
(trunk gtk) #5205 'GTK+ client crashes in recent trunk' -- fixed.
2012-12-31 22:37:18 +00:00
3c9640bb8f
make tr_info.webseedCount and tr_info.trackerCount unsigned.
2012-12-30 22:06:45 +00:00
ff3a6df7a6
silence console warnings when fallback icons can't be found
2012-12-27 17:49:52 +00:00
d4ab5d299f
#5185 (trunk, gtk) fix sort-by-age with patch from elhana.
2012-12-26 23:36:23 +00:00
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
e0a519fe8c
(trunk, gtk) #5174 'the text field in Properties>Trackers>Edit won't resize when the dialog is resized' -- fixed.
2012-12-16 22:51:29 +00:00
aea6d7cd6f
(trunk, libT) #5168 'make libtransmission's public funcs nonblocking when possible' -- remove tr_torrentRef() and tr_torrentUnref() as discussed in https://trac.transmissionbt.com/ticket/5168#comment:8
2012-12-14 20:04:37 +00:00
e96ed247fe
refactor libtransmission's tr_benc class as tr_variant.
2012-12-14 04:34:42 +00:00
6429093cd0
copyediting: indentation
2012-12-13 03:37:55 +00:00
61bc1eabd6
fewer redundant gobject dynamic casts
2012-12-13 03:00:57 +00:00
079c78981c
(trunk) #5168 'make libtransmission's public funcs nonblocking when possible' -- first attempt.
2012-12-12 20:22:57 +00:00
9ddd7e0166
preallocate a couple of dictionaries to the right size before using them.
2012-12-09 21:28:20 +00:00
317185750c
copyediting: more whitespace reformatting
2012-12-05 21:26:40 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
6755e4e24f
(trunk, gtk) #5089 'Open-by-URL doesn't automatically paste URLs/magnet links from the clipboard if they contain leading whitespace' -- fixed.
2012-10-13 16:47:26 +00:00
b8ef3a9acd
(trunk, gtk) #5088 'gtr_is_supported_url(), gtr_is_magnet_link() aren't NULL-safe' -- fixed.
2012-10-13 16:45:20 +00:00
7219f26dae
(trunk, T) #5072 "In the torrent list, show how many web seeds we're downloading from" -- made the Qt, GTK+, and web client text consistent
2012-10-07 17:51:56 +00:00
33c4d25f19
fix a handful of console warnings that were generated by trying to trash a NULL .torrent file b/c the torrent had been added from a URL
2012-09-23 15:38:07 +00:00
7fe9042235
fix BUILT_SOURCES and CLEANFILES for the transmission-resource files
2012-09-22 22:36:05 +00:00
00b0678904
fix warnings generated by autoreconf -Wall
2012-09-22 22:23:04 +00:00
3946dd2452
minor plural fix for cell renderer downloading metadata, patch by ajf88
2012-09-20 03:39:00 +00:00
8096c12fe0
add UI_FILES to EXTRA_DIST to see if that fixes distcheck
2012-09-19 04:52:04 +00:00
fadd8f704f
fix the build by adding transmission.gresource.xml to EXTRA_DIST
2012-09-09 06:45:50 +00:00
1966ffe4f5
load the UI from a resource file rather than a string. Patch by fmuellner
2012-09-07 17:18:17 +00:00
357b160cde
remove trailing spaces
2012-09-07 04:25:04 +00:00
f4cfc0cf56
fix tab damage
2012-09-07 04:22:21 +00:00
2c15a957d8
(trunk gtk) #4997 "missing semicolon in the desktop file" -- reported & patched by kalev
2012-08-18 15:49:24 +00:00
6a3c7f34ec
(trunk, gtk) use GtkApplication and GtkApplicationWindow
2012-07-14 22:44:41 +00:00
dfbfdbc81b
(trunk, gtk) remove the pointless TrWindow typedef
2012-07-14 22:41:33 +00:00
cdd71c6427
(trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2
2012-07-14 19:26:55 +00:00
b6e0e48927
(trunk gtk) #4892 "support Startup Notification in the GTK interface" -- fixed.
2012-07-13 19:53:59 +00:00
3398a48e57
(trunk libT) #4402 "Transmission Bandwidth allocation getting overflows" -- use gvdl's patch '4402-uint-bpsoverflow.patch'
2012-07-01 02:17:35 +00:00
5ad842b6a8
(trunk, gtk) fix #4871 'appindicator does not set its title' w/patch from seb128
2012-04-16 18:42:26 +00:00
53ea28bdf6
(trunk, gtk) fix #4867 'Some strings are not translated in Transmission in Ubuntu 12.04'
2012-04-13 14:49:34 +00:00
cf716904f9
(trunk, gtk) #4573 'fix crash when opening a torrent file on systems that don't define G_USER_DIRECTORY_DOWNLOAD'. Thanks to Felipe Contreras for the initial patch.
2012-04-08 16:02:48 +00:00
01535743a0
(trunk) improved & translatable .desktop files patch from jbicha for ticket #4804
2012-04-07 15:45:12 +00:00
fd5014aef5
(trunk gtk) fix ticket #4827 'clicking cancel in Open URL dialog does nothing'
2012-04-07 00:41:21 +00:00
32f3186f84
(trunk gtk) fix #4849 'Transmission-gtk Ignores Notification Sound Setting' with a patch from Jan Varho
2012-04-07 00:30:37 +00:00
4c8c5f578d
(trunk gtk) #4764 "filenames should have a tooltip" -- fixed with patch from gulyan
2012-03-04 13:12:42 +00:00
a3039d444d
#4804 "Add quicklist to gnome-shell and unity" -- patch applied.
2012-03-04 12:58:46 +00:00
252560ddd9
(trunk gtk) #4791 "Should catch SIGTERM instead of SIGKILL" -- fixed with patch by Matt Krai
2012-02-24 19:52:50 +00:00
e110757013
(trunk gtk) when processing log messages for the Message Log window and we encounter an error messages, pass it to g_warning() as well
2012-02-04 23:59:42 +00:00
6d4858d8dd
(trunk) #4732 "allow switching between internal and system libnatpmp" -- fixed with patch scarabeus and applied by me, so any patch breakage is probably mine... ;)
2012-02-04 01:28:15 +00:00
fbc7f3dc3c
(trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
...
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)
Flame away.
2012-02-03 21:21:52 +00:00
e599b3a738
(trunk gtk) To improve translations, help gettext to differentiate between the gerund and verb forms of some -ing words like "Seeding" and "Downloading" -- fixed.
...
I wasn't sure how to do this, so for the benefit of my future self or anyone else who's interested, here are some breadcrumbs I found: https://trac.transmissionbt.com/ticket/4717#comment:6
2012-02-03 17:12:17 +00:00
631a77287d
(trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…).
2012-02-03 15:51:36 +00:00
7e83c406d4
(trunk gtk) fix a minor memory leak in gtr_open_file(). reported by clang static analyzer.
2012-01-24 18:09:12 +00:00
300f070104
Silence a minor compiler warning.
...
We used to pass no button text + response_id pairs when creating the dialog because only gtk_dialog_add_button() would return back the actual button widget s.t. we could use a grab on it. However as of GTK+ 2.20 we can use gtk_dialog_get_widget_for_response() to get the button, so we can create dialogs in the more common way (which also fixes the gcc warning)
2012-01-13 22:10:26 +00:00
d524deecb0
(trunk libT) #4372 "make notification and system sounds configurable" -- instead of using notify-send, use GDBus on the org.freedesktop.Notifications API. Patch by fmuellner.
2011-12-10 19:00:50 +00:00
00757d8d33
(trunk gtk) remove dead assignment
2011-11-03 04:57:45 +00:00
8e74ccb7a1
(trunk gtk) #4605 "'--minimized' switch not working any more" -- fixed.
2011-10-30 18:27:45 +00:00
7c9fdfa8dd
(trunk) run all our pngs through "pngout.exe" and "optipng -zc1-9 -zm1-9 -zs0-3 -f0-5"
2011-10-26 16:11:21 +00:00
76cf0520ba
(trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fix About dialog issue when hiding and then re-showing Transmission.
2011-10-13 00:36:19 +00:00
6ec4aec13a
(trunk gtk) #5204 "Transmission GTK client crashes on start" -- another possible fix ;)
2011-10-11 20:32:15 +00:00
b645959eea
(trunk gtk) #4554 "Transmission GTK client crashes on start" -- possible fix.
2011-10-11 15:30:33 +00:00
55c84fa9ea
(trunk gtk) #4552 "mark primary toolbars" -- applied patch from fmuellner
2011-10-11 15:27:32 +00:00
72a021a9f3
(trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fixed.
2011-10-11 14:36:03 +00:00
f9388714b7
(trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2
2011-10-11 04:11:08 +00:00
01f68ca846
(trunk libT) #4323 "Allow usage of system miniupnpc" -- fixed.
2011-10-09 02:05:52 +00:00
cc237aa713
#4479 'magnet links are not included in filter results' -- fixed.
2011-09-14 17:22:54 +00:00
8bbc4c7b83
(trunk gtk) #4470 "Search in torrent list is broken" -- fixed.
2011-09-12 06:11:04 +00:00
84afa05662
(trunk) Roll back the right-to-left progressbar behavior added in #4281 -- it confused too many people.
2011-09-01 22:49:35 +00:00
a7a9c2b12e
(trunk gtk) #4399 "Add option to disable 'trash can' feature" -- done.
2011-08-13 22:58:49 +00:00
6315db10f2
(trunk libT) when building unordered lists, use g_slist_prepend() instead of g_slist_append() for efficiency's sake.
2011-08-13 22:37:25 +00:00
bb41777ac7
(trunk gtk) sync the gtk+ client's watchdir behavior with the daemon's wrt r12668
2011-08-13 22:24:31 +00:00
b5de483362
(trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places.
2011-08-13 21:08:53 +00:00
c00b97169c
use a gulong when remembering the return value of g_signal_connect(). we were using a guint in some places.
2011-08-13 21:03:38 +00:00
2487f455ef
silence a warning on 64-bit machines introduced in r12669
2011-08-13 20:18:10 +00:00
38a1df9344
(trunk gtk) remove some unnecessary #includes
2011-08-13 14:19:40 +00:00
b3eb4be9b3
rename 'torrent_idle_data' as 'rpc_idle_data'
2011-08-13 14:00:33 +00:00
5adcf5d32d
(trunk gtk) minor tweak to signal_handler()
2011-08-13 13:59:50 +00:00
6f850a3d87
(trunk gtk) simplify the gtk+ client's watchdir code
2011-08-13 13:58:35 +00:00
b795aae049
(trunk gtk) move function declarations to where they're needed
2011-08-13 05:52:36 +00:00
1564405655
(trunk gtk) simplify the details dialog manager
2011-08-13 05:47:32 +00:00
825c8bf083
(trunk gtk) remove unnecessary #includes
2011-08-13 05:04:06 +00:00
0e8b5612ed
(trunk gtk) simplify the implementation of get_details_dialog_key()
2011-08-13 05:03:18 +00:00
028cfcca5a
(trunk, gtk) remove the file "marshal.list"; it's unused after r12656 / r12638
2011-08-09 15:19:11 +00:00
7ab14ad4b1
(trunk gtk) in torrent-cell-renderer and tr-core, use the _parent_class field generated by G_DEFINE_TYPE.
2011-08-09 06:31:33 +00:00
6290169099
(trunk gtk) use G_DEFINE_TYPE when implementing the tr-core and torent-cell-renderer classes
2011-08-09 05:47:24 +00:00
ee706baa7f
(trunk gtk) fix minor memory leak introduced in r12657
2011-08-09 05:22:11 +00:00
4d4eeae682
(trunk gtk) first cut at using GApplication. This lets glib replace hundreds of lines of homegrown code. Whee!
2011-08-09 02:30:31 +00:00
8d89a16f4f
remove the gtr_idle_add() portability wrapper around gdk_threads_add_idle() -- it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:10:55 +00:00
6d1869c33b
remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:06:46 +00:00
b7371264fb
fix r12638 regression caused by the difference in return values from gtr_mkdir_with_parents() and g_mkdir_with_parents()
2011-08-08 16:56:36 +00:00
7554955eb8
queuing: fix false "Error" message reported by rb07
2011-08-08 16:38:22 +00:00
abea9d306f
queuing: tweak the status messages for queued torrents
2011-08-08 16:31:52 +00:00
10aa77490a
(trunk gtk) remove an unnecessary GTK_CHECK_VERSION(2,10,0) check now that the minimum gtk+ version's been bumped
2011-08-08 16:02:37 +00:00
0e48418f26
(trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010).
2011-08-07 18:41:13 +00:00
270126820a
(trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency
2011-08-07 16:42:38 +00:00
79cb75e57d
Tweak the phrasing of the queue preferences in the Qt and GTK+ preferences dialogs
2011-08-06 16:47:14 +00:00
307754e807
#671 "torrent queuing" -- modify the queue implementation s.t. every torrent has a queuePosition, even if it's not currently in the queue.
2011-08-02 03:59:54 +00:00
2e9d419bd4
#671 "torrent queuing" -- add a tr_stat.isStalled flag.
2011-08-01 23:27:11 +00:00
61174b007e
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
0faddf054b
(trunk gtk) when N torrents change their state at the same time, use an idle timer so that the UI refreshes once instead of N times.
2011-07-30 13:28:03 +00:00
9448bc5e88
(trunk gtk) #1477 "Launchpad translations need comment for strings with non-standard context" -- apply patch from okram.
2011-07-26 01:09:39 +00:00
ee20cc2b24
(trunk gtk) #4320 "Port GTK client to GTK 3." -- transmission-gtk now compiles cleanly & runs on GTK 3.
2011-07-26 01:02:32 +00:00
d6f9e85850
(trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- fix build issue in r12562
2011-07-24 16:01:14 +00:00
bb57ac3c50
(trunk gtk) #4372 "make notification and system sounds configurable" -- fixed.
2011-07-23 17:23:12 +00:00
1bf6b884b5
(trunk gtk) #4366 -- wrap register_magnet_link_handler()'s body in #if HAVE_GIO ... #endif
2011-07-20 23:33:38 +00:00
e495a579d3
(trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- done.
2011-07-20 23:31:39 +00:00
2863ee49c9
(trunk gtk, qt) "It is unobvious if test port feature tests UDP port status as well" -- fixed.
2011-07-17 14:12:00 +00:00
d634396f98
(trunk gtk, qt) #4165 "__FD_SETSIZE impact on open-file-limit and peer-limit-global" -- cap the per-torrent and per-session peer limits at FD_SETSIZE.
2011-07-13 19:22:10 +00:00
caeeb7e94c
(trunk gtk) #4308 "Open with Transmission from Firefox doesn't work since Transmission 2.31" -- added support for uri-formmatted filenames being passed in via the command line
2011-06-24 18:16:12 +00:00
d3e427cfd8
(trunk gtk) #4306 "Bogus <b> and </b> in popup hints" -- fixed.
2011-06-02 20:04:23 +00:00
9331a3cdac
(trunk gtk) #4014 "409 error when opening .../transmission/web without trailing '/'" -- use suggestion from Mezz to have the "open web client" button in the GTK+ client follow the same URL as the Qt client
2011-05-28 01:34:07 +00:00
a2432f17e4
(trunk gtk) #4254 "can't see description about Flags" -- fixed.
2011-05-28 00:12:59 +00:00
c1d5b4a7e6
(trunk, GTK+/Qt) #4281 "Visualize seed progress like the web client does" -- done, with a modified patch & suggestion from mag
2011-05-28 00:09:15 +00:00
33eb6d3f9e
(trunk) #3817 remove OS proxy integration from the GTK+ client
2011-05-27 13:36:53 +00:00
45bdc18210
(trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761
2011-05-02 17:58:27 +00:00
7069534abf
(trunk, gtk) #4218 "open url should set focus on the open button by default" -- fix r12409 oops
2011-05-01 05:04:09 +00:00
a9b379777f
(trunk gtk) #4218 "open url should set focus on the open button by default" -- done.
2011-05-01 04:14:50 +00:00
0cff181c09
(trunk gtk) #4203 "gnome-network-properties doesn't exist in GNOME 3" -- fixed with patch from lesnoland
2011-04-30 16:22:03 +00:00
9753aa6183
(trunk gtk) in the details dialog, use the GQuark versions of g_object_{get,set}_data()
2011-04-29 21:36:44 +00:00
c1273a03a4
(trunk gtk) tweak to r12398: because most of the strings in category_filter_model_update() will be duplicates of each other, use g_string_chunk_insert_const() instead of g_string_insert().
2011-04-29 20:22:11 +00:00
53fede89f6
(trunk gtk) in filter.c's category_filter_model_update(), use a string chunk for all those temporary strings that are allocated in a looop
2011-04-28 23:13:14 +00:00
b93bef2712
(trunk gtk) gtr_get_host_from_url(): avoid a couple of malloc() + free() calls.
2011-04-28 18:37:27 +00:00
6326003e73
(trunk gtk) very minor tweak in deciding which rows to update in the torrent model.
...
Since we only display speed to two decimal places, we don't need to compare previous and current torrent speed with more precision than that.
2011-04-20 01:16:16 +00:00
fdbe7dc2da
(trunk gtk) more heap pruning, in tr_core
...
Tweak how we loop through the torrents in the model, again to avoid unnecessary GtkTreePath temporaries.
2011-04-13 22:16:50 +00:00
6cd1dcb574
(trunk gtk) Avoid unnecessary GtkComboBox queries.
...
Instead of calling gtk_combo_box_get_active_iter() on the filterbar's two comboboxes in every periodic update, keep the state information in a local struct and update it when the selection changes. That way the filter code doesn't even need to know about the GtkComboBox or the GtkTreeModel.
2011-04-13 22:04:31 +00:00
1d7a4eb528
(trunk gtk) more heap pruning: minor GtkTreeModel changes
...
Use gtk_tree_model_iter_nth_child() instead of gtk_tree_model_get_iter_first() to avoid an unnecessary gtk_tree_path object being created and destroyed. This is a very minor change and I'm not sure how useful it really is, but it doesn't hurt.
2011-04-13 22:00:55 +00:00
01461d0b4a
(trunk gtk) more heap pruning:
...
querying gconf2 each time the curl callack function is called is expensive, so query it once -- then again later, if the proxy settings change -- and remember the values in a local struct.
2011-04-13 06:18:30 +00:00
4a15899499
(trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer.
2011-04-12 11:13:41 +00:00
b1459c5d3b
(trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings
2011-04-12 10:51:52 +00:00
b797f51144
(trunk gtk) more heap pruning: give torrent-cell-renderer an internal GString buffer so that we don't have to create & free so many short-term strings
2011-04-12 10:04:05 +00:00
4ce3555786
(trunk gtk) minor janitorial: const correctness in tr-core's compare_by_name()
2011-04-11 16:27:41 +00:00
07e60d1fc0
(trunk gtk) more heap pruning: use a GStringChunk for the collated torrent names in tr-core.c
2011-04-07 04:29:37 +00:00
e02ce61d3e
(trunk gtk) removed the unused MC_NAME column from the torrent GtkListStore.
2011-04-05 17:00:38 +00:00
fb2ffbc542
(trunk gtk) use GQuarks instead of strings for keys in tr-icon and tr-window
2011-04-05 16:16:06 +00:00
c213d91ffd
(trunk gtk) use GQuarks instead of strings for keys in the filterbar's key/value pairs
2011-04-05 15:59:41 +00:00
708838b146
(trunk gtk) more heap pruning: in the main window's torrent list, only update the case-insensitive "collated name" of a torrent when the torrent's metadata changes (such as when a magnet link's metadata finishes downloading).
2011-04-05 15:41:51 +00:00
afa016704f
(trunk libT) more heap pruning: use a hash, rather than an allocated string in tr-core when watching for a torrent's tracker list to change
2011-04-05 01:36:37 +00:00
d233ea82e7
(trunk gtk) more heap pruning: avoid unnecessary malloc() + free() calls in gtr_get_host_from_url()
2011-04-04 16:54:09 +00:00
c16406bf7c
(trunk gtk) remove "dead nested assignment" wart detected by clang static analyzer
2011-03-31 04:58:38 +00:00
eb06d81fb9
(trunk) fix a handful of small memory leaks that valgrind found.
2011-03-25 17:42:47 +00:00
bd88521332
(trunk) yet more "#include" tweaks
2011-03-25 15:03:42 +00:00
b0379147d9
(trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5
2011-03-25 07:32:30 +00:00
4a1a4ebcc0
(trunk gtk) gtk_open_uri(): use gtk_show_uri() as the default implementation for GTK+ > 2.14.0.
...
gtk_show_uri() was added in 2.14.0
2011-03-25 06:40:46 +00:00
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
433da8df9a
(trunk gtk) gtr_compare_double() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-24 18:32:05 +00:00
a891136602
(trunk gtk) gtr_localtime() is only used in one place, so make it a private function there instead of leaving it public in util.h
2011-03-24 18:29:07 +00:00
e46d0a72ba
(trunk gtk) gtr_cell_renderer_get_padding() is only used in one place, so make it a private function there instead of leaving it public in util.h
2011-03-24 18:24:21 +00:00
5417711cd4
(trunk gtk) remove function gtr_strcmp0, which is redundant due to tr_strcmp0
2011-03-24 18:20:47 +00:00
0a1df687bb
still trying to make hudson happy
2011-03-22 16:07:49 +00:00
034a65aaf1
(trunk gtk) revert r12201 to try & make hudson happy
2011-03-22 16:03:10 +00:00
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
e259d0abbe
(trunk gtk) tweak Makefile.am
2011-03-21 20:45:50 +00:00
2544b4b228
(trunk gtk) dbus tweaks in Makefile.am based on examples from http://live.gnome.org/DBusGlibBindings .
...
1. tweak the way dbus-binding-tool is invoked... use --output=$@ $^
2. add the file generated by dbus-binding-tool to BUILT_SOURCES
2011-03-21 20:26:15 +00:00
374ed10f3b
(trunk) it's bad form to #include so many system headers in libtransmission/utils.h...
2011-03-16 18:04:23 +00:00
591b95286f
Show whether a tracker is http or udp. Without that context, it could be confusing to see the same tracker twice in a tier
2011-03-15 17:03:09 +00:00
fee784f1d8
(trunk) #4081 "Add 'cookieString' argument 'torrent-add' method in RPC" -- done.
2011-03-15 04:22:47 +00:00
018585d3b0
(trunk gtk) fix condition that could crash in some cases when right-clicking in the file list menu.
2011-03-13 16:45:32 +00:00
55381159f6
(trunk gtk) #4075 "add x-scheme-handler/magnet to desktop file" -- fixed.
...
Thanks to ampelbein for the patch :)
2011-03-13 15:56:12 +00:00
afe6d42ac1
(trunk gtk) when a tracker is manually added to a torrent, check the tracker's validity with tr_urlIsValidTracker()
2011-03-13 07:49:32 +00:00
e45a6dabc9
(trunk gtk) fix 2.22+ time display regression in the GTK+ client.
2011-03-11 04:10:28 +00:00
9145bce9cd
(trunk gtk) fix time display oops
2011-03-06 15:06:38 +00:00
05c39eaa3e
add a missing icon
2011-03-06 05:41:41 +00:00
411b0bbd1a
(trunk gtk) #4088 "Transmission needs 256x256 icon too" -- added large Tango icon by Andreas Nilsson. Thanks Andreas!
...
This larger icon is apparently needed for GNOME 3.
2011-03-05 19:15:37 +00:00
0a62f69f1c
(trunk gtk) copyediting.
2011-03-04 15:49:51 +00:00
ae20b67f16
(trunk gtk) remove unused code: gtr_warn_if_fail()
2011-03-04 15:21:00 +00:00
9c7caec13f
(trunk gtk) minor copyediting for clarity/readability
2011-03-04 14:31:23 +00:00
9283ef2ebb
(trunk gtk) #4080 "Toggling speed limit mode from the web interface doesn't affect GUI" -- fixed.
2011-03-04 05:58:32 +00:00
c6dd0b0ed4
(trunk libT) fix tr_ctorFree() crash reported by Rolcol
2011-03-04 04:45:34 +00:00
dcc070c86c
(trunk gtk) some tr-core cleanup
...
Variable and function name cleanup; regrouping related functions together, etc.
2011-03-03 07:17:57 +00:00
c7006ed8b3
(trunk gtk) remove the TrTorrent GObject subclass.
2011-03-03 01:59:25 +00:00
0a8535d9a5
(trunk gtk) #4040 "Show the torrent name in the Peers Tab's tooltips" -- done.
2011-02-19 13:04:09 +00:00
db8b83854e
(trunk gtk) Don't display uTP checkbox in non-uTP builds.
...
Tweak to r11976 s.t. the "Edit GNOME Proxy Settings" button doesn't get grouped in the "Peer Limits" section when uTP is disabled. :)
2011-02-19 09:30:06 +00:00
88a61d3b62
(trunk gtk) #4038 "Prefs dialog's blocklist section allows the 'update' button to be clicked when no blocklist is specified" -- fixed.
2011-02-19 09:02:39 +00:00
ee86584263
Don't display uTP checkbox in non-uTP builds (gtk).
...
Reported by Rolcol.
2011-02-18 22:22:02 +00:00
3f1b060241
(trunk T) add preliminary enable/disable toggles in daemon, gtk, and qt clients. 'preliminary' because this may be widened to a tri-state of inabled, disabled, and incoming only
2011-02-18 00:33:29 +00:00
7df7d34f6d
automake/autoconf; #includes in libtransmission
2011-02-18 00:32:19 +00:00
bd0ea13701
(gtk) Add tooltip for uTP peers.
2011-02-18 00:24:33 +00:00
716a3c90c2
(trunk) #4032 "Better error detection / reporting in http announces" -- added to trunk.
...
This patch adds two new flags to the callback function -- did_connect and did_timeout -- that are calculated inside of web.c using information from libcurl. This allows the announcer to detect timeouts more accurately and also to distinguish between unresponsive peers (which get the preexisting "Tracker did not respond" error message) and unconnectable peers (which get a new error message, "Could not connect to tracker").
2011-02-17 02:26:24 +00:00
dede299e04
(trunk gtk) #3866 "popup menu for file list manipulation" -- remove unused code in file-list.c
...
This code can be pulled back out of svn and readded if it's needed in the future.
2011-02-15 15:21:22 +00:00
72f9ab91fa
(trunk) make tr_torrentName() a public function.
...
This has been a private function in libtransmission for awhile now but it makes more sense as a public function.
2011-02-15 15:18:51 +00:00
59e8348b15
(trunk gtk) #4012 "Cannot set individual seeding time in GTK+ client" -- fixed.
...
The code in gtk/details.c was still using the pre-release RPC key "seedInactiveLimit" when it should have been using "seedIdleLimit" instead.
2011-02-12 23:54:33 +00:00
62b732708a
(trunk gtk) msgwin.c: silence compiler warning "warning: ‘pinned_to_new’ may be used uninitialized in this function"
2011-02-09 05:10:29 +00:00
24b9dc7dc2
(trunk gtk) #3866 "Popup menu for file list manipulation" -- removing from the 2.20 milestone
...
Looking over the 2.20 tickets, this one keeps sticking out. A popup menu may be useful if the "delete files" ticket is accepted in 2.30, but for this release (2.20) it doesn't really add anything new. One lesson from the 2.1x cycle was that features are a harder to remove than to add. So I'm going to hold off on adding this feature until it has a clear raison d'être.
2011-02-06 18:50:35 +00:00
1fabb9b9ea
(trunk) #3675 "Not all .part files are removed" -- handle trashing files via RPC.
...
When libtransmission gets a "remove torrent" request from RPC, it tries to delegate the work. This is because the GTK+ and Mac clients don't want torrents disappearing in a different thread and causing possible thread issues. So the GTK+ and Mac clients get notification about this via libtransmission's RPC callback and remove the torrents themselves. Unfortunately, that notification doesn't include information about whether or not to delete local data.
This commit adds that information to the RPC callback so that the Mac and GTK+ clients will know whether or not to trash the local files when a third-party RPC client requests that at torrent and its files be deleted.
2011-02-06 17:30:46 +00:00
c90ddfa1c3
(trunk libT) #3980 "segfault when adding many torrents remotely" -- possible fix.
...
gtk/main.c's onRPCChanged() is called from inside the libtransmission thread, yet it still made GTK+ calls to modify the GTK+ client's tr-core object when a torrent was added. This caused a race condition inside of the GTK+ internals. onRPCChanged() already knows to delegate work back to the GTK+ thread when a torrent is removed via RPC. This commit uses the same kind of mechanism to delegate work back to the GTK+ thread when a torrent is added via RPC.
2011-02-05 05:03:00 +00:00
a358858a99
(trunk libT) #3978 "Message window column sorting fails and triggers gtk warnings" -- fixed.
...
I'm not sure why sorting was in there in the first place; it doesn't make sense in a message log.. Disabling sorting fixes this bug.
2011-02-04 06:12:55 +00:00
7a5f87a207
(trunk gtk) #3972 "Verify progress changes not displaying" -- fixed.
...
make sure to call gtk_list_store_set() on rows matching torrents whose tr_stat.recheckProgress value has changed, triggering a row change event that causes the verify progress change to be displayed.
2011-02-02 02:45:20 +00:00
3f2e8b7b02
(trunk gtk) #3817 "use the OS' proxy support" -- fix memory leaks in the GTK+ implementation.
...
r11512 introduced a handful of memory leaks by not freeing the GConfValue objects after use.
2011-02-01 17:46:42 +00:00
705b27d128
(trunk gtk) #3876 "Give filesize its own column in the Files tree" -- fix minor memory leak introduced by r11642
...
r11642 allocated a pango font description with pango_font_description_copy() but never freed it.
2011-02-01 17:42:50 +00:00
88df1b15ee
(trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fix minor r11799 regression.
...
Clearing the model on shutdown generated a warning because it used the wrong cast. Rather than fixing the cast, add tr_core_clear() for symmetry with tr_core_load().
2011-02-01 01:45:41 +00:00
be99878e98
(trunk gtk) #3971 "favicons do not work for IP addresses" -- fixed.
...
gtr_get_host_from_url() wasn't written to handle dotted-quad or IPv6 address strings, but can handle them now.
2011-02-01 01:38:58 +00:00
b084493bfe
(trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fixed.
...
Long description in #3970 . Split tr_core's torrent GtkTreeModel into two models: one low-level unsorted one, and one proxy sorted one. That way we don't have to disable sorting before walking through the low-level one to sync the table's attributes with the tr_torrent and tr_stat.
2011-01-31 23:01:46 +00:00
1127463a1c
#3042 "Open torrent dialog focus not restored" -- fixed. patch by ijuxda.
...
the callback function for GtkWidget's focus-in-event should return TRUE to stop other handlers from being invoked for the event or FALSE to propagate the event further.
2011-01-25 04:26:10 +00:00
92def6b960
(trunk gtk) #3887 : "CPU spikes to 100% on scrolling" -- workaround committed.
...
The patch avoids use of GtkCellRendererText's "sensitive" property, and instead renders paused torrents' text using the widget's style's color for insensitive text. This approach honors the theme's "insensitive" color setting and uses it to draw insensitive text with no etching or shadowing.
The better option is still for Murrine to fix its text shadow issue... but until then, here is a workaround.
2011-01-22 13:26:44 +00:00
d6518b93b8
(trunk gtk) #3930 : Add drag-and-drop support for info hashes.
...
The "Add URL" dialog accepts URLs, magnet links, and infohashes, but only copyies urls and magnet links from the clipboard. Patch by cantabile.
2011-01-21 21:35:11 +00:00
4d529db419
(trunk gtk) include the torrent hashcode in the model's collated name.
...
This simplifies sorting by name by merging the primary and secondary keys (case-insensitive name, and hash string) into a single key.
2011-01-21 18:30:08 +00:00
287d61197a
(trunk gtk) set GtkLabel's "single-line-mode" flag to TRUE in the toolbar, in the stats dialog, and in the details dialog's info tab.
...
According to the GTK+ documentation, this "can be an advantage in situations where resizing the label because of text changes would be distracting, e.g. in a statusbar." It doesn't seem to prevent relayout in GTK+ 2.20.1, but maybe other versions of GTK+ will make better use of the flag.
2011-01-21 17:31:35 +00:00
acd941f17a
(trunk gtk) companion commit to r11738 to reduce unnecessary re-rendering in the main window
...
The main window called gtk_tree_model_filter_refilter() once per second to refresh the torrent list's filtering. This is not an efficient approach: gtk_tree_model_filter_refilter() emits a "row changed" event for every row, causing unnecessary re-rendering.
I've removed the call to gtk_tree_model_filter_refilter() and expanded the model to includes all the fields necessary for filtering. That way we only fire "row changed" events for rows that actually change.
By reducing the number of renders in steady state, this might ameliorate https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/655024
However it will *not* help the related "CPU spikes to 100% on scrolling" ticket at https://trac.transmissionbt.com/ticket/3887 because rendering paused torrents is still exceptionally expensive in the murrine theme.
2011-01-21 17:07:23 +00:00
58c7556534
(trunk gtk) #3916 "Reorder the list when metadata is downloaded" -- fix r11737 typo.
2011-01-21 16:36:57 +00:00
aea77bc9f6
(trunk gtk) make "gtr_label_set_text" public and use it everywhere instead of gtk_label_set_text()
...
Some of the refresh events to the main window's torrent list are caused by main window relayout caused by the toolbar's GtkLabels recalculating their size after being updated once per second. To prevent relayout in some trivial cases, I'm replacing the gtk_label_set_text() calls with gtr_label_set_text() because the latter doesn't update the label widget if the old and new text strings are the same.
There are other changes that can handle more important cases -- I'll test those out next.
2011-01-21 16:32:27 +00:00
9ce58e33ac
(trunk gtk) #3916 "Reorder the list when metadata is downloaded" -- fixed.
...
When tr_info.name changes, update the collated name in the main window's TreeStore.
2011-01-21 02:58:58 +00:00
a63fdd15b4
(trunk) #3926 "use 'Open Torrent' instead of 'Add Torrent' in GTK+ and Qt clients" -- fix accelerator ambiguity.
...
Using Ctrl-O for "Open File" causes a conflict with the existing Ctrl-O for "Open Folder." The HIG-compliant shortcut wins the conflict, so "Open Folder" gets a new accelerator.
2011-01-20 20:32:28 +00:00
7dd9427a1f
(trunk gtk) #3909 -- don't use Ctrl-M as the shortcut for "Copy Magnet Link to Clipboard."
2011-01-20 20:07:09 +00:00
3b28138c71
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- change the filename from add-dialog.[ch] to open-dialog.[ch]. whoooo
2011-01-20 19:57:42 +00:00
131afcc3a4
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- text changed.
2011-01-20 19:48:13 +00:00
ddba265755
(trunk gtk) source code formatting tweak
2011-01-19 14:25:22 +00:00
9d038a8539
(trunk gtk) #3913 "Area to display a torrent's comment is small" -- fixed.
2011-01-19 14:22:29 +00:00
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
87e78816ad
(trunk gtk) #3519 "webseeds don't work" -- the `active' filter in the GTK+ client didn't test for webseed activity.
2011-01-18 23:26:41 +00:00
d3eb8c6ea4
trivial minor changes to indentation, text strings, etc.
2011-01-18 00:31:05 +00:00
d1a7f70313
(trunk gtk) #3907 "in the details dialog's peers tab, 'status' is a misnomer" -- changed to 'flags'.
2011-01-17 16:13:45 +00:00
6d1ad8e0cb
(trunk gtk) #3908 "details dialog's information tab shows (verified + unverified) + unverified" -- fixed.
2011-01-17 16:10:17 +00:00
a433b0c4cc
#3686 "add rpc command to cleanly shutdown daemon" -- added for libT, tr-daemon, tr-gtk, tr-remote, and the rpc spec
2011-01-15 18:12:45 +00:00
1a862315de
(trunk gtk) #3903 "Scroll to new messages when viewing new messages in the message window" -- added.
2011-01-15 07:57:01 +00:00
e4bd783ec2
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
36e54b59e9
(trunk gtk) #3897 "filterbar should use tr_torrentStatCached() instead of tr_torrentStat()" -- fixed.
2011-01-13 11:57:06 +00:00
88d58502aa
(trunk gtk) #3896 "Redundant call to tr_torrentStat() in tr_core_update()" -- fixed.
2011-01-13 11:50:58 +00:00
721cd1c3c3
(trunk gtk) #3876 "Give filesize its own column in the Files tree" -- added.
2011-01-06 17:21:55 +00:00
aea8d8d0b5
(trunk gtk) #3519 "webseeds don't work" -- fix webseed peer counts and download speeds in the GTK+ client's main window
2011-01-06 02:40:10 +00:00
Jordan Lee