vorta/src/vorta/views/archive_tab.py

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

957 lines
36 KiB
Python
Raw Normal View History

Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
import logging
import sys
from datetime import timedelta
from typing import Dict, Optional
from PyQt6 import QtCore, uic
from PyQt6.QtCore import QItemSelectionModel, QMimeData, QPoint, Qt, pyqtSlot
from PyQt6.QtGui import QAction, QDesktopServices, QKeySequence, QShortcut
from PyQt6.QtWidgets import (
QAbstractItemView,
QApplication,
QHeaderView,
QInputDialog,
QLayout,
QMenu,
QMessageBox,
QTableView,
QTableWidgetItem,
QWidget,
)
from vorta.borg.check import BorgCheckJob
from vorta.borg.compact import BorgCompactJob
from vorta.borg.delete import BorgDeleteJob
from vorta.borg.diff import BorgDiffJob
from vorta.borg.extract import BorgExtractJob
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
from vorta.borg.info_archive import BorgInfoArchiveJob
from vorta.borg.list_archive import BorgListArchiveJob
from vorta.borg.list_repo import BorgListRepoJob
from vorta.borg.mount import BorgMountJob
from vorta.borg.prune import BorgPruneJob
from vorta.borg.rename import BorgRenameJob
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
from vorta.borg.umount import BorgUmountJob
from vorta.i18n import translate
from vorta.store.models import ArchiveModel, BackupProfileMixin
from vorta.utils import (
choose_file_dialog,
find_best_unit_for_sizes,
format_archive_name,
get_asset,
get_mount_points,
pretty_bytes,
)
from vorta.views import diff_result, extract_dialog
from vorta.views.diff_result import DiffResultDialog, DiffTree
from vorta.views.extract_dialog import ExtractDialog, ExtractTree
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
from vorta.views.source_tab import SizeItem
from vorta.views.utils import get_colored_icon
2018-10-27 17:24:34 +00:00
uifile = get_asset('UI/archivetab.ui')
ArchiveTabUI, ArchiveTabBase = uic.loadUiType(uifile)
2018-10-27 17:24:34 +00:00
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
logger = logging.getLogger(__name__)
2018-10-27 17:24:34 +00:00
#: The number of decimal digits to show in the size column
SIZE_DECIMAL_DIGITS = 1
class ArchiveTab(ArchiveTabBase, ArchiveTabUI, BackupProfileMixin):
prune_intervals = ['hour', 'day', 'week', 'month', 'year']
def __init__(self, parent=None, app=None):
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
"""Init."""
2018-10-27 17:24:34 +00:00
super().__init__(parent)
self.setupUi(parent)
self.mount_points = {} # mapping of archive name to mount point
self.repo_mount_point: Optional[str] = None # mount point of whole repo
self.menu = None
self.app = app
self.toolBox.setCurrentIndex(0)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.repoactions_enabled = True
#: Tooltip dict to save the tooltips set in the designer
self.tooltip_dict: Dict[QWidget, str] = {}
self.tooltip_dict[self.bDiff] = self.bDiff.toolTip()
self.tooltip_dict[self.bDelete] = self.bDelete.toolTip()
2018-10-27 17:24:34 +00:00
header = self.archiveTable.horizontalHeader()
2018-10-27 17:24:34 +00:00
header.setVisible(True)
header.setSectionResizeMode(0, QHeaderView.ResizeMode.ResizeToContents)
header.setSectionResizeMode(1, QHeaderView.ResizeMode.ResizeToContents)
header.setSectionResizeMode(2, QHeaderView.ResizeMode.ResizeToContents)
header.setSectionResizeMode(3, QHeaderView.ResizeMode.Interactive)
header.setSectionResizeMode(4, QHeaderView.ResizeMode.Stretch)
header.setStretchLastSection(True)
2018-10-27 17:24:34 +00:00
if sys.platform != 'darwin':
self._set_status('') # Set platform-specific hints.
self.archiveTable.setSelectionBehavior(QAbstractItemView.SelectionBehavior.SelectRows)
self.archiveTable.setEditTriggers(QAbstractItemView.EditTrigger.NoEditTriggers)
self.archiveTable.setWordWrap(False)
self.archiveTable.setTextElideMode(QtCore.Qt.TextElideMode.ElideLeft)
self.archiveTable.setAlternatingRowColors(True)
self.archiveTable.cellDoubleClicked.connect(self.cell_double_clicked)
self.archiveTable.setSortingEnabled(True)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.archiveTable.setContextMenuPolicy(Qt.ContextMenuPolicy.CustomContextMenu)
self.archiveTable.customContextMenuRequested.connect(self.archiveitem_contextmenu)
# shortcuts
shortcut_copy = QShortcut(QKeySequence.StandardKey.Copy, self.archiveTable)
shortcut_copy.activated.connect(self.archive_copy)
# single and double selection feature
self.archiveTable.setSelectionMode(QTableView.SelectionMode.ExtendedSelection)
self.archiveTable.selectionModel().selectionChanged.connect(self.on_selection_change)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
# connect archive actions
self.bMountArchive.clicked.connect(self.bmountarchive_clicked)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.bRefreshArchive.clicked.connect(self.refresh_archive_info)
self.bRename.clicked.connect(self.rename_action)
self.bDelete.clicked.connect(self.delete_action)
self.bExtract.clicked.connect(self.extract_action)
self.compactButton.clicked.connect(self.compact_action)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
# other signals
self.bList.clicked.connect(self.refresh_archive_list)
self.bPrune.clicked.connect(self.prune_action)
self.bCheck.clicked.connect(self.check_action)
self.bDiff.clicked.connect(self.diff_action)
self.bMountRepo.clicked.connect(self.bmountrepo_clicked)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.archiveNameTemplate.textChanged.connect(
lambda tpl, key='new_archive_name': self.save_archive_template(tpl, key)
)
self.prunePrefixTemplate.textChanged.connect(
lambda tpl, key='prune_prefix': self.save_archive_template(tpl, key)
)
self.populate_from_profile()
self.selected_archives = None # TODO: remove unused variable
self.set_icons()
# Connect to palette change
self.app.paletteChanged.connect(lambda p: self.set_icons())
def set_icons(self):
"Used when changing between light- and dark mode"
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.bCheck.setIcon(get_colored_icon('check-circle'))
self.bDiff.setIcon(get_colored_icon('stream-solid'))
self.bPrune.setIcon(get_colored_icon('cut'))
self.bList.setIcon(get_colored_icon('refresh'))
self.compactButton.setIcon(get_colored_icon('broom-solid'))
self.toolBox.setItemIcon(0, get_colored_icon('tasks'))
self.toolBox.setItemIcon(1, get_colored_icon('cut'))
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.bRefreshArchive.setIcon(get_colored_icon('refresh'))
self.bRename.setIcon(get_colored_icon('edit'))
self.bDelete.setIcon(get_colored_icon('trash'))
self.bExtract.setIcon(get_colored_icon('cloud-download'))
self.bmountarchive_refresh(icon_only=True)
self.bmountrepo_refresh()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
@pyqtSlot(QPoint)
def archiveitem_contextmenu(self, pos: QPoint):
# index under cursor
index = self.archiveTable.indexAt(pos)
if not index.isValid():
return # popup only for items
selected_rows = self.archiveTable.selectionModel().selectedRows(index.column())
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
if selected_rows and index not in selected_rows:
return # popup only for selected items
menu = QMenu(self.archiveTable)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
menu.addAction(
get_colored_icon('copy'),
self.tr("Copy"),
lambda: self.archive_copy(index=index),
)
menu.addSeparator()
# archive actions
archive_actions = []
archive_actions.append(
menu.addAction(
self.bRefreshArchive.icon(),
self.bRefreshArchive.text(),
self.refresh_archive_info,
)
)
archive_actions.append(
menu.addAction(
self.bMountArchive.icon(),
self.bMountArchive.text(),
self.bmountarchive_clicked,
2022-08-15 05:21:14 +00:00
)
)
archive_actions.append(menu.addAction(self.bExtract.icon(), self.bExtract.text(), self.extract_action))
archive_actions.append(menu.addAction(self.bRename.icon(), self.bRename.text(), self.rename_action))
# deletion possible with one but also multiple archives
menu.addAction(self.bDelete.icon(), self.bDelete.text(), self.delete_action)
if not (self.repoactions_enabled and len(selected_rows) <= 1):
for action in archive_actions:
action.setEnabled(False)
# diff action
menu.addSeparator()
diff_action = QAction(self.bDiff.icon(), self.bDiff.text(), menu)
diff_action.triggered.connect(self.diff_action)
menu.addAction(diff_action)
selected_rows = self.archiveTable.selectionModel().selectedRows(index.column())
diff_action.setEnabled(self.repoactions_enabled and len(selected_rows) == 2)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
menu.popup(self.archiveTable.viewport().mapToGlobal(pos))
def cancel_action(self):
self._set_status(self.tr("Action cancelled."))
self._toggle_all_buttons(True)
def _set_status(self, text):
self.mountErrors.setText(text)
self.mountErrors.repaint()
def _toggle_all_buttons(self, enabled=True):
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
"""
Set all the buttons in the archive panel to the given state.
Parameters
----------
enabled : bool, optional
The enabled state, by default True
"""
self.repoactions_enabled = enabled
for button in [
self.bCheck,
self.bList,
self.bPrune,
self.bDiff,
self.bMountRepo,
self.bDelete,
self.compactButton,
self.fArchiveActions,
]:
button.setEnabled(enabled)
button.repaint()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
# Restore states
self.on_selection_change()
def populate_from_profile(self):
"""Populate archive list and prune settings from profile."""
profile = self.profile()
if profile.repo is not None:
# get mount points
self.mount_points, repo_mount_points = get_mount_points(profile.repo.url)
if repo_mount_points:
self.repo_mount_point = repo_mount_points[0]
self.toolBox.setItemText(0, self.tr('Archives for %s') % profile.repo.url)
archives = [s for s in profile.repo.archives.select().order_by(ArchiveModel.time.desc())]
2018-10-27 17:24:34 +00:00
sorting = self.archiveTable.isSortingEnabled()
self.archiveTable.setSortingEnabled(False)
best_unit = find_best_unit_for_sizes((a.size for a in archives), precision=SIZE_DECIMAL_DIGITS)
for row, archive in enumerate(archives):
self.archiveTable.insertRow(row)
formatted_time = archive.time.strftime('%Y-%m-%d %H:%M')
self.archiveTable.setItem(row, 0, QTableWidgetItem(formatted_time))
self.archiveTable.setItem(
row, 1, SizeItem(pretty_bytes(archive.size, fixed_unit=best_unit, precision=SIZE_DECIMAL_DIGITS))
)
if archive.duration is not None:
formatted_duration = str(timedelta(seconds=round(archive.duration)))
else:
formatted_duration = ''
self.archiveTable.setItem(row, 2, QTableWidgetItem(formatted_duration))
mount_point = self.mount_points.get(archive.name)
if mount_point is not None:
item = QTableWidgetItem(mount_point)
self.archiveTable.setItem(row, 3, item)
self.archiveTable.setItem(row, 4, QTableWidgetItem(archive.name))
self.archiveTable.setRowCount(len(archives))
self.archiveTable.setSortingEnabled(sorting)
item = self.archiveTable.item(0, 0)
self.archiveTable.scrollToItem(item)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.archiveTable.selectionModel().clearSelection()
self._toggle_all_buttons(enabled=True)
2018-11-02 11:14:54 +00:00
else:
self.mount_points = {}
self.archiveTable.setRowCount(0)
self.toolBox.setItemText(0, self.tr('Archives'))
self._toggle_all_buttons(enabled=False)
self.archiveNameTemplate.setText(profile.new_archive_name)
self.prunePrefixTemplate.setText(profile.prune_prefix)
# Populate pruning options from database
profile = self.profile()
for i in self.prune_intervals:
getattr(self, f'prune_{i}').setValue(getattr(profile, f'prune_{i}'))
getattr(self, f'prune_{i}').valueChanged.connect(self.save_prune_setting)
self.prune_keep_within.setText(profile.prune_keep_within)
self.prune_keep_within.editingFinished.connect(self.save_prune_setting)
def on_selection_change(self, selected=None, deselected=None):
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
"""
React to a change of the selection of the archiveTableView.
Enables or disables archive actions and the diff button.
Makes sure at maximum 2 rows are selected.
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
Parameters
----------
selected : QItemSelection, optional
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
The new selection.
deselected : QItemSelection, optional
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
The previous selection.
"""
# handle selection of more than 2 rows
selectionModel: QItemSelectionModel = self.archiveTable.selectionModel()
indexes = selectionModel.selectedRows()
# Toggle archive actions frame
layout: QLayout = self.fArchiveActions.layout()
# task in progress -> disable all
reason = ""
if not self.repoactions_enabled:
reason = self.tr("(borg already running)")
# toggle delete button
if self.repoactions_enabled and len(indexes) > 0:
self.bDelete.setEnabled(True)
self.bDelete.setToolTip(self.tooltip_dict.get(self.bDelete, ""))
else:
self.bDelete.setEnabled(False)
tooltip = self.tooltip_dict[self.bDelete]
self.bDelete.setToolTip(tooltip + " " + reason or self.tr("(Select minimum one archive)"))
# Toggle diff button
if self.repoactions_enabled and len(indexes) == 2:
# Enable diff button
self.bDiff.setEnabled(True)
self.bDiff.setToolTip(self.tooltip_dict.get(self.bDiff, ""))
else:
# disable diff button
self.bDiff.setEnabled(False)
tooltip = self.tooltip_dict[self.bDiff]
self.bDiff.setToolTip(tooltip + " " + reason or self.tr("(Select two archives)"))
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
if self.repoactions_enabled and len(indexes) == 1:
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
# Enable archive actions
self.fArchiveActions.setEnabled(True)
for index in range(layout.count()):
widget = layout.itemAt(index).widget()
widget.setToolTip(self.tooltip_dict.get(widget, ""))
# refresh bMountArchive for the selected archive
self.bmountarchive_refresh()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
else:
reason = reason or self.tr("(Select exactly one archive)")
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
# too few or too many selected.
self.fArchiveActions.setEnabled(False)
for index in range(layout.count()):
widget = layout.itemAt(index).widget()
tooltip = widget.toolTip()
tooltip = self.tooltip_dict.setdefault(widget, tooltip)
widget.setToolTip(tooltip + " " + reason)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
# special treatment for dynamic mount/unmount button.
self.bmountarchive_refresh()
tooltip = self.bMountArchive.toolTip()
self.bMountArchive.setToolTip(tooltip + " " + reason)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
def archive_copy(self, index=None):
"""
Copy an archive name to the clipboard.
Copies the first selected archive if no index is specified.
"""
if index is None:
indexes = self.archiveTable.selectionModel().selectedRows()
if not indexes:
return
index = indexes[0]
archive_name = self.archiveTable.item(index.row(), 4).text()
data = QMimeData()
data.setText(archive_name)
QApplication.clipboard().setMimeData(data)
def save_archive_template(self, tpl, key):
profile = self.profile()
try:
preview = self.tr('Preview: %s') % format_archive_name(profile, tpl)
setattr(profile, key, tpl)
profile.save()
except Exception:
preview = self.tr('Error in archive name template.')
if key == 'new_archive_name':
self.archiveNamePreview.setText(preview)
else:
self.prunePrefixPreview.setText(preview)
def check_action(self):
params = BorgCheckJob.prepare(self.profile())
if not params['ok']:
self._set_status(params['message'])
return
# Conditions are met (borg binary available, etc)
row_selected = self.archiveTable.selectionModel().selectedRows()
if row_selected:
archive_cell = self.archiveTable.item(row_selected[0].row(), 4)
if archive_cell:
archive_name = archive_cell.text()
params['cmd'][-1] += f'::{archive_name}'
job = BorgCheckJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
job.result.connect(self.check_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
def check_result(self, result):
if result['returncode'] == 0:
self._toggle_all_buttons(True)
def compact_action(self):
params = BorgCompactJob.prepare(self.profile())
if params['ok']:
job = BorgCompactJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
job.result.connect(self.compact_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
else:
self._set_status(params['message'])
def compact_result(self, result):
self._toggle_all_buttons(True)
def prune_action(self):
params = BorgPruneJob.prepare(self.profile())
if params['ok']:
job = BorgPruneJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
job.result.connect(self.prune_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
else:
self._set_status(params['message'])
def prune_result(self, result):
if result['returncode'] == 0:
self._set_status(self.tr('Pruning finished.'))
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self.refresh_archive_list()
else:
self._toggle_all_buttons(True)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
def refresh_archive_list(self):
params = BorgListRepoJob.prepare(self.profile())
if params['ok']:
job = BorgListRepoJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
job.result.connect(self.list_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
else:
self._set_status(params['message'])
def list_result(self, result):
self._toggle_all_buttons(True)
if result['returncode'] == 0:
self._set_status(self.tr('Refreshed archives.'))
self.populate_from_profile()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
def refresh_archive_info(self):
archive_name = self.selected_archive_name()
if archive_name is not None:
params = BorgInfoArchiveJob.prepare(self.profile(), archive_name)
if params['ok']:
job = BorgInfoArchiveJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
job.result.connect(self.info_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
def info_result(self, result):
self._toggle_all_buttons(True)
if result['returncode'] == 0:
self._set_status(self.tr('Refreshed archive.'))
self.populate_from_profile()
def selected_archive_name(self):
row_selected = self.archiveTable.selectionModel().selectedRows()
if row_selected:
archive_cell = self.archiveTable.item(row_selected[0].row(), 4)
if archive_cell:
return archive_cell.text()
return None
def bmountarchive_clicked(self):
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
"""
Handle `bMountArchive` being clicked.
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
Mount or umount the current archive depending on its current state.
"""
archive_name = self.selected_archive_name()
if not archive_name:
logger.warning("Archive name of selection is empty.")
return
if archive_name in self.mount_points:
self.unmount_action(archive_name=archive_name)
else:
self.mount_action(archive_name=archive_name)
def bmountrepo_clicked(self):
"""
Handle `bMountRepo` being clicked.
Mount or umount the repository depending on its current state.
"""
if self.repo_mount_point:
self.unmount_action()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
else:
self.mount_action()
def bmountarchive_refresh(self, icon_only=False):
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
"""
Update label, tooltip and state of `bMountArchive`.
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
The new state depends on the mount status of the current archive.
This also updates the icon of the button.
"""
archive_name = self.selected_archive_name()
if archive_name in self.mount_points:
self.bMountArchive.setIcon(get_colored_icon('eject'))
if not icon_only:
self.bMountArchive.setText(self.tr("Unmount"))
self.bMountArchive.setToolTip(self.tr('Unmount the selected archive from the file system'))
else:
self.bMountArchive.setIcon(get_colored_icon('folder-open'))
if not icon_only:
self.bMountArchive.setText(self.tr("Mount…"))
self.bMountArchive.setToolTip(self.tr("Mount the selected archive " + "as a folder in the file system"))
def bmountrepo_refresh(self):
"""
Update label, tooltip and state of `bMountRepo`.
The new state depends on the mount status of the current archive.
This also updates the icon of the button.
"""
if self.repo_mount_point:
self.bMountRepo.setText(self.tr("Unmount"))
self.bMountRepo.setToolTip(self.tr('Unmount the repository from the file system'))
self.bMountRepo.setIcon(get_colored_icon('eject'))
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
else:
self.bMountRepo.setText(self.tr("Mount…"))
self.bMountRepo.setIcon(get_colored_icon('folder-open'))
self.bMountRepo.setToolTip(self.tr("Mount the repository as a folder in the file system"))
def mount_action(self, archive_name=None):
"""
Mount an archive or the whole repository.
Opens a file chooser to let the user choose a mount point and starts
the borg job for mounting afterwards.
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
Parameters
----------
archive_name : str, optional
The archive to mount or None, by default None
"""
profile = self.profile()
params = BorgMountJob.prepare(profile, archive=archive_name)
if not params['ok']:
self._set_status(params['message'])
return
def receive():
mount_point = dialog.selectedFiles()
if mount_point:
params['cmd'].append(mount_point[0])
params['mount_point'] = mount_point[0]
if params['ok']:
self._toggle_all_buttons(False)
job = BorgMountJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self.mountErrors.setText)
job.result.connect(self.mount_result)
self.app.jobs_manager.add_job(job)
dialog = choose_file_dialog(self, self.tr("Choose Mount Point"), want_folder=True)
dialog.open(receive)
def mount_result(self, result):
2018-10-27 17:24:34 +00:00
if result['returncode'] == 0:
self._set_status(self.tr('Mounted successfully.'))
mount_point = result['params']['mount_point']
if result['params'].get('mounted_archive'):
# archive was mounted
archive_name = result['params']['mounted_archive']
self.mount_points[archive_name] = mount_point
# update column in table
row = self.row_of_archive(archive_name)
item = QTableWidgetItem(result['cmd'][-1])
self.archiveTable.setItem(row, 3, item)
# update button
self.bmountarchive_refresh()
else:
# whole repo was mounted
self.repo_mount_point = mount_point
self.bmountrepo_refresh()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self._toggle_all_buttons(True)
def unmount_action(self, archive_name=None):
"""
Unmount a (mounted) repository or archive.
If the target isn't mounted nothing happens.
Parameters
----------
archive_name : str, optional
The archive to unmount, by default None
"""
if archive_name:
# unmount a single archive
mount_point = self.mount_points.get(archive_name)
else:
# unmount the whole repository
mount_point = self.repo_mount_point
if mount_point is not None:
profile = self.profile()
params = BorgUmountJob.prepare(profile, mount_point, archive_name=archive_name)
if not params['ok']:
self._set_status(translate('message', params['message']))
return
job = BorgUmountJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self.mountErrors.setText)
job.result.connect(self.umount_result)
self.app.jobs_manager.add_job(job)
def umount_result(self, result):
self._toggle_all_buttons(True)
archive_name = result['params'].get('current_archive')
mount_point = result['params']['mount_point']
if result['returncode'] == 0:
self._set_status(self.tr('Un-mounted successfully.'))
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
if archive_name:
# unmount single archive
del self.mount_points[archive_name]
row = self.row_of_archive(archive_name)
item = QTableWidgetItem('')
self.archiveTable.setItem(row, 3, item)
# update button
self.bmountarchive_refresh()
else:
# unmount repo
self.repo_mount_point = None
self.bmountrepo_refresh()
else:
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
self._set_status(self.tr('Unmounting failed. Make sure no programs are using {}').format(mount_point))
def save_prune_setting(self, new_value=None):
profile = self.profile()
for i in self.prune_intervals:
setattr(profile, f'prune_{i}', getattr(self, f'prune_{i}').value())
profile.prune_keep_within = self.prune_keep_within.text()
profile.save()
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
def extract_action(self):
"""
Open a dialog for choosing what to extract from the selected archive.
"""
profile = self.profile()
row_selected = self.archiveTable.selectionModel().selectedRows()
if row_selected:
archive_cell = self.archiveTable.item(row_selected[0].row(), 4)
if archive_cell:
archive_name = archive_cell.text()
params = BorgListArchiveJob.prepare(profile, archive_name)
if not params['ok']:
self._set_status(params['message'])
return
self._set_status('')
self._toggle_all_buttons(False)
job = BorgListArchiveJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self.mountErrors.setText)
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
job.result.connect(self.extract_list_result)
self.app.jobs_manager.add_job(job)
return job
else:
self._set_status(self.tr('Select an archive to restore first.'))
Improve UX and HIG-conformity. By @real-yfprojects (#1176) * Remove fullstops in the labels of the settings. * src/vorta/store/settings.py (get_misc_setting): Remove fullstops in the `label` fields of each setting. * Fix *Add Profile*-Dialog. * src/vorta/assets/UI/profileadd.ui (label_2): Rename to `profileExplainer`. * src/vorta/assets/UI/profileadd.ui (profileExplainer): Remove unnecessary text and rephrase it in simpler terms. * src/vorta/assets/UI/profileadd.ui (formLayout): Move into frame for better layout in dialog. * src/vorta/assets/UI/profileadd.ui (Dialog): Make dialog modal. * src/vorta/assets/UI/profileadd.ui : Modify spacing a bit and change all widgets to `expanding` mode. * src/vorta/assets/UI/profileadd.ui (Dialog): Set title to `Add Profile`. * src/vorta/assets/UI/profileadd.ui : Make `label_3` a buddy of `profileNameField`. * Add colon after entry label in `Add Profile`-Dialog. * src/vorta/assets/UI/profileadd.ui (label_3): Add colon at the end of label. * Fix capitalization in schedule tab. * src/vorta/assets/UI/scheduletab.ui (pruneCheckBox): Replace `Archive` by `archive`. * Fix tooltips. Ensure sentence capitalization. Rephrase some tooltips that do not mention the action they provide a tip for. (There are still many to go.) Remove fullstop from tooltips that aren't a sentence. Add fullstop to tooltips that are a sentence. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py * src/vorta/views/source_tab.py * Replace `n't` by `not` in GUI strings. * src/vorta/application.py * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sshadd.ui * src/vorta/notifications.py * src/vorta/views/main_window.py * src/vorta/views/main_window.py * src/vorta/views/repo_tab.py * Shorten unlink button tooltip. * src/vorta/assets/UI/repotab.ui (repoRemoveToolbutton): Shorten tooltip by only keeping the most valuable information needed to understand the feature. * Fix entry being embedded in label text. Sentences should not be constructed from text in several controls. Sentences that run from one control to another will often not make sense when translated into other languages. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/scheduletab.ui * Rewrite tooltips to make them HIG conform. The KDE HIG was used. * src/vorta/assets/UI/exportwindow.ui * src/vorta/assets/UI/importwindow.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repoadd.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/export_window.py * src/vorta/views/import_window.py (ImportWindow.init_overwrite_profile_checkbox): Make tooltip static as the HIG suggests. * src/vorta/views/main_window.py * Replace `...` with unicode ellipses `…` (U+2028) in GUI text. * src/vorta/borg/break_lock.py * src/vorta/borg/check.py * src/vorta/borg/create.py * src/vorta/borg/delete.py * src/vorta/borg/diff.py * src/vorta/borg/extract.py * src/vorta/borg/info_archive.py * src/vorta/borg/info_repo.py * src/vorta/borg/init.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_archive.py * src/vorta/borg/list_repo.py * Clean prune tab in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Prettify `repotab`. * src/vorta/assets/UI/repotab.ui * Fix tooltips for pruning in `archivetab.ui`. * src/vorta/assets/UI/archivetab.ui * Use affirmative phrase in checkbox for metered networks. * src/vorta/assets/UI/scheduletab.ui (dontRunOnMeteredNetworksCheckbox): Rename to `meteredNetworksCheckBox`. * src/vorta/assets/UI/scheduletab.ui (meteredNetworksCheckBox): Change text into affirmative phrase. * src/vorta/views/schedule_tab.py : Invert values for `meteredNetworksCheckBox`. * Add label in shell commands pane in `scheduletab` and fix placeholders. Placeholders shouldn't be a replacement for a label. * src/vorta/assets/UI/scheduletab.ui * Group settings widgets in `misctab`. * src/vorta/assets/UI/misctab.ui (checkboxLayout): Replace with frame `frameSettings` containing a form layout. * src/vorta/utils.py (search): Added. Searches for a key inside an iterable applying a given function before comparison. * src/vorta/store/models.py (SettingsModel): Add field `group` to assign settings to a group. * src/vorta/store/migrations.py (run_migrations): Add new schema version `19` and implement migration adding the `group` field. * src/vorta/store/connection.py (SCHEMA_VERSION): Update to `19`. * src/vorta/store/settings.py (get_misc_settings): Add and assign settings groups. * src/vorta/store/connection.py (init_db): Update group and type of settings if needed. * src/vorta/views/misc_tab.py (Imports): Import `search` from `..utils`. * src/vorta/views/misc_tab.py : Instanciate logger. * src/vorta/views/misc_tab.py (MiscTab.__init__): Create a checkboxLayout for `frameSettings`. * src/vorta/views/misc_tab.py (populate): Add settings widgets in groups with labels in spacer in between. * Fix tests for `misctab`. * tests/test_misc.py * Fix margins. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/misctab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/scheduletab.ui * src/vorta/assets/UI/sourcetab.ui * Morph buttons in `sourcetab` into toolbuttons with icons. Adds gradient buttons along the way. Fixes #933. * src/vorta/assets/UI/sourcetab.ui : Change layout and buttons. Merge buttons with adding capabilities into one toolbutton (with menu). * src/vorta/assets/UI/sourcetab.ui : Rename `sourceRemove` to `removeButton`. Rename `sourceUpdate` to `updateButton`. Add `addButton`. * src/vorta/assets/icons/minus.svg : Add minus sign icon from *fontawesome* v6.0. * src/vorta/views/source_tab.py (SourceTab.set_icons): Added. * src/vorta/views/source_tab.py (SourceTab.__init__): Create Menu for the `addButton` with actions to add files and folders and to paste. * src/vorta/application.py (VortaApp.eventFilter): Call `set_icons` of `sourceTab` as well. * Fix tests for `sourcetab`. * tests/test_source.py * Add paste icon to paste action in `sourcetab`. * src/vorta/assets/icons/paste.svg : Added from fontawesome (paste-solid, v6.0) * src/vorta/views/source_tab.py (SourceTab.__init__): Save paste action in `pasteAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for `pasteAction`. * Add icons to open actions in `sourcetab`. * src/vorta/assets/icons/file.svg : Added `file-solid` from fontawesome, v6.0 * src/vorta/assets/icons/folder.svg : Added `folder-solid` from fontawesome, v6.0 * src/vorta/views/source_tab.py (SourceTab.__init__): Save files and folders action to `addFilesAction` and `addFoldersAction`. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icons for `addFilesAction` and `addFolderAction`. * Fix icon size of `file.svg`. * src/vorta/assets/icons/file.svg * Set fill of added svgs to `#000000`. * src/vorta/assets/icons/file.svg * src/vorta/assets/icons/folder.svg * src/vorta/assets/icons/minus.svg * src/vorta/assets/icons/paste.svg * Improve UX and consistency within the app for `scheduletab`. * src/vorta/assets/UI/scheduletab.ui : Arrange schedule pane in a form layout. * src/vorta/views/schedule_tab.py (ScheduleTab.__init__): Connect enabled state of entries to radiobuttons and checkboxes. * Workaround scheduletab tests being broken in github actions. For some unknown reason clicking the `scheduleFixedRadio` won't work when running using github action on ubuntu. * tests/test_schedule.py * Fix labels and spacing in `scheduletab`. * src/vorta/assets/UI/scheduletab.ui * Make archive operations more accessible and rename actions of `ArchiveTab`. * src/vorta/views/archive_tab.py (ArchiveTab): Rename `list_action` to `refresh_archive_list`. Rename `refresh_archive_action` to `refresh_archive_info`. Rename `refresh_archive_result` to `info_result`. Rename `list_archive_action` to `extract_action`. Rename `list_archive_result` to `extract_list_result`. * src/vorta/views/main_window.py : Apply renaming. * src/vorta/assets/UI/archivetab.ui : Create own buttons for the archive actions. Remove `archiveActionButton`. And some other layout changes. * src/vorta/assets/UI/archivetab.ui : Rename `pruneButton` to `bPrune`. Rename `checkButton` to `bCheck`. Rename `diffButton` to `bDiff`. Rename `listButton` to `bList`. * tests/test_archives.py : Apply renaming. * src/vorta/views/archive_tab.py : Connect new action buttons. * src/vorta/views/archive_tab.py : Remove `archiveActionButton`. * tests/test_archives.py : Fix tests. * Enable and disable archive actions depending on selection. * src/vorta/assets/UI/archivetab.ui : Put archive actions into a frame. * src/vorta/views/archive_tab.py (ArchiveTab): Added `on_selection_change` that enables/disables the frame depending on the selection count. * src/vorta/views/archive_tab.py (ArchiveTab.populate_from_profile): Clear selection. * src/vorta/views/archive_tab.py (ArchiveTab.__toggle_all_buttons): Add `fArchiveActions`. Call `on_selection_change` at the end. * Fix tests for `archivetab`. * tests/test_archives.py * Replace line by spacer in repotab. * src/vorta/assets/UI/repotab.ui * Show labels for archive action buttons. * src/vorta/assets/UI/archivetab.ui * Add tooltips and ellipses to archivetab. * src/vorta/assets/UI/archivetab.ui * src/vorta/views/archive_tab.py * Fix tooltips. * src/vorta/assets/UI/sourcetab.ui : Add tooltips. * src/vorta/views/archive_tab.py (ArchiveTab.on_selection_change): Add reason for disabled state dynamically to archive action buttons. * Add context menu to source view. * src/vorta/views/source_tab.py (SourceTab): Implement `sourceitem_contextmenu` and `source_copy`. Set context menu policiy of `sourceFilesWidget` to `CustomContextMenu`. * src/vorta/assets/UI/sourcetab.ui: Change size hints. * Add context menu to archive view. * src/vorta/views/archive_tab.py (ArchiveTab): Set context menu policy of `archiveTable` to `CustomContextMenu`. Implement `archiveitem_contextmenu`. * Replace `Type` column in sources view by icon. * src/vorta/views/source_tab.py (SourceColumn): Remove `Type` column. * src/vorta/views/source_tab.py (SourceTab.set_icons): Set icon for each item in source view. * src/vorta/views/source_tab.py (SourceTab.set_path_info): Set icon instead of `Type` column. * src/vorta/assets/UI/sourcetab.ui : Remove `Type` column. * Fix initial sort indicator of source view. * src/vorta/views/source_tab.py * Fix adding items while sorting enabled. * src/vorta/views/source_tab.py * Remove status bar and remove fix size hint for log text label. * src/vorta/assets/UI/mainwindow.ui * src/vorta/views/main_window.py (MainWindow.__init__): Set minimum height of `logText` to two times the height of a line calculated by `QFontMetrics`. * Resize main window height to `670`. * src/vorta/assets/UI/mainwindow.ui * Replace `QToolbutton` by `QPushbutton`. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * src/vorta/views/source_tab.py * Fix flake8 * Improve label of entry for `borg create` extra arguments. * src/vorta/assets/UI/scheduletab.ui * Unify label font size in `repotab`. * src/vorta/assets/UI/repotab.ui * Morph `QPushButton`s into `QToolButton`s. Some exceptions were made, especially in the dialog windows. * src/vorta/assets/UI/archivetab.ui * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * src/vorta/assets/UI/sourcetab.ui * Add copy capabilities to archive view and a copy shortcut to it and to source tab. * src/vorta/views/source_tab.py (SourceTab): Add QShortcut for copying. * src/vorta/views/archive_tab.py (ArchiveTab.archiveitem_contextmenu): Add copy action. * src/vorta/views/archive_tab.py (ArchiveTab): Add QShortcut for copying. * Move actions in comboBoxes to buttons. * src/vorta/assets/UI/repotab.ui : Add `bAddSSHKey` and `bAddRepo`. * src/vorta/views/repo_tab.py : Move code out of `ssh_select_action` and `repo_select_action` into `add_existing_repo`, `new_repo` and `create_ssh_key`. * src/vorta/views/repo_tab.py * Make tooltip of `storePassword` checkbox more fluent. * src/vorta/assets/UI/exportwindow.ui * Introduce `QDialogButtonBox` to modal dialogs in vorta. * src/vorta/assets/UI/extractdialog.ui * src/vorta/views/extract_dialog.py * src/vorta/assets/UI/repoadd.ui * src/vorta/views/repo_add_dialog.py * src/vorta/assets/UI/sshadd.ui * src/vorta/views/ssh_dialog.py * Move some options in scheduletab to the side. This results in two columns of options and fixes vertical scrolling. * src/vorta/assets/UI/scheduletab.ui * Changes for macOS layout * Set `sizeAdjustPolicy` of comboBoxes to `AdustToContents`. * src/vorta/assets/UI/mainwindow.ui * src/vorta/assets/UI/repotab.ui * Fix some icons, translations strings and link * Lint Co-authored-by: real-yfprojects <real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com> Co-authored-by: Manu <manu@snapdragon.cc>
2022-03-24 06:27:07 +00:00
def extract_list_result(self, result):
"""Process the contents of the archive to extract."""
self._set_status('')
if result['returncode'] == 0:
archive = ArchiveModel.get(name=result['params']['archive_name'])
model = ExtractTree()
self._set_status(self.tr("Processing archive contents"))
self._t = extract_dialog.ParseThread(result['data'], model)
self._t.finished.connect(lambda: self.extract_show_dialog(archive, model))
self._t.start()
def extract_show_dialog(self, archive, model):
"""Show the dialog for choosing the archive contents to extract."""
self._set_status('')
def process_result():
def receive():
extraction_folder = dialog.selectedFiles()
if extraction_folder:
params = BorgExtractJob.prepare(self.profile(), archive.name, model, extraction_folder[0])
if params['ok']:
self._toggle_all_buttons(False)
job = BorgExtractJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self.mountErrors.setText)
job.result.connect(self.extract_archive_result)
self.app.jobs_manager.add_job(job)
else:
self._set_status(params['message'])
dialog = choose_file_dialog(self, self.tr("Choose Extraction Point"), want_folder=True)
dialog.open(receive)
window = ExtractDialog(archive, model)
self._toggle_all_buttons(True)
window.setParent(self, QtCore.Qt.WindowType.Sheet)
self._window = window # for testing
window.show()
window.accepted.connect(process_result)
def extract_archive_result(self, result):
"""Finished extraction."""
self._toggle_all_buttons(True)
def cell_double_clicked(self, row, column):
if column == 3:
archive_name = self.selected_archive_name()
if not archive_name:
return
mount_point = self.mount_points.get(archive_name)
if mount_point is not None:
QDesktopServices.openUrl(QtCore.QUrl(f'file:///{mount_point}'))
def row_of_archive(self, archive_name):
items = self.archiveTable.findItems(archive_name, QtCore.Qt.MatchFlag.MatchExactly)
rows = [item.row() for item in items if item.column() == 4]
return rows[0] if rows else None
def confirm_dialog(self, title, text):
2019-02-02 04:29:33 +00:00
msg = QMessageBox()
msg.setIcon(QMessageBox.Icon.Information)
2019-02-02 04:29:33 +00:00
msg.setText(text)
msg.setWindowTitle(title)
msg.setStandardButtons(QMessageBox.StandardButton.Yes | QMessageBox.StandardButton.Cancel)
msg.button(QMessageBox.StandardButton.Yes).setText(self.tr("Yes"))
msg.button(QMessageBox.StandardButton.Cancel).setText(self.tr("Cancel"))
return msg.exec() == QMessageBox.StandardButton.Yes
def delete_action(self):
# Since this function modify the UI, we can't put the whole function in a JobQUeue.
# determine selected archives
archives = []
for index in self.archiveTable.selectionModel().selectedRows():
archive_cell = self.archiveTable.item(index.row(), 4)
if archive_cell:
archives.append(archive_cell.text())
if not archives:
self._set_status(self.tr("No archive selected"))
return
params = BorgDeleteJob.prepare(self.profile(), archives)
if not params['ok']:
self._set_status(params['message'])
return
if len(archives) > 1:
body = self.tr("Are you sure you want to delete all the selected archives?")
else:
body = self.tr("Are you sure you want to delete the selected archive?")
if not self.confirm_dialog(self.tr("Confirm deletion"), body):
return
job = BorgDeleteJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
job.result.connect(self.delete_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
def delete_result(self, result):
archives = result['params']['archives']
if result['returncode'] == 0:
if len(archives) > 1:
status = self.tr('Archives deleted.')
else:
status = self.tr('Archive deleted.')
self._set_status(status)
# remove rows from list and database
for archive in archives:
for entry in self.archiveTable.findItems(archive, QtCore.Qt.MatchFlag.MatchExactly):
self.archiveTable.removeRow(entry.row())
ArchiveModel.get(name=archive).delete_instance()
self._toggle_all_buttons(True)
2019-07-04 19:17:09 +00:00
def diff_action(self):
"""
Handle the diff button being clicked.
2019-07-04 19:17:09 +00:00
Exactly two archives must be selected in `archiveTable`. This is
usually enforced by `on_selection_change`.
"""
selected_archives = self.archiveTable.selectionModel().selectedRows()
profile = self.profile()
2019-07-04 19:17:09 +00:00
name1 = self.archiveTable.item(selected_archives[0].row(), 4).text()
name2 = self.archiveTable.item(selected_archives[1].row(), 4).text()
2019-07-04 19:17:09 +00:00
archive1, archive2 = (
profile.repo.archives.select()
.where((ArchiveModel.name == name1) | (ArchiveModel.name == name2))
.order_by(ArchiveModel.time.desc())
2022-08-15 05:21:14 +00:00
)
archive_name_newer = archive1.name
archive_name_older = archive2.name
# Start diff job
params = BorgDiffJob.prepare(profile, archive_name_older, archive_name_newer)
if params['ok']:
self._toggle_all_buttons(False)
job = BorgDiffJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self.mountErrors.setText)
job.result.connect(self.list_diff_result)
self.app.jobs_manager.add_job(job)
else:
self._set_status(params['message'])
2019-07-04 19:17:09 +00:00
def list_diff_result(self, result):
"""
Process the result of the `BorgDiffJob`.
The `BorgDiffJob` was initiated by `diff_action`.
Parameters
----------
result : dict
The BorgJob result.
"""
2019-07-04 19:17:09 +00:00
self._set_status('')
if result['returncode'] == 0:
archive_newer = ArchiveModel.get(name=result['params']['archive_name_newer'])
archive_older = ArchiveModel.get(name=result['params']['archive_name_older'])
self._set_status(self.tr("Processing diff results."))
model = DiffTree()
self._t = diff_result.ParseThread(result['data'], result['params']['json_lines'], model)
self._t.finished.connect(lambda: self.show_diff_result(archive_newer, archive_older, model))
self._t.start()
def show_diff_result(self, archive_newer, archive_older, model):
self._t = None
# show dialog
self._toggle_all_buttons(True)
self._set_status('')
window = DiffResultDialog(archive_newer, archive_older, model)
window.setParent(self)
window.setWindowFlags(Qt.WindowType.Window)
window.setWindowModality(Qt.WindowModality.NonModal)
self._resultwindow = window # for testing
window.show()
def rename_action(self):
profile = self.profile()
archive_name = self.selected_archive_name()
if archive_name is not None:
new_name, finished = QInputDialog.getText(
self,
self.tr("Change name"),
self.tr("New archive name:"),
text=archive_name,
)
if not finished:
return
if not new_name:
self._set_status(self.tr('Archive name cannot be blank.'))
return
new_name_exists = ArchiveModel.get_or_none(name=new_name, repo=profile.repo)
if new_name_exists is not None:
self._set_status(self.tr('An archive with this name already exists.'))
return
params = BorgRenameJob.prepare(profile, archive_name, new_name)
if not params['ok']:
self._set_status(params['message'])
job = BorgRenameJob(params['cmd'], params, self.profile().repo.id)
job.updated.connect(self._set_status)
job.result.connect(self.rename_result)
self._toggle_all_buttons(False)
self.app.jobs_manager.add_job(job)
else:
self._set_status(self.tr("No archive selected"))
def rename_result(self, result):
if result['returncode'] == 0:
self._set_status(self.tr('Archive renamed.'))
self.populate_from_profile()
else:
self._toggle_all_buttons(True)